mirror of
https://github.com/emilk/egui.git
synced 2026-06-26 14:49:06 -04:00
Use log crate instead of eprintln & remove some unwraps (#5010)
<!-- Please read the "Making a PR" section of [`CONTRIBUTING.md`](https://github.com/emilk/egui/blob/master/CONTRIBUTING.md) before opening a Pull Request! * Keep your PR:s small and focused. * The PR title is what ends up in the changelog, so make it descriptive! * If applicable, add a screenshot or gif. * If it is a non-trivial addition, consider adding a demo for it to `egui_demo_lib`, or a new example. * Do NOT open PR:s from your `master` branch, as that makes it hard for maintainers to test and add commits to your PR. * Remember to run `cargo fmt` and `cargo clippy`. * Open the PR as a draft until you have self-reviewed it and run `./scripts/check.sh`. * When you have addressed a PR comment, mark it as resolved. Please be patient! I will review your PR, but my time is limited! --> - I fixed the TODO to use the `log` crate instead of `eprintln` - Set the rust-version in the `scripts/check.sh` to the same as egui is on - I made xtask use anyhow to remove some unwraps * [x] I have followed the instructions in the PR template
This commit is contained in:
@@ -34,7 +34,7 @@ pub fn ask_to_run(mut cmd: Command, ask: bool, reason: &str) -> Result<(), DynEr
|
||||
a => return Err(format!("Invalid answer `{a}`").into()),
|
||||
};
|
||||
} else {
|
||||
eprintln!("Running `{cmd:?}` to {reason}.");
|
||||
println!("Running `{cmd:?}` to {reason}.");
|
||||
}
|
||||
|
||||
let status = cmd.status()?;
|
||||
|
||||
Reference in New Issue
Block a user