migrations/egui
1
0
Fork 0
mirror of https://github.com/emilk/egui.git synced 2026-09-02 14:50:03 -04:00
Code Activity

Avoid interacting twice when not required (#4041)

Browse Source 
This PR short-circuits `Response::interact()` when the `Response` has
already been sufficiently "sensed" already. In some circumstance, this
can avoid unnecessarily registering another widget rect that may mask
some other widget.

One such instance is Rerun's `ListItem`. Calling `context_menu()` on its
response would call `interact` and, in turn, mask its sub-widget
(collapsing triangle, show/hide buttons, etc.).
This commit is contained in:
Antoine Beyeler
2024-02-14 09:07:33 +01:00
committed by Emil Ernerfeldt
parent ed5fe01535
commit 1ce4f05472
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
crates/egui/src/response.rs
View File

@@ -601,6 +601,13 @@ impl Response {
/// ``` /// ```
#[must_use] #[must_use]
pub fn interact(&self, sense: Sense) -> Self { pub fn interact(&self, sense: Sense) -> Self {
// Test if we must sense something new compared to what we have already sensed. If not, then
// we can return early. This may avoid unnecessarily "masking" some widgets with unneeded
// interactions.
if (self.sense | sense) == self.sense {
return self.clone();
}
// Temporary hack for 0.26.1 to avoid breaking change. // Temporary hack for 0.26.1 to avoid breaking change.
let clip_rect = self.ctx.graphics(|g| { let clip_rect = self.ctx.graphics(|g| {
g.get(self.layer_id) g.get(self.layer_id)