mirror of
https://github.com/emilk/egui.git
synced 2026-08-29 04:40:03 -04:00
Remove redundant lint entries from Cargo.toml (#8393)
30 lints in `[workspace.lints]` were set to `warn` despite already being warn-by-default, or part of a lint group that is already enabled. * `rust`: `elided_lifetimes_in_paths` and `unused_extern_crates` are in `rust_2018_idioms`; `semicolon_in_expressions_from_macros` is in `future_incompatible`; `unexpected_cfgs` and `unsafe_op_in_unsafe_fn` are warn-by-default (the latter since edition 2024); `rust_2021_prelude_collisions` never fires on edition 2021+. * `rustdoc`: `broken_intra_doc_links` and `missing_crate_level_docs` are in `rustdoc::all`. * `clippy`: 22 lints that are in `clippy::all`. The explicit `allow`s are kept, even though they are no-ops today, to record our intent in case we ever enable `pedantic`. No behavior change: `cargo clippy --all-features --all-targets` gives the same output before and after. * [x] I have followed the instructions in the PR template 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This commit is contained in:
32
Cargo.toml
32
Cargo.toml
@@ -164,16 +164,10 @@ winit = { version = "0.30.13", default-features = false }
|
|||||||
[workspace.lints.rust]
|
[workspace.lints.rust]
|
||||||
unsafe_code = "deny"
|
unsafe_code = "deny"
|
||||||
|
|
||||||
elided_lifetimes_in_paths = "warn"
|
|
||||||
future_incompatible = { level = "warn", priority = -1 }
|
future_incompatible = { level = "warn", priority = -1 }
|
||||||
nonstandard_style = { level = "warn", priority = -1 }
|
nonstandard_style = { level = "warn", priority = -1 }
|
||||||
rust_2018_idioms = { level = "warn", priority = -1 }
|
rust_2018_idioms = { level = "warn", priority = -1 }
|
||||||
rust_2021_prelude_collisions = "warn"
|
|
||||||
semicolon_in_expressions_from_macros = "warn"
|
|
||||||
trivial_numeric_casts = "warn"
|
trivial_numeric_casts = "warn"
|
||||||
unexpected_cfgs = "warn"
|
|
||||||
unsafe_op_in_unsafe_fn = "warn" # `unsafe_op_in_unsafe_fn` may become the default in future Rust versions: https://github.com/rust-lang/rust/issues/71668
|
|
||||||
unused_extern_crates = "warn"
|
|
||||||
unused_import_braces = "warn"
|
unused_import_braces = "warn"
|
||||||
unused_lifetimes = "warn"
|
unused_lifetimes = "warn"
|
||||||
|
|
||||||
@@ -182,8 +176,6 @@ unused_qualifications = "allow"
|
|||||||
|
|
||||||
[workspace.lints.rustdoc]
|
[workspace.lints.rustdoc]
|
||||||
all = "warn"
|
all = "warn"
|
||||||
missing_crate_level_docs = "warn"
|
|
||||||
broken_intra_doc_links = "warn"
|
|
||||||
|
|
||||||
# See also clippy.toml
|
# See also clippy.toml
|
||||||
[workspace.lints.clippy]
|
[workspace.lints.clippy]
|
||||||
@@ -191,10 +183,8 @@ all = { level = "warn", priority = -1 }
|
|||||||
|
|
||||||
allow_attributes = "warn"
|
allow_attributes = "warn"
|
||||||
as_ptr_cast_mut = "warn"
|
as_ptr_cast_mut = "warn"
|
||||||
await_holding_lock = "warn"
|
|
||||||
bool_to_int_with_if = "warn"
|
bool_to_int_with_if = "warn"
|
||||||
branches_sharing_code = "warn"
|
branches_sharing_code = "warn"
|
||||||
char_lit_as_u8 = "warn"
|
|
||||||
checked_conversions = "warn"
|
checked_conversions = "warn"
|
||||||
clear_with_drain = "warn"
|
clear_with_drain = "warn"
|
||||||
clone_on_ref_ptr = "warn"
|
clone_on_ref_ptr = "warn"
|
||||||
@@ -205,11 +195,7 @@ debug_assert_with_mut_call = "warn"
|
|||||||
decimal_bitwise_operands = "warn"
|
decimal_bitwise_operands = "warn"
|
||||||
default_union_representation = "warn"
|
default_union_representation = "warn"
|
||||||
derive_partial_eq_without_eq = "warn"
|
derive_partial_eq_without_eq = "warn"
|
||||||
disallowed_macros = "warn" # See clippy.toml
|
|
||||||
disallowed_methods = "warn" # See clippy.toml
|
|
||||||
disallowed_names = "warn" # See clippy.toml
|
|
||||||
disallowed_script_idents = "warn" # See clippy.toml
|
disallowed_script_idents = "warn" # See clippy.toml
|
||||||
disallowed_types = "warn" # See clippy.toml
|
|
||||||
doc_broken_link = "warn"
|
doc_broken_link = "warn"
|
||||||
doc_comment_double_space_linebreaks = "warn"
|
doc_comment_double_space_linebreaks = "warn"
|
||||||
doc_include_without_cfg = "warn"
|
doc_include_without_cfg = "warn"
|
||||||
@@ -219,7 +205,6 @@ duration_suboptimal_units = "warn"
|
|||||||
elidable_lifetime_names = "warn"
|
elidable_lifetime_names = "warn"
|
||||||
empty_enum_variants_with_brackets = "warn"
|
empty_enum_variants_with_brackets = "warn"
|
||||||
empty_enums = "warn"
|
empty_enums = "warn"
|
||||||
empty_line_after_outer_attr = "warn"
|
|
||||||
enum_glob_use = "warn"
|
enum_glob_use = "warn"
|
||||||
equatable_if_let = "warn"
|
equatable_if_let = "warn"
|
||||||
exit = "warn"
|
exit = "warn"
|
||||||
@@ -236,11 +221,9 @@ fn_to_numeric_cast_any = "warn"
|
|||||||
format_push_string = "warn"
|
format_push_string = "warn"
|
||||||
from_iter_instead_of_collect = "warn"
|
from_iter_instead_of_collect = "warn"
|
||||||
get_unwrap = "warn"
|
get_unwrap = "warn"
|
||||||
if_let_mutex = "warn"
|
|
||||||
ignore_without_reason = "warn"
|
ignore_without_reason = "warn"
|
||||||
ignored_unit_patterns = "warn"
|
ignored_unit_patterns = "warn"
|
||||||
implicit_clone = "warn"
|
implicit_clone = "warn"
|
||||||
implied_bounds_in_impls = "warn"
|
|
||||||
imprecise_flops = "warn"
|
imprecise_flops = "warn"
|
||||||
inconsistent_struct_constructor = "warn"
|
inconsistent_struct_constructor = "warn"
|
||||||
index_refutable_slice = "warn"
|
index_refutable_slice = "warn"
|
||||||
@@ -262,23 +245,19 @@ large_include_file = "warn"
|
|||||||
large_stack_arrays = "warn"
|
large_stack_arrays = "warn"
|
||||||
large_stack_frames = "warn"
|
large_stack_frames = "warn"
|
||||||
large_types_passed_by_value = "warn"
|
large_types_passed_by_value = "warn"
|
||||||
let_unit_value = "warn"
|
|
||||||
linkedlist = "warn"
|
linkedlist = "warn"
|
||||||
literal_string_with_formatting_args = "warn"
|
literal_string_with_formatting_args = "warn"
|
||||||
lossy_float_literal = "warn"
|
lossy_float_literal = "warn"
|
||||||
macro_use_imports = "warn"
|
macro_use_imports = "warn"
|
||||||
manual_assert = "warn"
|
manual_assert = "warn"
|
||||||
manual_clamp = "warn"
|
|
||||||
manual_ilog2 = "warn"
|
manual_ilog2 = "warn"
|
||||||
manual_instant_elapsed = "warn"
|
manual_instant_elapsed = "warn"
|
||||||
manual_is_power_of_two = "warn"
|
manual_is_power_of_two = "warn"
|
||||||
manual_is_variant_and = "warn"
|
manual_is_variant_and = "warn"
|
||||||
manual_let_else = "warn"
|
manual_let_else = "warn"
|
||||||
manual_midpoint = "warn" # NOTE `midpoint` is often a lot slower for floats, so we have our own `emath::fast_midpoint` function.
|
manual_midpoint = "warn" # NOTE `midpoint` is often a lot slower for floats, so we have our own `emath::fast_midpoint` function.
|
||||||
manual_ok_or = "warn"
|
|
||||||
manual_string_new = "warn"
|
manual_string_new = "warn"
|
||||||
map_err_ignore = "warn"
|
map_err_ignore = "warn"
|
||||||
map_flatten = "warn"
|
|
||||||
match_bool = "warn"
|
match_bool = "warn"
|
||||||
match_same_arms = "warn"
|
match_same_arms = "warn"
|
||||||
match_wild_err_arm = "warn"
|
match_wild_err_arm = "warn"
|
||||||
@@ -286,14 +265,10 @@ match_wildcard_for_single_variants = "warn"
|
|||||||
mem_forget = "warn"
|
mem_forget = "warn"
|
||||||
mismatching_type_param_order = "warn"
|
mismatching_type_param_order = "warn"
|
||||||
missing_assert_message = "warn"
|
missing_assert_message = "warn"
|
||||||
missing_enforced_import_renames = "warn"
|
|
||||||
missing_errors_doc = "warn"
|
missing_errors_doc = "warn"
|
||||||
missing_fields_in_debug = "warn"
|
missing_fields_in_debug = "warn"
|
||||||
missing_safety_doc = "warn"
|
|
||||||
mixed_attributes_style = "warn"
|
|
||||||
mut_mut = "warn"
|
mut_mut = "warn"
|
||||||
mutex_integer = "warn"
|
mutex_integer = "warn"
|
||||||
needless_borrow = "warn"
|
|
||||||
needless_continue = "warn"
|
needless_continue = "warn"
|
||||||
needless_for_each = "warn"
|
needless_for_each = "warn"
|
||||||
needless_pass_by_ref_mut = "warn"
|
needless_pass_by_ref_mut = "warn"
|
||||||
@@ -304,7 +279,6 @@ negative_feature_names = "warn"
|
|||||||
non_std_lazy_statics = "warn"
|
non_std_lazy_statics = "warn"
|
||||||
non_zero_suggestions = "warn"
|
non_zero_suggestions = "warn"
|
||||||
nonstandard_macro_braces = "warn"
|
nonstandard_macro_braces = "warn"
|
||||||
only_used_in_recursion = "warn"
|
|
||||||
option_as_ref_cloned = "warn"
|
option_as_ref_cloned = "warn"
|
||||||
option_option = "warn"
|
option_option = "warn"
|
||||||
or_fun_call = "warn"
|
or_fun_call = "warn"
|
||||||
@@ -318,7 +292,6 @@ ptr_cast_constness = "warn"
|
|||||||
pub_underscore_fields = "warn"
|
pub_underscore_fields = "warn"
|
||||||
pub_without_shorthand = "warn"
|
pub_without_shorthand = "warn"
|
||||||
rc_mutex = "warn"
|
rc_mutex = "warn"
|
||||||
readonly_write_lock = "warn"
|
|
||||||
redundant_type_annotations = "warn"
|
redundant_type_annotations = "warn"
|
||||||
ref_as_ptr = "warn"
|
ref_as_ptr = "warn"
|
||||||
ref_option = "warn"
|
ref_option = "warn"
|
||||||
@@ -340,11 +313,9 @@ string_add = "warn"
|
|||||||
string_add_assign = "warn"
|
string_add_assign = "warn"
|
||||||
string_lit_as_bytes = "warn"
|
string_lit_as_bytes = "warn"
|
||||||
string_lit_chars_any = "warn"
|
string_lit_chars_any = "warn"
|
||||||
suspicious_command_arg_space = "warn"
|
|
||||||
suspicious_xor_used_as_pow = "warn"
|
suspicious_xor_used_as_pow = "warn"
|
||||||
todo = "warn"
|
todo = "warn"
|
||||||
too_long_first_doc_paragraph = "warn"
|
too_long_first_doc_paragraph = "warn"
|
||||||
too_many_arguments = "warn"
|
|
||||||
trailing_empty_array = "warn"
|
trailing_empty_array = "warn"
|
||||||
trait_duplication_in_bounds = "warn"
|
trait_duplication_in_bounds = "warn"
|
||||||
transmute_ptr_to_ptr = "warn"
|
transmute_ptr_to_ptr = "warn"
|
||||||
@@ -373,13 +344,14 @@ unused_trait_names = "warn"
|
|||||||
unwrap_used = "warn"
|
unwrap_used = "warn"
|
||||||
use_self = "warn"
|
use_self = "warn"
|
||||||
useless_let_if_seq = "warn"
|
useless_let_if_seq = "warn"
|
||||||
useless_transmute = "warn"
|
|
||||||
verbose_file_reads = "warn"
|
verbose_file_reads = "warn"
|
||||||
wildcard_dependencies = "warn"
|
wildcard_dependencies = "warn"
|
||||||
zero_sized_map_values = "warn"
|
zero_sized_map_values = "warn"
|
||||||
|
|
||||||
|
|
||||||
# TODO(emilk): maybe enable more of these lints?
|
# TODO(emilk): maybe enable more of these lints?
|
||||||
|
# NOTE: these are all in `pedantic`/`restriction`/`nursery`, so the `allow` is a no-op today.
|
||||||
|
# We keep them to record our intent in case we ever enable those groups.
|
||||||
cast_possible_wrap = "allow"
|
cast_possible_wrap = "allow"
|
||||||
comparison_chain = "allow"
|
comparison_chain = "allow"
|
||||||
should_panic_without_expect = "allow"
|
should_panic_without_expect = "allow"
|
||||||
|
|||||||
Reference in New Issue
Block a user