migrations/egui
1
0
Fork 0
mirror of https://github.com/emilk/egui.git synced 2026-08-30 13:20:05 -04:00
Code Activity

Remove wildcard imports (#5018)

Browse Source 
<!--
Please read the "Making a PR" section of
[`CONTRIBUTING.md`](https://github.com/emilk/egui/blob/master/CONTRIBUTING.md)
before opening a Pull Request!

* Keep your PR:s small and focused.
* The PR title is what ends up in the changelog, so make it descriptive!
* If applicable, add a screenshot or gif.
* If it is a non-trivial addition, consider adding a demo for it to
`egui_demo_lib`, or a new example.
* Do NOT open PR:s from your `master` branch, as that makes it hard for
maintainers to test and add commits to your PR.
* Remember to run `cargo fmt` and `cargo clippy`.
* Open the PR as a draft until you have self-reviewed it and run
`./scripts/check.sh`.
* When you have addressed a PR comment, mark it as resolved.

Please be patient! I will review your PR, but my time is limited!
-->

I removed (I hope so) all wildcard imports I found.

For me on my pc this improved the build time:
- for egui -5s
- for eframe -12s

* [x] I have followed the instructions in the PR template
This commit is contained in:
Nicolas
2024-08-28 12:18:42 +02:00
committed by GitHub
parent 82036cf59a
commit 343c3d16c3
99 changed files with 423 additions and 208 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
crates/eframe/src/native/glow_integration.rs
View File

@@ -1,4 +1,4 @@
//! Note that this file contains code very similar to [`wgpu_integration`].
//! Note that this file contains code very similar to [`super::wgpu_integration`].
//! When making changes to one you often also want to apply it to the other.
//!
//! This is also very complex code, and not very pretty.
@@ -36,13 +36,13 @@ use egui::{
use egui_winit::accesskit_winit;
use crate::{
native::{epi_integration::EpiIntegration, winit_integration::create_egui_context},
App, AppCreator, CreationContext, NativeOptions, Result, Storage,
native::epi_integration::EpiIntegration, App, AppCreator, CreationContext, NativeOptions,
Result, Storage,
};
use super::{
winit_integration::{EventResult, UserEvent, WinitApp},
*,
epi_integration, event_loop_context,
winit_integration::{create_egui_context, EventResult, UserEvent, WinitApp},
};
// ----------------------------------------------------------------------------
@@ -462,6 +462,8 @@ impl WinitApp for GlowWinitApp {
#[cfg(feature = "accesskit")]
fn on_accesskit_event(&mut self, event: accesskit_winit::Event) -> crate::Result<EventResult> {
use super::winit_integration;
if let Some(running) = &self.running {
let mut glutin = running.glutin.borrow_mut();
if let Some(viewport_id) = glutin.viewport_from_window.get(&event.window_id).copied() {

4
crates/eframe/src/native/wgpu_integration.rs
View File

@@ -1,4 +1,4 @@
//! Note that this file contains code very similar to [`glow_integration`].
//! Note that this file contains code very similar to [`super::glow_integration`].
//! When making changes to one you often also want to apply it to the other.
//!
//! This is also very complex code, and not very pretty.
@@ -29,7 +29,7 @@ use crate::{
App, AppCreator, CreationContext, NativeOptions, Result, Storage,
};
use super::{winit_integration::WinitApp, *};
use super::{epi_integration, event_loop_context, winit_integration, winit_integration::WinitApp};
// ----------------------------------------------------------------------------
// Types: