mirror of
https://github.com/emilk/egui.git
synced 2026-06-26 14:49:06 -04:00
Remove wildcard imports (#5018)
<!-- Please read the "Making a PR" section of [`CONTRIBUTING.md`](https://github.com/emilk/egui/blob/master/CONTRIBUTING.md) before opening a Pull Request! * Keep your PR:s small and focused. * The PR title is what ends up in the changelog, so make it descriptive! * If applicable, add a screenshot or gif. * If it is a non-trivial addition, consider adding a demo for it to `egui_demo_lib`, or a new example. * Do NOT open PR:s from your `master` branch, as that makes it hard for maintainers to test and add commits to your PR. * Remember to run `cargo fmt` and `cargo clippy`. * Open the PR as a draft until you have self-reviewed it and run `./scripts/check.sh`. * When you have addressed a PR comment, mark it as resolved. Please be patient! I will review your PR, but my time is limited! --> I removed (I hope so) all wildcard imports I found. For me on my pc this improved the build time: - for egui -5s - for eframe -12s * [x] I have followed the instructions in the PR template
This commit is contained in:
@@ -9,7 +9,7 @@ set -x
|
||||
# Checks all tests, lints etc.
|
||||
# Basically does what the CI does.
|
||||
|
||||
cargo +1.75.0 install --quiet typos-cli
|
||||
cargo +1.76.0 install --quiet typos-cli
|
||||
|
||||
export RUSTFLAGS="-D warnings"
|
||||
export RUSTDOCFLAGS="-D warnings" # https://github.com/emilk/egui/pull/1454
|
||||
@@ -20,8 +20,9 @@ typos
|
||||
cargo fmt --all -- --check
|
||||
cargo doc --quiet --lib --no-deps --all-features
|
||||
cargo doc --quiet --document-private-items --no-deps --all-features
|
||||
|
||||
cargo clippy --quiet --all-targets --all-features -- -D warnings
|
||||
cargo clippy --all-targets --all-features --release -- -D warnings # we need to check release mode too
|
||||
|
||||
./scripts/clippy_wasm.sh
|
||||
|
||||
cargo check --quiet --all-targets
|
||||
|
||||
Reference in New Issue
Block a user