migrations/egui
1
0
Fork 0
mirror of https://github.com/emilk/egui.git synced 2026-09-01 14:20:04 -04:00
Code Activity

Enable the clippy::pedantic lint group (#8429)

Browse Source 
Instead of opting in to pedantic lints one by one, enable the whole
group and opt out of the noisy ones.

64% of the pedantic lints were already listed individually. This deletes
90 explicit lint lines, enables 51 pedantic lints we never listed, and
picks up new pedantic lints for free. Each opt-out carries its hit
count, so the cost of turning one back on is visible.

`restriction` and `nursery` stay opt-in per lint.

Stacked on top of #8430, which fixes the one real bug the new lints
found.

* [x] I have followed the instructions in the PR template

---------

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
Emil Ernerfeldt
2026-08-17 21:55:53 -07:00
committed by GitHub
parent 9bb36b0ac2
commit 34b39d564b
12 changed files with 97 additions and 159 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
crates/egui_kittest/src/lib.rs
View File

@@ -247,16 +247,16 @@ impl<'a, State> Harness<'a, State> {
pub fn step(&mut self) {
let events = core::mem::take(&mut *self.queued_events.lock());
if events.is_empty() {
self._step(false);
self.step_impl(false);
}
for event in events {
self.input.events.push(event);
self._step(false);
self.step_impl(false);
}
}
/// Run a single step. This will not process any events.
fn _step(&mut self, sizing_pass: bool) {
fn step_impl(&mut self, sizing_pass: bool) {
self.input.predicted_dt = self.step_dt;
let mut output = self.ctx.run_ui(self.input.take(), |ui| {
@@ -297,7 +297,7 @@ impl<'a, State> Harness<'a, State> {
/// [`Harness::new_ui`] / [`Harness::new_ui_state`] or
/// [`HarnessBuilder::build_ui`] / [`HarnessBuilder::build_ui_state`].
pub fn fit_contents(&mut self) {
self._step(true);
self.step_impl(true);
// Calculate size including all content (main UI + popups + tooltips)
if let Some(rect) = self.compute_total_rect_with_popups() {
@@ -333,7 +333,7 @@ impl<'a, State> Harness<'a, State> {
}
}
fn _try_run(&mut self, sleep: bool) -> Result<u64, ExceededMaxStepsError> {
fn try_run_impl(&mut self, sleep: bool) -> Result<u64, ExceededMaxStepsError> {
let mut steps = 0;
loop {
steps += 1;
@@ -374,7 +374,7 @@ impl<'a, State> Harness<'a, State> {
/// - [`Harness::run_steps`].
/// - [`Harness::try_run_realtime`].
pub fn try_run(&mut self) -> Result<u64, ExceededMaxStepsError> {
self._try_run(false)
self.try_run_impl(false)
}
/// Run until
@@ -414,7 +414,7 @@ impl<'a, State> Harness<'a, State> {
/// - [`Harness::run_steps`].
/// - [`Harness::try_run`].
pub fn try_run_realtime(&mut self) -> Result<u64, ExceededMaxStepsError> {
self._try_run(true)
self.try_run_impl(true)
}
/// Run a number of steps.

20
crates/egui_kittest/src/snapshot.rs
View File

@@ -535,31 +535,31 @@ fn try_image_snapshot_options_impl(
Ok(image) => image.to_rgba8(),
Err(err) => {
// No previous snapshot - probably a new test.
if mode.is_update() {
return update_snapshot();
return if mode.is_update() {
update_snapshot()
} else {
write_new_png()?;
return Err(SnapshotError::OpenSnapshot {
Err(SnapshotError::OpenSnapshot {
path: snapshot_path.clone(),
err,
});
}
})
};
}
};
if previous.dimensions() != new.dimensions() {
if mode.is_update() {
return update_snapshot();
return if mode.is_update() {
update_snapshot()
} else {
write_new_png()?;
return Err(SnapshotError::SizeMismatch {
Err(SnapshotError::SizeMismatch {
name,
expected: previous.dimensions(),
actual: new.dimensions(),
});
}
})
};
}
// Compare existing image to the new one: