From 7b0e45c6b8fe751ffc09e64db1fa7c95a3faef4f Mon Sep 17 00:00:00 2001 From: umajho Date: Thu, 9 Apr 2026 16:25:45 +0800 Subject: [PATCH] Fix(egui): put `paint_ime_preedit_text_visuals` behind `pub(crate)` As its parameter list is not well thought out. --- crates/egui/src/text_selection/visuals.rs | 4 ++-- crates/egui/src/widgets/text_edit/builder.rs | 1 - 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/crates/egui/src/text_selection/visuals.rs b/crates/egui/src/text_selection/visuals.rs index 625299f16..b43325758 100644 --- a/crates/egui/src/text_selection/visuals.rs +++ b/crates/egui/src/text_selection/visuals.rs @@ -130,12 +130,11 @@ pub fn paint_text_selection( } #[expect(clippy::too_many_arguments)] -pub fn paint_ime_preedit_text_visuals( +pub(crate) fn paint_ime_preedit_text_visuals( pos: Pos2, ui: &Ui, painter: &Painter, galley: &Arc, - visuals: &Visuals, row_height: f32, preedit_range: std::ops::Range, relative_active_range: Option>, @@ -145,6 +144,7 @@ pub fn paint_ime_preedit_text_visuals( return; } + let visuals = ui.visuals(); let active_underline_stroke = visuals.ime_preedit.active_underline_stroke; let inactive_underline_stroke = visuals.ime_preedit.inactive_underline_stroke; diff --git a/crates/egui/src/widgets/text_edit/builder.rs b/crates/egui/src/widgets/text_edit/builder.rs index 3c5ea29ad..1f2d86a13 100644 --- a/crates/egui/src/widgets/text_edit/builder.rs +++ b/crates/egui/src/widgets/text_edit/builder.rs @@ -873,7 +873,6 @@ impl TextEdit<'_> { ui, &painter, &galley, - ui.visuals(), row_height, { let [start, end] = cursor_range.sorted_cursors();