migrations/egui
1
0
Fork 0
mirror of https://github.com/emilk/egui.git synced 2026-08-29 04:40:03 -04:00
Code Activity

Inline log format args (#7600)

Browse Source
This commit is contained in:
Emil Ernerfeldt
2025-10-07 16:14:43 +02:00
committed by GitHub
parent ac4e04d0b8
commit 86dc9ea64e
15 changed files with 34 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
crates/egui_glow/src/lib.rs
View File

@@ -88,20 +88,11 @@ pub fn check_for_gl_error_impl(gl: &glow::Context, file: &str, line: u32, contex
if context.is_empty() {
log::error!(
"GL error, at {}:{}: {} (0x{:X}). Please file a bug at https://github.com/emilk/egui/issues",
file,
line,
error_str,
error_code,
"GL error, at {file}:{line}: {error_str} (0x{error_code:X}). Please file a bug at https://github.com/emilk/egui/issues"
);
} else {
log::error!(
"GL error, at {}:{} ({}): {} (0x{:X}). Please file a bug at https://github.com/emilk/egui/issues",
file,
line,
context,
error_str,
error_code,
"GL error, at {file}:{line} ({context}): {error_str} (0x{error_code:X}). Please file a bug at https://github.com/emilk/egui/issues"
);
}
}

4
crates/egui_glow/src/painter.rs
View File

@@ -168,7 +168,7 @@ impl Painter {
let shader_version = shader_version.unwrap_or_else(|| ShaderVersion::get(&gl));
let is_webgl_1 = shader_version == ShaderVersion::Es100;
let shader_version_declaration = shader_version.version_declaration();
log::debug!("Shader header: {:?}.", shader_version_declaration);
log::debug!("Shader header: {shader_version_declaration:?}.");
let supported_extensions = gl.supported_extensions();
log::trace!("OpenGL extensions: {supported_extensions:?}");
@@ -179,7 +179,7 @@ impl Painter {
// {GL,GLX,WGL}_ARB_framebuffer_sRGB, …
extension.ends_with("ARB_framebuffer_sRGB")
});
log::debug!("SRGB framebuffer Support: {:?}", supports_srgb_framebuffer);
log::debug!("SRGB framebuffer Support: {supports_srgb_framebuffer}");
unsafe {
let vert = compile_shader(

6
crates/egui_glow/src/shader_version.rs
View File

@@ -24,11 +24,7 @@ impl ShaderVersion {
let shading_lang_string =
unsafe { gl.get_parameter_string(glow::SHADING_LANGUAGE_VERSION) };
let shader_version = Self::parse(&shading_lang_string);
log::debug!(
"Shader version: {:?} ({:?}).",
shader_version,
shading_lang_string
);
log::debug!("Shader version: {shader_version:?} ({shading_lang_string:?}).");
shader_version
}

8
crates/egui_glow/src/vao.rs
View File

@@ -118,7 +118,7 @@ fn supports_vao(gl: &glow::Context) -> bool {
const OPENGL_ES_PREFIX: &str = "OpenGL ES ";
let version_string = unsafe { gl.get_parameter_string(glow::VERSION) };
log::debug!("GL version: {:?}.", version_string);
log::debug!("GL version: {version_string:?}.");
// Examples:
// * "WebGL 2.0 (OpenGL ES 3.0 Chromium)"
@@ -129,7 +129,7 @@ fn supports_vao(gl: &glow::Context) -> bool {
if version_str.contains("1.0") {
// need to test OES_vertex_array_object .
let supported_extensions = gl.supported_extensions();
log::debug!("Supported OpenGL extensions: {:?}", supported_extensions);
log::debug!("Supported OpenGL extensions: {supported_extensions:?}");
supported_extensions.contains("OES_vertex_array_object")
|| supported_extensions.contains("GL_OES_vertex_array_object")
} else {
@@ -140,7 +140,7 @@ fn supports_vao(gl: &glow::Context) -> bool {
if version_string.contains("2.0") {
// need to test OES_vertex_array_object .
let supported_extensions = gl.supported_extensions();
log::debug!("Supported OpenGL extensions: {:?}", supported_extensions);
log::debug!("Supported OpenGL extensions: {supported_extensions:?}");
supported_extensions.contains("OES_vertex_array_object")
|| supported_extensions.contains("GL_OES_vertex_array_object")
} else {
@@ -152,7 +152,7 @@ fn supports_vao(gl: &glow::Context) -> bool {
// I found APPLE_vertex_array_object , GL_ATI_vertex_array_object ,ARB_vertex_array_object
// but APPLE's and ATI's very old extension.
let supported_extensions = gl.supported_extensions();
log::debug!("Supported OpenGL extensions: {:?}", supported_extensions);
log::debug!("Supported OpenGL extensions: {supported_extensions:?}");
supported_extensions.contains("ARB_vertex_array_object")
|| supported_extensions.contains("GL_ARB_vertex_array_object")
} else {

2
crates/egui_glow/src/winit.rs
View File

@@ -89,7 +89,7 @@ impl EguiGlow {
&mut actions_requested,
);
for action in actions_requested {
log::warn!("{:?} not yet supported by EguiGlow", action);
log::warn!("{action:?} not yet supported by EguiGlow");
}
}