From 8ada641ee2b7df6cf11f2346537a98293664dcb8 Mon Sep 17 00:00:00 2001 From: psyche <180074435+EtherealPsyche@users.noreply.github.com> Date: Sat, 4 Apr 2026 18:28:06 +0800 Subject: [PATCH] perf: remove redundant clone in about.rs demo (#8057) As shown in the commit, this is exactly what it contains. There was a redundant and seemingly meaningless `.clone()` in `about.rs`, which I removed. Was it because the function signature of `Image::new()` was different in older versions of egui? Co-authored-by: EtherealPsyche --- crates/egui_demo_lib/src/demo/about.rs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/crates/egui_demo_lib/src/demo/about.rs b/crates/egui_demo_lib/src/demo/about.rs index 853ebf490..227aff429 100644 --- a/crates/egui_demo_lib/src/demo/about.rs +++ b/crates/egui_demo_lib/src/demo/about.rs @@ -29,9 +29,8 @@ impl crate::View for About { ui.vertical_centered(|ui| { ui.add_space(4.0); - let egui_icon = egui::include_image!("../../data/egui-logo.svg"); ui.add( - egui::Image::new(egui_icon.clone()) + egui::Image::new(egui::include_image!("../../data/egui-logo.svg")) .max_height(30.0) .tint(ui.visuals().strong_text_color()), );