migrations/egui
1
0
Fork 0
mirror of https://github.com/emilk/egui.git synced 2026-06-26 14:49:06 -04:00
Code Activity

Configure wgpu to be low-latency by default (#8203)

Browse Source 
* initially done in https://github.com/emilk/egui/pull/8103, reverted in
#8167 due to resize hangs
* Related: https://github.com/emilk/egui/issues/8043 (maybe closes??)

Turns out the resize hangs were caused by the present_with_transaction
call. Disabling that when `desired_maximum_frame_latency == 1` causes
the window to resize smoothly.

Thanks @krisdigital for noticing that connection:
https://github.com/emilk/egui/issues/8043#issuecomment-4154440382

---------

Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
This commit is contained in:
Lucas Meurer
2026-05-26 15:49:51 +02:00
committed by GitHub
parent fd57895559
commit 8d5a7b4557
2 changed files with 21 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
crates/egui-wgpu/src/lib.rs
View File

@@ -87,13 +87,10 @@ impl SurfaceConfig {
pub const LOW_LATENCY: Self = Self { pub const LOW_LATENCY: Self = Self {
present_mode: wgpu::PresentMode::AutoVsync, present_mode: wgpu::PresentMode::AutoVsync,
#[expect(clippy::branches_sharing_code)]
desired_maximum_frame_latency: if cfg!(target_os = "ios") { desired_maximum_frame_latency: if cfg!(target_os = "ios") {
None // The default is good on iOS, while `Some(1)` cuts FPS in half None // The default is good on iOS, while `Some(1)` cuts FPS in half
} else { } else {
// TODO(emilk): We would like yo use `Some(1)` here, but Some(1)
// that causes bugs when resizing the window on macOS.
None
}, },
}; };

33
crates/egui-wgpu/src/winit.rs
View File

@@ -414,20 +414,27 @@ impl Painter {
// See https://github.com/emilk/egui/issues/903 // See https://github.com/emilk/egui/issues/903
#[cfg(all(target_os = "macos", feature = "macos-window-resize-jitter-fix"))] #[cfg(all(target_os = "macos", feature = "macos-window-resize-jitter-fix"))]
{ {
// SAFETY: The cast is checked with if condition. If the used backend is not metal // setPresentsWithTransaction causes hangs when desired_maximum_frame_latency == 1
// it gracefully fails. let is_low_latency = self
unsafe { .render_state
if let Some(hal_surface) = state.surface.as_hal::<wgpu::hal::api::Metal>() { .as_ref()
hal_surface .is_some_and(|rs| rs.surface_config.desired_maximum_frame_latency == Some(1));
.render_layer() if !is_low_latency {
.lock() // SAFETY: The cast is checked with if condition. If the used backend is not metal
.setPresentsWithTransaction(resizing); // it gracefully fails.
unsafe {
if let Some(hal_surface) = state.surface.as_hal::<wgpu::hal::api::Metal>() {
hal_surface
.render_layer()
.lock()
.setPresentsWithTransaction(resizing);
Self::configure_surface( Self::configure_surface(
state, state,
self.render_state.as_ref().unwrap(), self.render_state.as_ref().unwrap(),
&self.config.surface, &self.config.surface,
); );
}
} }
} }
} }