migrations/egui
1
0
Fork 0
mirror of https://github.com/emilk/egui.git synced 2026-09-02 06:40:06 -04:00
Code Activity

Update resvg dependency of egui_extras (#3719)

Browse Source 
Update `resvg` from v0.28 to v0.37. 
Remove related, unnecessary entries from `deny.toml`.

⚠ In example `images` ferris is scaled differently, but I guess that now
it scales in expected way (takes all available space; before this PR it
takes up to space that, was available at first render- it does not
upscale).

This PR is minimal adaptation to new `resvg` api and small related
simplification, however it should be considered to update loaders
(currently if svg image initially was small and was scaled up it will be
blurred, see https://github.com/emilk/egui/issues/3501). As svg image
now scales over render size, problem will be more often seen now.

(currently `SvgLoader` theoretically should rerender for different sizes
(but I guess it will result in memory leak in that case), but refreshing
is stopped earlier in `DefaultTextureLoader`).

I have initial version of loaders update, that will fix issue with svg
scaling (and also enable e.g. reloading image if file has been changed),
I will submit these changes in separate PR once this one is merged.

Closes <https://github.com/emilk/egui/issues/3652>.
This commit is contained in:
PingPongun
2023-12-20 08:09:03 +01:00
committed by GitHub
parent add1695624
commit 963be247f2
6 changed files with 81 additions and 111 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
crates/egui_extras/Cargo.toml
View File

@@ -92,7 +92,7 @@ syntect = { version = "5", optional = true, default-features = false, features =
] }
# svg feature
resvg = { version = "0.28", optional = true, default-features = false }
resvg = { version = "0.37", optional = true, default-features = false }
# http feature
ehttp = { version = "0.3.1", optional = true, default-features = false }