migrations/egui
1
0
Fork 0
mirror of https://github.com/emilk/egui.git synced 2026-06-26 14:49:06 -04:00
Code Activity

Use explicit Arc::clone to clarify when clones are cheap (#7784)

Browse Source
This commit is contained in:
Emil Ernerfeldt
2025-12-17 17:19:18 +01:00
committed by GitHub
parent 6157a35985
commit 986c2c0ffb
40 changed files with 80 additions and 71 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
tests/test_ui_stack/src/main.rs
View File

@@ -1,6 +1,8 @@
#![cfg_attr(not(debug_assertions), windows_subsystem = "windows")] // hide console window on Windows in release
#![allow(rustdoc::missing_crate_level_docs)] // it's an example
use std::sync::Arc;
use eframe::egui;
use eframe::egui::{Rangef, Shape, UiKind};
use egui_extras::Column;
@@ -158,7 +160,7 @@ impl eframe::App for MyApp {
row.col(|ui| {
ui.style_mut().wrap_mode = Some(egui::TextWrapMode::Extend);
ui.label("See stack below");
cell_stack = Some(ui.stack().clone());
cell_stack = Some(Arc::clone(ui.stack()));
});
});
});
@@ -253,7 +255,7 @@ fn full_span_horizontal_range(ui_stack: &egui::UiStack) -> Rangef {
}
fn stack_ui(ui: &mut egui::Ui) {
let ui_stack = ui.stack().clone();
let ui_stack = Arc::clone(ui.stack());
ui.scope(|ui| {
stack_ui_impl(ui, &ui_stack);
});

4
tests/test_viewports/src/main.rs
View File

@@ -91,7 +91,7 @@ impl ViewportState {
if ui.input(|i| i.viewport().close_requested()) {
vp_state.visible = false;
}
let count = count.clone();
let count = Arc::clone(&count);
show_as_popup(ui, class, move |ui: &mut egui::Ui| {
let current_count = *count.read();
ui.label(format!("Callback has been reused {current_count} times"));
@@ -289,7 +289,7 @@ fn generic_ui(ui: &mut egui::Ui, children: &[Arc<RwLock<ViewportState>>], close_
*visible
};
if visible {
ViewportState::show(child.clone(), &ctx, close_button);
ViewportState::show(Arc::clone(child), &ctx, close_button);
}
}
}