migrations/egui
1
0
Fork 0
mirror of https://github.com/emilk/egui.git synced 2026-08-31 05:40:03 -04:00
Code Activity

Deprecate Memory::popup API in favor of new Popup API (#7317)

Browse Source 
* Closes  #7037
* Closes #7297

This deprecates all popup-related function in `Memory`, replacing them
with the new `egui::Popup`.

The new API is nicer in all ways, so we should encourage people to use
it.
This commit is contained in:
Emil Ernerfeldt
2025-07-09 12:55:06 +02:00
committed by GitHub
parent fbe0aadf63
commit a7f14ca176
6 changed files with 108 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
crates/egui_demo_lib/src/demo/modals.rs
View File

@@ -164,8 +164,8 @@ impl crate::View for Modals {
mod tests {
use crate::Demo as _;
use crate::demo::modals::Modals;
use egui::Key;
use egui::accesskit::Role;
use egui::{Key, Popup};
use egui_kittest::kittest::Queryable as _;
use egui_kittest::{Harness, SnapshotResults};
@@ -187,12 +187,12 @@ mod tests {
// Harness::run would fail because we keep requesting repaints to simulate progress.
harness.run_ok();
assert!(harness.ctx.memory(|mem| mem.any_popup_open()));
assert!(Popup::is_any_open(&harness.ctx));
assert!(harness.state().user_modal_open);
harness.key_press(Key::Escape);
harness.run_ok();
assert!(!harness.ctx.memory(|mem| mem.any_popup_open()));
assert!(!Popup::is_any_open(&harness.ctx));
assert!(harness.state().user_modal_open);
}