From c9345003f0ade15f899fe68d4a3dc953db37b389 Mon Sep 17 00:00:00 2001 From: lucasmerlin Date: Wed, 9 Jul 2025 12:45:09 +0200 Subject: [PATCH] Comment --- crates/eframe/src/native/wgpu_integration.rs | 2 +- crates/egui-winit/src/window_settings.rs | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/crates/eframe/src/native/wgpu_integration.rs b/crates/eframe/src/native/wgpu_integration.rs index d7765dc6c..11fdadf13 100644 --- a/crates/eframe/src/native/wgpu_integration.rs +++ b/crates/eframe/src/native/wgpu_integration.rs @@ -911,7 +911,7 @@ fn create_window( native_options, window_settings, ) - .with_visible(should_start_visible()); // Start hidden until we render the first frame to fix white flash on startup (https://github.com/emilk/egui/pull/3631) + .with_visible(should_start_visible()); let window = egui_winit::create_window(egui_ctx, event_loop, &viewport_builder)?; epi_integration::apply_window_settings(&window, window_settings); diff --git a/crates/egui-winit/src/window_settings.rs b/crates/egui-winit/src/window_settings.rs index 6592a39f8..06962914c 100644 --- a/crates/egui-winit/src/window_settings.rs +++ b/crates/egui-winit/src/window_settings.rs @@ -60,8 +60,9 @@ impl WindowSettings { mut viewport_builder: ViewportBuilder, ) -> ViewportBuilder { profiling::function_scope!(); - // On MacOS with an external monitor, if the window starts fullscreen, - // the top area is not clickable. See https://github.com/rust-windowing/winit/issues/4295 + // On macOS with an external monitor, if the window starts fullscreen, + // the top area is not clickable. So we don't restore settings if this is the case. + // See https://github.com/rust-windowing/winit/issues/4295 let top_area_not_clickable_workaround = cfg!(target_os = "macos") && !cfg!(feature = "accesskit"); if top_area_not_clickable_workaround && self.fullscreen {