migrations/egui
1
0
Fork 0
mirror of https://github.com/emilk/egui.git synced 2026-06-26 22:53:14 -04:00
Code Activity

Enforce writing username in TODO comments (#4235)

Browse Source
This commit is contained in:
Emil Ernerfeldt
2024-03-26 11:48:24 +01:00
committed by GitHub
parent 8a10f81ca0
commit f8d7d0ebaa
19 changed files with 31 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
crates/egui_plot/src/axis.rs
View File

@@ -106,7 +106,7 @@ pub struct AxisHints {
pub(super) label_spacing: Rangef,
}
// TODO: this just a guess. It might cease to work if a user changes font size.
// TODO(JohannesProgrammiert): this just a guess. It might cease to work if a user changes font size.
const LINE_HEIGHT: f32 = 12.0;
impl AxisHints {
@@ -366,7 +366,7 @@ impl AxisWidget {
match HPlacement::from(self.hints.placement) {
HPlacement::Left => {
let angle = 0.0; // TODO: allow users to rotate text
let angle = 0.0; // TODO(emilk): allow users to rotate text
if angle == 0.0 {
let x = self.rect.max.x - galley.size().x;

2
crates/egui_plot/src/items/values.rs
View File

@@ -156,7 +156,7 @@ impl Default for Orientation {
pub enum PlotPoints {
Owned(Vec<PlotPoint>),
Generator(ExplicitGenerator),
// Borrowed(&[PlotPoint]), // TODO: Lifetimes are tricky in this case.
// Borrowed(&[PlotPoint]), // TODO(EmbersArc): Lifetimes are tricky in this case.
}
impl Default for PlotPoints {

2
crates/egui_plot/src/lib.rs
View File

@@ -800,7 +800,7 @@ impl Plot {
let plot_id = id.unwrap_or_else(|| ui.make_persistent_id(id_source));
let ([x_axis_widgets, y_axis_widgets], plot_rect) = axis_widgets(
PlotMemory::load(ui.ctx(), plot_id).as_ref(), // TODO: avoid loading plot memory twice
PlotMemory::load(ui.ctx(), plot_id).as_ref(), // TODO(emilk): avoid loading plot memory twice
show_axes,
complete_rect,
[&x_axes, &y_axes],