migrations/egui
1
0
Fork 0
mirror of https://github.com/emilk/egui.git synced 2026-08-31 22:00:03 -04:00
Code Activity

egui_kittest: Close debug_open_snapshot temp file before viewing it (#7841)

Browse Source 
The image file written by debug_open_snapshot was being kept open by the
`tempfile` object. On Windows, this prevented `open::that` from
successfully launching the viewer sometimes because the file remained
locked, which can be avoided by first releasing the file handle.
This commit is contained in:
Yuri Kunde Schlesner
2026-01-19 10:47:10 -03:00
committed by GitHub
parent 83e61c6fb0
commit fa78d25564
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
crates/egui_kittest/src/snapshot.rs
View File

@@ -721,11 +721,14 @@ impl<State> Harness<'_, State> {
}) })
.unwrap(); .unwrap();
// Close temp file so it isn't locked when `open` tries to launch it (on Windows)
let path = temp_file.into_temp_path();
#[expect(clippy::print_stdout)] #[expect(clippy::print_stdout)]
{ {
println!("Wrote debug snapshot to: {}", path.display()); println!("Wrote debug snapshot to: {}", path.display());
} }
let result = open::that(path); let result = open::that(&path);
if let Err(err) = result { if let Err(err) = result {
#[expect(clippy::print_stderr)] #[expect(clippy::print_stderr)]
{ {