From fd54387eac03f57ca772a8fb590ceaadf780f31c Mon Sep 17 00:00:00 2001
From: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
Date: Thu, 20 Aug 2026 01:42:12 -0700
Subject: [PATCH] Clean up clippy lint config (#8437)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* [x] I have followed the instructions in the PR template

Remove clippy lint groups already covered by `all` (`complexity`,
`perf`, `suspicious`, and the misspelled `correctnesss`), and two
individual lints covered by the `cargo` group (`negative_feature_names`,
`wildcard_dependencies`).

Add `publish = false` to the two internal crates that were missing it
(`popups`, `egui_tests`), which silences the
`clippy::cargo_common_metadata` warnings.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
---
 Cargo.toml                  | 9 ++++++---
 examples/popups/Cargo.toml  | 1 +
 tests/egui_tests/Cargo.toml | 1 +
 3 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/Cargo.toml b/Cargo.toml
index b6534d2d1..3aae7fa74 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -179,7 +179,11 @@ all = "warn"
 
 # See also clippy.toml
 [workspace.lints.clippy]
+# `all` = `correctness` + `suspicious` + `style` + `complexity` + `perf`.
+# The remaining groups are `nursery` and `restriction`,
+# which are not meant to be enabled wholesale - we cherry-pick from them below.
 all = { level = "warn", priority = -1 }
+cargo = { level = "warn", priority = -1 }
 pedantic = { level = "warn", priority = -1 }
 
 allow_attributes = "warn"
@@ -216,7 +220,6 @@ missing_assert_message = "warn"
 mutex_integer = "warn"
 needless_pass_by_ref_mut = "warn"
 needless_type_cast = "warn"
-negative_feature_names = "warn"
 non_zero_suggestions = "warn"
 nonstandard_macro_braces = "warn"
 or_fun_call = "warn"
@@ -258,7 +261,6 @@ unwrap_used = "warn"
 use_self = "warn"
 useless_let_if_seq = "warn"
 verbose_file_reads = "warn"
-wildcard_dependencies = "warn"
 
 
 # Pedantic lints we opt out of, with the number of hits at the time we enabled `pedantic`:
@@ -286,10 +288,11 @@ trivially_copy_pass_by_ref = "allow" # 119 hits
 unreadable_literal = "allow" # 513 hits
 used_underscore_binding = "allow" # 25 hits
 
-# These are meh:
+# Other:
 assigning_clones = "allow" # No please
 manual_range_contains = "allow" # this one is just worse imho
 map_unwrap_or = "allow" # so is this one
+multiple_crate_versions = "allow" # we handle this with `cargo deny`
 wildcard_imports = "allow" # `use crate::*` is useful to avoid merge conflicts when adding/removing imports
 
 # NOTE: these are in `restriction`/`nursery`, so the `allow` is a no-op today.
diff --git a/examples/popups/Cargo.toml b/examples/popups/Cargo.toml
index d1f199918..c0d4384c7 100644
--- a/examples/popups/Cargo.toml
+++ b/examples/popups/Cargo.toml
@@ -2,6 +2,7 @@
 name = "popups"
 edition.workspace = true
 license.workspace = true
+publish = false
 rust-version.workspace = true
 version.workspace = true
 
diff --git a/tests/egui_tests/Cargo.toml b/tests/egui_tests/Cargo.toml
index 44a7b9c8f..89d6a9fda 100644
--- a/tests/egui_tests/Cargo.toml
+++ b/tests/egui_tests/Cargo.toml
@@ -2,6 +2,7 @@
 name = "egui_tests"
 edition.workspace = true
 license.workspace = true
+publish = false
 rust-version.workspace = true
 version.workspace = true