mirror of
https://github.com/emilk/egui.git
synced 2026-06-26 22:53:14 -04:00
e505d98215
<!-- Please read the "Making a PR" section of [`CONTRIBUTING.md`](https://github.com/emilk/egui/blob/main/CONTRIBUTING.md) before opening a Pull Request! * Keep your PR:s small and focused. * The PR title is what ends up in the changelog, so make it descriptive! * If applicable, add a screenshot or gif. * If it is a non-trivial addition, consider adding a demo for it to `egui_demo_lib`, or a new example. * Do NOT open PR:s from your `master` branch, as that makes it hard for maintainers to test and add commits to your PR. * Remember to run `cargo fmt` and `cargo clippy`. * Open the PR as a draft until you have self-reviewed it and run `./scripts/check.sh`. * When you have addressed a PR comment, mark it as resolved. Please be patient! I will review your PR, but my time is limited! --> * [x] I have followed the instructions in the PR template `get_proc_address` was introduced in #4145, but its lifetime was designed to be tied to the lifetime `'s` of `CreationContext`. This means that using `get_proc_address` outside the lifetime of `CreationContext` is undefined behavior. This contradicts the original intent behind introducing `get_proc_address`, as this API is intended for integration with external libraries that cannot easily guarantee alignment with egui's lifetimes. This PR changes the type of `get_proc_address` from a reference to an `Arc`, decoupling its lifetime from `CreationContext` to achieve safer memory management.