From 55f60a35b126f09b31e74a0b5dee99fcadeef2a6 Mon Sep 17 00:00:00 2001 From: Mads Marquart Date: Thu, 24 Aug 2023 22:52:11 +0200 Subject: [PATCH] Use `frame` instead of `visibleRect` (#3043) --- CHANGELOG.md | 2 ++ src/platform_impl/macos/appkit/view.rs | 3 --- src/platform_impl/macos/view.rs | 4 ++-- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 61a2f5fd2..bc99dc3da 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,8 @@ And please only add new entries to the top of this list, right below the `# Unre # Unreleased +- Fix window size sometimes being invalid when resizing on macOS 14 Sonoma. + # 0.28.6 - On macOS, fixed memory leak when getting monitor handle. diff --git a/src/platform_impl/macos/appkit/view.rs b/src/platform_impl/macos/appkit/view.rs index b72b712df..be52be28b 100644 --- a/src/platform_impl/macos/appkit/view.rs +++ b/src/platform_impl/macos/appkit/view.rs @@ -44,9 +44,6 @@ extern_methods!( unsafe { msg_send_id![self, inputContext] } } - #[sel(visibleRect)] - pub fn visibleRect(&self) -> NSRect; - #[sel(hasMarkedText)] pub fn hasMarkedText(&self) -> bool; diff --git a/src/platform_impl/macos/view.rs b/src/platform_impl/macos/view.rs index cacbf10e8..77781877b 100644 --- a/src/platform_impl/macos/view.rs +++ b/src/platform_impl/macos/view.rs @@ -209,7 +209,7 @@ declare_class!( self.removeTrackingRect(tracking_rect); } - let rect = self.visibleRect(); + let rect = self.frame(); let tracking_rect = self.add_tracking_rect(rect, false); self.state.tracking_rect = Some(tracking_rect); } @@ -221,7 +221,7 @@ declare_class!( self.removeTrackingRect(tracking_rect); } - let rect = self.visibleRect(); + let rect = self.frame(); let tracking_rect = self.add_tracking_rect(rect, false); self.state.tracking_rect = Some(tracking_rect);