migrations/winit
1
0
Fork 0
mirror of https://github.com/rust-windowing/winit.git synced 2026-08-29 04:40:04 -04:00
Code Issues Packages Projects Releases Wiki Activity

Web: fix crash with ControlFlow::Wait|WaitUntil

Browse Source
This commit is contained in:
daxpedda
2024-03-02 12:15:01 +01:00
parent 1c5fcf3309
commit 8d66df7f6f
2 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
CHANGELOG.md
View File

@@ -9,7 +9,9 @@ PR's changelog entry would go into the wrong section).
And please only add new entries to the top of this list, right below the `# And please only add new entries to the top of this list, right below the `#
Unreleased` header. Unreleased` header.
# Unreleased # 0.29.13
- On Web, fix possible crash with `ControlFlow::Wait` and `ControlFlow::WaitUntil`.
# 0.29.12 # 0.29.12

5
src/platform_impl/web/web_sys/schedule.rs
View File

@@ -117,9 +117,7 @@ impl Schedule {
let channel = MessageChannel::new().unwrap(); let channel = MessageChannel::new().unwrap();
let closure = Closure::new(f); let closure = Closure::new(f);
let port_1 = channel.port1(); let port_1 = channel.port1();
port_1 port_1.set_onmessage(Some(closure.as_ref().unchecked_ref()));
.add_event_listener_with_callback("message", closure.as_ref().unchecked_ref())
.expect("Failed to set message handler");
port_1.start(); port_1.start();
let port_2 = channel.port2(); let port_2 = channel.port2();
@@ -178,6 +176,7 @@ impl Drop for Schedule {
} => { } => {
window.clear_timeout_with_handle(*handle); window.clear_timeout_with_handle(*handle);
port.close(); port.close();
port.set_onmessage(None);
} }
} }
} }