Run clippy on all targets and all features (#347)

* Run clippy on all targets and all features

* check.sh: print each step

* impl ToString -related clippy fix

.github/workflows/rust.yml

@@ -119,7 +119,7 @@ jobs:
       - uses: actions-rs/cargo@v1
         with:
           command: clippy
-          args: -- -D warnings
+          args: --workspace --all-targets --all-features --  -D warnings -W clippy::all
 
   doc:
     name: cargo doc

check.sh

@@ -1,5 +1,5 @@
 #!/bin/bash
-set -eu
+set -eux
 
 # Checks all tests, lints etc.
 # Basically does what the CI does.

epi/src/lib.rs

@@ -340,6 +340,7 @@ pub mod http {
 
     impl Request {
         /// Create a `GET` requests with the given url.
+        #[allow(clippy::needless_pass_by_value)]
         pub fn get(url: impl ToString) -> Self {
             Self {
                 method: "GET".to_owned(),
@@ -349,6 +350,7 @@ pub mod http {
         }
 
         /// Create a `POST` requests with the give url and body.
+        #[allow(clippy::needless_pass_by_value)]
         pub fn post(url: impl ToString, body: impl ToString) -> Self {
             Self {
                 method: "POST".to_owned(),