migrations/egui
1
0
Fork 0
mirror of https://github.com/emilk/egui.git synced 2026-08-29 04:40:03 -04:00
Code Activity

Rect::intersects_ray: another bug fix (#4597)

Browse Source 
Make sure it returns `true` if the ray starts inside the box
This commit is contained in:
Emil Ernerfeldt
2024-05-31 17:28:38 +02:00
committed by GitHub
parent b6805a8006
commit 78dfdb3684
1 changed files with 26 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
crates/emath/src/rect.rs
View File

@@ -608,6 +608,8 @@ impl Rect {
impl Rect {
/// Does this Rect intersect the given ray (where `d` is normalized)?
///
/// A ray that starts inside the rect will return `true`.
pub fn intersects_ray(&self, o: Pos2, d: Vec2) -> bool {
let mut tmin = -f32::INFINITY;
let mut tmax = f32::INFINITY;
@@ -628,7 +630,7 @@ impl Rect {
tmax = tmax.min(ty1.max(ty2));
}
0.0 <= tmin && tmin <= tmax
0.0 <= tmax && tmin <= tmax
}
}
@@ -710,4 +712,27 @@ mod tests {
assert_eq!(r.distance_sq_to_pos(pos2(15.0, 25.0)), 25.0); // below
assert_eq!(r.distance_sq_to_pos(pos2(25.0, 5.0)), 50.0); // right and above
}
#[test]
fn test_ray_intersection() {
let rect = Rect::from_min_max(pos2(1.0, 1.0), pos2(3.0, 3.0));
eprintln!("Righward ray from left:");
assert!(rect.intersects_ray(pos2(0.0, 2.0), Vec2::RIGHT));
eprintln!("Righward ray from center:");
assert!(rect.intersects_ray(pos2(2.0, 2.0), Vec2::RIGHT));
eprintln!("Righward ray from right:");
assert!(!rect.intersects_ray(pos2(4.0, 2.0), Vec2::RIGHT));
eprintln!("Leftward ray from left:");
assert!(!rect.intersects_ray(pos2(0.0, 2.0), Vec2::LEFT));
eprintln!("Leftward ray from center:");
assert!(rect.intersects_ray(pos2(2.0, 2.0), Vec2::LEFT));
eprintln!("Leftward ray from right:");
assert!(rect.intersects_ray(pos2(4.0, 2.0), Vec2::LEFT));
}
}