Jochen Görtler 2dbfe3a083 Enable or_fun_call lint to avoid unnecessary allocations (#7754) ...

### What

From the [lint
description](https://rust-lang.github.io/rust-clippy/master/index.html?search=or_fu#or_fun_call):

> The function will always be called. This is only bad if it allocates
or does some non-trivial amount of work.

But also:

> If the function has side-effects, not calling it will change the
semantic of the program, but you shouldn’t rely on that.
> 
> The lint also cannot figure out whether the function you call is
actually expensive to call or not.

Still worth it to keep our happy paths clean, imo.

2025-12-05 10:46:34 +01:00

7.6 KiB

Raw Blame History

View Raw