Rename window example to full, to signify that it's a large example

It is more clear what's happening when you don't have to jump to the bottom of the file to look at the implementation.

.cargo/config.toml

@@ -1,9 +1,2 @@
 [alias]
 run-wasm = ["run", "--release", "--package", "run-wasm", "--"]
-
-# Allow rust-analyzer and local `cargo doc` invocations to pick up unreleased changelog entries
-#
-# Note that these flags are (intentionally) not included when building from the downloaded crate.
-[build]
-rustflags = ["--cfg=unreleased_changelogs"]
-rustdocflags = ["--cfg=unreleased_changelogs"]

.github/CODEOWNERS

@@ -32,6 +32,3 @@
 # Orbital (Redox OS)
 /src/platform/orbital.rs            @jackpot51
 /src/platform_impl/orbital          @jackpot51
-
-# Integration tests
-/it                                 @notgull

.github/ISSUE_TEMPLATE/blank_issue.md

@@ -1,4 +0,0 @@
----
-name: Blank Issue
-about: Create a blank issue.
----

.github/ISSUE_TEMPLATE/bug_android.yml

@@ -1,36 +0,0 @@
-name: Android bug
-description: Create an Android-specific bug report
-labels:
-  - B - bug
-  - DS - android
-body:
-  - type: markdown
-    attributes:
-      value: |
-        Thanks for taking the time to fill out this bug report!
-  - type: textarea
-    id: description
-    attributes:
-      label: Description
-      description: Description of the problem you're having
-    validations:
-      required: true
-  - type: textarea
-    id: device
-    attributes:
-      label: Device and Android version
-      description: Which devices and Android versions are you seeing the problem on?
-      placeholder: |
-        Samsung Galaxy Z running Android Pie (API level 28),
-        Samsung Galaxy Z running Android 14 (API level 34),
-        Pixel 8 running Android 14 (API level 34)
-    validations:
-      required: true
-  - type: textarea
-    id: winit-version
-    attributes:
-      label: Winit version
-      description: What version of Winit are you using?
-      placeholder: 0.29.11
-    validations:
-      required: true

.github/ISSUE_TEMPLATE/bug_ios.yml

@@ -1,37 +0,0 @@
-name: iOS bug
-description: Create an iOS-specific bug report
-labels:
-  - B - bug
-  - DS - ios
-body:
-  - type: markdown
-    attributes:
-      value: |
-        Thanks for taking the time to fill out this bug report!
-  - type: textarea
-    id: description
-    attributes:
-      label: Description
-      description: Description of the problem you're having
-    validations:
-      required: true
-  - type: textarea
-    id: device
-    attributes:
-      label: Device and iOS version
-      description: Which devices and iOS versions are you seeing the problem on?
-      placeholder: |
-        iPhone 15 running iOS 14.0,
-        iPhone 15 running iOS 17.0,
-        MacBook Pro M2 Mac Catalyst running macOS 14.2,
-        iPhone simulator running iOS 17.0
-    validations:
-      required: true
-  - type: textarea
-    id: winit-version
-    attributes:
-      label: Winit version
-      description: What version of Winit are you using?
-      placeholder: 0.29.11
-    validations:
-      required: true

.github/ISSUE_TEMPLATE/bug_macos.yml

@@ -1,37 +0,0 @@
-name: MacOS bug
-description: Create a macOS-specific bug report
-labels:
-  - B - bug
-  - DS - macos
-body:
-  - type: markdown
-    attributes:
-      value: |
-        Thanks for taking the time to fill out this bug report!
-  - type: textarea
-    id: description
-    attributes:
-      label: Description
-      description: Description of the problem you're having
-    validations:
-      required: true
-  - type: textarea
-    id: os-version
-    attributes:
-      label: macOS version
-      description: What version of macOS are you using? Please paste in the output of `sw_vers`.
-      placeholder: |
-        ProductName:            macOS
-        ProductVersion:         14.2.1
-        BuildVersion:           23C71
-      render: shell
-    validations:
-      required: true
-  - type: textarea
-    id: winit-version
-    attributes:
-      label: Winit version
-      description: What version of Winit are you using?
-      placeholder: 0.29.11
-    validations:
-      required: true

.github/ISSUE_TEMPLATE/bug_wayland.yml

@@ -1,41 +0,0 @@
-name: Wayland bug
-description: Create a Wayland-specific bug report
-labels:
-  - B - bug
-  - DS - wayland
-body:
-  - type: markdown
-    attributes:
-      value: |
-        Thanks for taking the time to fill out this bug report!
-  - type: textarea
-    id: description
-    attributes:
-      label: Description
-      description: Description of the problem you're having
-    validations:
-      required: true
-  - type: textarea
-    id: debug
-    attributes:
-      label: Debugging output
-      description: Output of a binary run with `WAYLAND_DEBUG=1`
-      placeholder: |
-        [1234.5678]  -> wl_display@1.get_registry(new id wl_registry@2)
-        [1234.5678]  -> wl_display@1.sync(new id wl_callback@3)
-        ...
-      render: shell
-  - type: checkboxes
-    attributes:
-      label: Window isn't shown unless you draw
-      options:
-        - label: I understand that windows aren't shown on Wayland unless I draw and present to them.
-          required: true
-  - type: textarea
-    id: winit-version
-    attributes:
-      label: Winit version
-      description: What version of Winit are you using?
-      placeholder: 0.29.11
-    validations:
-      required: true

.github/ISSUE_TEMPLATE/bug_web.yml

@@ -1,51 +0,0 @@
-name: Web bug
-description: Create a web-specific bug report
-labels:
-  - B - bug
-  - DS - web
-body:
-  - type: markdown
-    attributes:
-      value: |
-        Thanks for taking the time to fill out this bug report!
-  - type: textarea
-    id: description
-    attributes:
-      label: Description
-      description: Description of the problem you're having
-    validations:
-      required: true
-  - type: dropdown
-    id: browsers
-    attributes:
-      label: Tested browsers
-      description: What browsers are you seeing the problem on?
-      options:
-        - Firefox
-        - Chrome
-        - Microsoft Edge
-        - Safari 13
-        - Safari 14
-        - Safari 15
-        - Safari 16
-        - Safari 17
-        - Safari (newer than listed)
-      multiple: true
-    validations:
-      required: true
-  - type: textarea
-    id: device
-    attributes:
-      label: Tested devices
-      description: Which device(s) are you using?
-      placeholder: 'iPhone 15, Lenovo ThinkPad X1, MacBook Pro M2, Samsung Galaxy Z, ...'
-    validations:
-      required: true
-  - type: textarea
-    id: winit-version
-    attributes:
-      label: Winit version
-      description: What version of Winit are you using?
-      placeholder: 0.29.11
-    validations:
-      required: true

.github/ISSUE_TEMPLATE/bug_windows.yml

@@ -1,35 +0,0 @@
-name: Windows bug
-description: Create a Windows-specific bug report
-labels:
-  - B - bug
-  - DS - windows
-body:
-  - type: markdown
-    attributes:
-      value: |
-        Thanks for taking the time to fill out this bug report!
-  - type: textarea
-    id: description
-    attributes:
-      label: Description
-      description: Description of the problem you're having
-    validations:
-      required: true
-  - type: textarea
-    id: os-version
-    attributes:
-      label: Windows version
-      description: What version of Windows are you using? Please paste in the output of the `ver` command.
-      placeholder: |
-        Microsoft Windows [Version 10.0.19042.2251]
-      render: shell
-    validations:
-      required: true
-  - type: textarea
-    id: winit-version
-    attributes:
-      label: Winit version
-      description: What version of Winit are you using?
-      placeholder: 0.29.11
-    validations:
-      required: true

.github/ISSUE_TEMPLATE/bug_x11.yml

@@ -1,32 +0,0 @@
-name: X11 bug
-description: Create a X11-specific bug report
-labels:
-  - B - bug
-  - DS - x11
-body:
-  - type: markdown
-    attributes:
-      value: |
-        Thanks for taking the time to fill out this bug report!
-  - type: textarea
-    id: description
-    attributes:
-      label: Description
-      description: Description of the problem you're having
-    validations:
-      required: true
-  - type: textarea
-    id: os-info
-    attributes:
-      label: OS and window mananger
-      description: Which operating system and window manager are you using?
-    validations:
-      required: true
-  - type: textarea
-    id: winit-version
-    attributes:
-      label: Winit version
-      description: What version of Winit are you using?
-      placeholder: 0.29.11
-    validations:
-      required: true

.github/ISSUE_TEMPLATE/config.yml

@@ -1,5 +0,0 @@
-blank_issues_enabled: true
-contact_links:
-  - name: Question
-    url: https://matrix.to/#/#rust-windowing:matrix.org
-    about: Please ask questions on the Matrix channel.

.github/ISSUE_TEMPLATE/feature_request.yml

@@ -1,26 +0,0 @@
-name: Feature request
-description: Propose a new feature
-labels:
-  - S - enhancement
-body:
-  - type: textarea
-    id: description
-    attributes:
-      label: Description
-      description: Description of the problem does this solve or what need does it fill? Please be mindful of the [scope](https://github.com/rust-windowing/winit/blob/master/FEATURES.md) of Winit.
-    validations:
-      required: true
-  - type: dropdown
-    id: platforms
-    attributes:
-      label: Relevant platforms
-      description: On which platforms is this feature relevant?
-      options:
-        - Windows
-        - macOS
-        - Wayland
-        - X11
-        - Web
-        - iOS
-        - Android
-      multiple: true

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,5 +1,5 @@
 - [ ] Tested on all platforms changed
-- [ ] Added an entry to the `changelog` module if knowledge of this change could be valuable to users
+- [ ] Added an entry to `CHANGELOG.md` if knowledge of this change could be valuable to users
 - [ ] Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
 - [ ] Created or updated an example program if it would help users understand this functionality
 - [ ] Updated [feature matrix](https://github.com/rust-windowing/winit/blob/master/FEATURES.md), if new features were added or implemented

.github/workflows/ci.yml

@@ -17,24 +17,6 @@ jobs:
     - name: Check Formatting
       run: cargo fmt -- --check
 
-  typos:
-    name: Check for typos
-    runs-on: ubuntu-latest
-    timeout-minutes: 30
-    steps:
-      - uses: actions/checkout@v4
-      - uses: taiki-e/install-action@v2
-        with:
-          tool: typos-cli
-      - name: run typos
-        run: typos
-      - name: Typos info
-        if: failure()
-        run: |
-          echo 'To fix typos, please run `typos -w`'
-          echo 'To check for a diff, run `typos`'
-          echo 'You can find typos here: https://crates.io/crates/typos'
-
   tests:
     name: Test ${{ matrix.toolchain }} ${{ matrix.platform.name }}
     runs-on: ${{ matrix.platform.os }}
@@ -145,13 +127,6 @@ jobs:
     - name: Build crate
       run: cargo $CMD build $OPTIONS
 
-    # Test only on Linux x86_64, so we avoid spending unnecessary CI hours.
-    - name: Test dpi crate
-      if: >
-        contains(matrix.platform.name, 'Linux 64bit') &&
-        matrix.toolchain != '1.70.0'
-      run: cargo test -p dpi
-
     - name: Build tests
       if: >
         !contains(matrix.platform.target, 'redox') &&
@@ -190,7 +165,7 @@ jobs:
       if: matrix.toolchain == 'nightly'
       run: cargo doc --no-deps $OPTIONS --features=rwh_04,rwh_05,rwh_06,serde,mint,android-native-activity
       env:
-        RUSTDOCFLAGS: '--deny=warnings ${{ matrix.platform.rustflags }} --cfg=docsrs --cfg=unreleased_changelogs'
+        RUSTDOCFLAGS: '--deny=warnings ${{ matrix.platform.rustflags }} --cfg=docsrs'
 
     # See restore step above
     - name: Save cache of cargo folder
@@ -202,41 +177,6 @@ jobs:
           ~/.cargo/git/db/
         key: cargo-${{ matrix.toolchain }}-${{ matrix.platform.name }}-${{ hashFiles('Cargo.lock') }}
 
-  it:
-    name: Run integration tests on ${{ matrix.platform.name }}
-    runs-on: ${{ matrix.platform.os }}
-
-    strategy:
-      fail-fast: false
-      matrix:
-        toolchain: [stable, nightly]
-        platform:
-          # Note: Make sure that we test all the `docs.rs` targets defined in Cargo.toml!
-          - { name: 'X11',                target: x86_64-unknown-linux-gnu, os: ubuntu-latest, options: '--no-default-features --features=x11' }
-
-    env:
-      # Set more verbose terminal output
-      CARGO_TERM_VERBOSE: true
-      RUST_BACKTRACE: 1
-
-      # Faster compilation and error on warnings
-      RUSTFLAGS: '--codegen=debuginfo=0 --deny=warnings ${{ matrix.platform.rustflags }}'
-
-      OPTIONS: --target=${{ matrix.platform.target }} ${{ matrix.platform.options }}
-
-    steps:
-    - uses: actions/checkout@v3
-    - uses: dtolnay/rust-toolchain@master
-      with:
-        toolchain: ${{ matrix.toolchain }}
-
-    - name: Log into GHCR
-      run: |
-        echo "${{ secrets.GITHUB_TOKEN }}" | docker login ghcr.io -u "${{ github.actor }}" --password-stdin
-
-    - name: Common tests
-      run: cargo run -p gui-test-runner -- common-tests ${{ matrix.platform.target }}
-
   cargo-deny:
     name: Run cargo-deny on ${{ matrix.platform.name }}
     runs-on: ubuntu-latest

.github/workflows/docs.yml

@@ -27,7 +27,7 @@ jobs:
 
       - name: Run Rustdoc
         env:
-          RUSTDOCFLAGS: --crate-version master --cfg=docsrs --cfg=unreleased_changelogs
+          RUSTDOCFLAGS: --crate-version master --cfg=docsrs
         run: |
           cargo doc --no-deps -Z rustdoc-map -Z rustdoc-scrape-examples --features=rwh_04,rwh_05,rwh_06,serde,mint,android-native-activity
 

CODE_OF_CONDUCT.md

@@ -1,6 +0,0 @@
-# Code of Conduct
-
-The `rust-windowing` project adheres to the [Rust Code of Conduct]. This
-describes the minimum behavior expected from all contributors.
-
-[Rust Code of Conduct]: https://www.rust-lang.org/policies/code-of-conduct

CONTRIBUTING.md

@@ -26,7 +26,7 @@ When making a code contribution to winit, before opening your pull request, plea
 - you updated any relevant documentation in winit
 - you left comments in your code explaining any part that is not straightforward, so that the
   maintainers and future contributors don't have to try to guess what your code is supposed to do
-- your PR adds an entry to the current changelog if the introduced change is relevant to winit users.
+- your PR adds an entry to the changelog file if the introduced change is relevant to winit users.
 
   You needn't worry about the added entry causing conflicts, the maintainer that merges the PR will
   handle those for you when merging (see below).
@@ -38,8 +38,8 @@ Once your PR is open, you can ask for a review by a maintainer of your platform.
 is that a PR must be approved by at least two maintainers of winit before being merged, including
 at least a maintainer of the platform (a maintainer making a PR themselves counts as approving it).
 
-Once your PR is deemed ready, the merging maintainer will take care of resolving conflicts in the
+Once your PR is deemed ready, the merging maintainer will take care of resolving conflicts in
-`changelog` module (but you must resolve other conflicts yourself). Doing this requires that you check the
+`CHANGELOG.md` (but you must resolve other conflicts yourself). Doing this requires that you check the
 "give contributors write access to the branch" checkbox when creating the PR.
 
 ## Maintainers
@@ -51,22 +51,19 @@ The current maintainers for each platform are listed in the [CODEOWNERS](.github
 Given that winit is a widely used library, we should be able to make a patch
 releases at any time we want without blocking the development of new features.
 
-To achieve these goals, a new branch is created for every new release. Releases
+To achieve these goals, a new branch is created for every new release. Releases and later patch releases are committed and tagged in this branch.
-and later patch releases are committed and tagged in this branch.
 
 The exact steps for an exemplary `0.2.0` release might look like this:
   1. Initially, the version on the latest master is `0.1.0`
   2. A new `v0.2.x` branch is created for the release
-  3. Update released `cfg_attr` in `src/changelog/mod.rs` to `v0.2.md`
+  3. In the branch, the version is bumped to `v0.2.0`
-  4. Move entries from `src/changelog/unreleased.md` into `src/changelog/v0.2.md`
+  4. The new commit in the branch is tagged `v0.2.0`
-  5. In the branch, the version is bumped to `v0.2.0`
+  5. The version is pushed to crates.io
-  6. The new commit in the branch is tagged `v0.2.0`
+  6. A GitHub release is created for the `v0.2.0` tag
-  7. The version is pushed to crates.io
+  7. On master, the version is bumped to `0.2.0`, and the CHANGELOG is updated
-  8. A GitHub release is created for the `v0.2.0` tag
-  9. On master, the version is bumped to `0.2.0`, and the changelog is updated
 
 When doing a patch release, the process is similar:
   1. Initially, the version of the latest release is `0.2.0`
   2. Checkout the `v0.2.x` branch
   3. Cherry-pick the required non-breaking changes into the `v0.2.x`
-  4. Follow steps 4-9 of the regular release example
+  4. Follow steps 3-7 of the regular release example

Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "winit"
-version = "0.29.15"
+version = "0.29.11"
 authors = ["The winit contributors", "Pierre Krieger <pierre.krieger1708@gmail.com>"]
 description = "Cross-platform window creation library."
 keywords = ["windowing"]
@@ -64,18 +64,17 @@ cfg_aliases = "0.2.0"
 [dependencies]
 bitflags = "2"
 cursor-icon = "1.1.0"
-dpi = { version = "0.1.1", path = "dpi" }
+log = "0.4"
 rwh_04 = { package = "raw-window-handle", version = "0.4", optional = true }
 rwh_05 = { package = "raw-window-handle", version = "0.5.2", features = ["std"], optional = true }
 rwh_06 = { package = "raw-window-handle", version = "0.6", features = ["std"], optional = true }
 serde = { workspace = true, optional = true }
 smol_str = "0.2.0"
-tracing = { version = "0.1.40", default_features = false }
+dpi = { path = "dpi" }
 
 [dev-dependencies]
 image = { version = "0.24.0", default-features = false, features = ["png"] }
-tracing = { version = "0.1.40", default_features = false, features = ["log"] }
+simple_logger = { version = "4.2.0", default_features = false }
-tracing-subscriber = { version = "0.3.18", features = ["env-filter"] }
 winit = { path = ".", features = ["rwh_05"] }
 
 [target.'cfg(not(any(target_os = "android", target_os = "ios")))'.dev-dependencies]
@@ -188,7 +187,7 @@ wayland-backend = { version = "0.3.0", default_features = false, features = ["cl
 wayland-client = { version = "0.31.1", optional = true }
 wayland-protocols = { version = "0.31.0", features = [ "staging"], optional = true }
 wayland-protocols-plasma = { version = "0.2.0", features = [ "client" ], optional = true }
-x11-dl = { version = "2.19.1", optional = true }
+x11-dl = { version = "2.18.5", optional = true }
 x11rb = { version = "0.13.0", default-features = false, features = ["allow-unsafe-code", "dl-libxcb", "randr", "resource_manager", "xinput", "xkb"], optional = true }
 xkbcommon-dl = "0.4.2"
 
@@ -258,15 +257,12 @@ web-sys = { version = "0.3.22", features = ['CanvasRenderingContext2d'] }
 
 [[example]]
 doc-scrape-examples = true
-name = "window"
+name = "full"
 
 [workspace]
 resolver = "2"
 members = [
     "dpi",
-    "it/common-tests",
-    "it/gui-test",
-    "it/gui-test-runner",
     "run-wasm",
 ]
 
@@ -277,9 +273,5 @@ license = "Apache-2.0"
 edition = "2021"
 
 [workspace.dependencies]
-async-io = "2.3.1"
-gui-test = { path = "it/gui-test" }
-mint = "0.5.6"
 serde = { version = "1", features = ["serde_derive"] }
-serde_json = "1.0.114"
+mint = "0.5.6"
-winit = { path = "." }

README.md

@@ -8,7 +8,7 @@
 
 ```toml
 [dependencies]
-winit = "0.29.15"
+winit = "0.29.11"
 ```
 
 ## [Documentation](https://docs.rs/winit)

dockerfiles/Dockerfile.ubuntu

@@ -1,40 +0,0 @@
-# syntax=docker/dockerfile:1
-# Copyright 2024 The Winit Contributors
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-
-ARG DISTRO=ubuntu
-ARG DISTRO_VERSION=22.04
-
-FROM "${DISTRO}":"${DISTRO_VERSION}"
-SHELL ["/bin/bash", "-eEuxo", "pipefail", "-c"]
-ARG DEBIAN_FRONTEND=noninteractive
-
-RUN \
-apt-get -o Acquire::Retries=10 -qq update && \
-apt-get -o Acquire::Retries=10 -o Dpkg::Use-Pty=0 install -y --no-install-recommends \
-    cargo \
-    ca-certificates \
-    libx11-dev \
-    libxcursor-dev \
-    libxcb1-dev \
-    libxi-dev \
-    libxkbcommon-dev \
-    libxkbcommon-x11-dev \
-    xvfb && \
-rm -rf \
-    /var/lib/apt/lists/* \
-    /var/cache/* \
-    /var/log/* \
-    /usr/share/{doc,man}
-

dpi/CHANGELOG.md

@@ -1,20 +0,0 @@
-# Changelog
-
-All notable changes to this project will be documented in this file.
-
-Please keep one empty line before and after all headers. (This is required for
-`git` to produce a conflict when a release is made while a PR is open and the
-PR's changelog entry would go into the wrong section).
-
-And please only add new entries to the top of this list, right below the `#
-Unreleased` header.
-
-## Unreleased
-
-## 0.1.1
-
-- Derive `Debug`, `Copy`, `Clone`, `PartialEq`, `Serialize`, `Deserialize` traits for `PixelUnit`.
-
-## 0.1.0
-
-- Add `LogicalUnit`, `PhysicalUnit` and `PixelUnit` types and related functions.

dpi/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "dpi"
-version = "0.1.1"
+version = "0.0.0"
 description = "Types for handling UI scaling"
 keywords = ["DPI", "HiDPI", "scale-factor"]
 categories = ["gui"]

dpi/src/lib.rs

@@ -35,8 +35,8 @@
 //!
 //! ### Position and Size types
 //!
-//! The [`PhysicalPosition`] / [`PhysicalSize`] / [`PhysicalUnit`] types correspond with the actual pixels on the
+//! The [`PhysicalPosition`] / [`PhysicalSize`] types correspond with the actual pixels on the
-//! device, and the [`LogicalPosition`] / [`LogicalSize`] / [`LogicalUnit`] types correspond to the physical pixels
+//! device, and the [`LogicalPosition`] / [`LogicalSize`] types correspond to the physical pixels
 //! divided by the scale factor.
 //!
 //! The position and size types are generic over their exact pixel type, `P`, to allow the
@@ -128,240 +128,6 @@ pub fn validate_scale_factor(scale_factor: f64) -> bool {
     scale_factor.is_sign_positive() && scale_factor.is_normal()
 }
 
-/// A logical pixel unit.
-#[derive(Debug, Copy, Clone, Eq, PartialEq, Ord, PartialOrd, Default, Hash)]
-#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
-pub struct LogicalUnit<P>(pub P);
-
-impl<P> LogicalUnit<P> {
-    /// Represents a minimum logical unit of [`f64::MAX`].
-    pub const MIN: LogicalUnit<f64> = LogicalUnit::new(f64::MIN);
-    /// Represents a logical unit of `0_f64`.
-    pub const ZERO: LogicalUnit<f64> = LogicalUnit::new(0.0);
-    /// Represents a maximum logical unit that is equal to [`f64::MAX`].
-    pub const MAX: LogicalUnit<f64> = LogicalUnit::new(f64::MAX);
-
-    #[inline]
-    pub const fn new(v: P) -> Self {
-        LogicalUnit(v)
-    }
-}
-
-impl<P: Pixel> LogicalUnit<P> {
-    #[inline]
-    pub fn from_physical<T: Into<PhysicalUnit<X>>, X: Pixel>(
-        physical: T,
-        scale_factor: f64,
-    ) -> Self {
-        physical.into().to_logical(scale_factor)
-    }
-
-    #[inline]
-    pub fn to_physical<X: Pixel>(&self, scale_factor: f64) -> PhysicalUnit<X> {
-        assert!(validate_scale_factor(scale_factor));
-        PhysicalUnit::new(self.0.into() * scale_factor).cast()
-    }
-
-    #[inline]
-    pub fn cast<X: Pixel>(&self) -> LogicalUnit<X> {
-        LogicalUnit(self.0.cast())
-    }
-}
-
-impl<P: Pixel, X: Pixel> From<X> for LogicalUnit<P> {
-    fn from(v: X) -> LogicalUnit<P> {
-        LogicalUnit::new(v.cast())
-    }
-}
-
-impl<P: Pixel> From<LogicalUnit<P>> for u8 {
-    fn from(v: LogicalUnit<P>) -> u8 {
-        v.0.cast()
-    }
-}
-
-impl<P: Pixel> From<LogicalUnit<P>> for u16 {
-    fn from(v: LogicalUnit<P>) -> u16 {
-        v.0.cast()
-    }
-}
-
-impl<P: Pixel> From<LogicalUnit<P>> for u32 {
-    fn from(v: LogicalUnit<P>) -> u32 {
-        v.0.cast()
-    }
-}
-
-impl<P: Pixel> From<LogicalUnit<P>> for i8 {
-    fn from(v: LogicalUnit<P>) -> i8 {
-        v.0.cast()
-    }
-}
-
-impl<P: Pixel> From<LogicalUnit<P>> for i16 {
-    fn from(v: LogicalUnit<P>) -> i16 {
-        v.0.cast()
-    }
-}
-
-impl<P: Pixel> From<LogicalUnit<P>> for i32 {
-    fn from(v: LogicalUnit<P>) -> i32 {
-        v.0.cast()
-    }
-}
-
-impl<P: Pixel> From<LogicalUnit<P>> for f32 {
-    fn from(v: LogicalUnit<P>) -> f32 {
-        v.0.cast()
-    }
-}
-
-impl<P: Pixel> From<LogicalUnit<P>> for f64 {
-    fn from(v: LogicalUnit<P>) -> f64 {
-        v.0.cast()
-    }
-}
-
-/// A physical pixel unit.
-#[derive(Debug, Copy, Clone, Eq, PartialEq, Ord, PartialOrd, Default, Hash)]
-#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
-pub struct PhysicalUnit<P>(pub P);
-
-impl<P> PhysicalUnit<P> {
-    /// Represents a minimum physical unit of [`f64::MAX`].
-    pub const MIN: LogicalUnit<f64> = LogicalUnit::new(f64::MIN);
-    /// Represents a physical unit of `0_f64`.
-    pub const ZERO: LogicalUnit<f64> = LogicalUnit::new(0.0);
-    /// Represents a maximum physical unit that is equal to [`f64::MAX`].
-    pub const MAX: LogicalUnit<f64> = LogicalUnit::new(f64::MAX);
-
-    #[inline]
-    pub const fn new(v: P) -> Self {
-        PhysicalUnit(v)
-    }
-}
-
-impl<P: Pixel> PhysicalUnit<P> {
-    #[inline]
-    pub fn from_logical<T: Into<LogicalUnit<X>>, X: Pixel>(logical: T, scale_factor: f64) -> Self {
-        logical.into().to_physical(scale_factor)
-    }
-
-    #[inline]
-    pub fn to_logical<X: Pixel>(&self, scale_factor: f64) -> LogicalUnit<X> {
-        assert!(validate_scale_factor(scale_factor));
-        LogicalUnit::new(self.0.into() / scale_factor).cast()
-    }
-
-    #[inline]
-    pub fn cast<X: Pixel>(&self) -> PhysicalUnit<X> {
-        PhysicalUnit(self.0.cast())
-    }
-}
-
-impl<P: Pixel, X: Pixel> From<X> for PhysicalUnit<P> {
-    fn from(v: X) -> PhysicalUnit<P> {
-        PhysicalUnit::new(v.cast())
-    }
-}
-
-impl<P: Pixel> From<PhysicalUnit<P>> for u8 {
-    fn from(v: PhysicalUnit<P>) -> u8 {
-        v.0.cast()
-    }
-}
-
-impl<P: Pixel> From<PhysicalUnit<P>> for u16 {
-    fn from(v: PhysicalUnit<P>) -> u16 {
-        v.0.cast()
-    }
-}
-
-impl<P: Pixel> From<PhysicalUnit<P>> for u32 {
-    fn from(v: PhysicalUnit<P>) -> u32 {
-        v.0.cast()
-    }
-}
-
-impl<P: Pixel> From<PhysicalUnit<P>> for i8 {
-    fn from(v: PhysicalUnit<P>) -> i8 {
-        v.0.cast()
-    }
-}
-
-impl<P: Pixel> From<PhysicalUnit<P>> for i16 {
-    fn from(v: PhysicalUnit<P>) -> i16 {
-        v.0.cast()
-    }
-}
-
-impl<P: Pixel> From<PhysicalUnit<P>> for i32 {
-    fn from(v: PhysicalUnit<P>) -> i32 {
-        v.0.cast()
-    }
-}
-
-impl<P: Pixel> From<PhysicalUnit<P>> for f32 {
-    fn from(v: PhysicalUnit<P>) -> f32 {
-        v.0.cast()
-    }
-}
-
-impl<P: Pixel> From<PhysicalUnit<P>> for f64 {
-    fn from(v: PhysicalUnit<P>) -> f64 {
-        v.0.cast()
-    }
-}
-
-/// A pixel unit that's either physical or logical.
-#[derive(Debug, Copy, Clone, PartialEq)]
-#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
-pub enum PixelUnit {
-    Physical(PhysicalUnit<i32>),
-    Logical(LogicalUnit<f64>),
-}
-
-impl PixelUnit {
-    /// Represents a minimum logical unit of [`f64::MAX`].
-    pub const MIN: PixelUnit = PixelUnit::Logical(LogicalUnit::new(f64::MIN));
-    /// Represents a logical unit of `0_f64`.
-    pub const ZERO: PixelUnit = PixelUnit::Logical(LogicalUnit::new(0.0));
-    /// Represents a maximum logical unit that is equal to [`f64::MAX`].
-    pub const MAX: PixelUnit = PixelUnit::Logical(LogicalUnit::new(f64::MAX));
-
-    pub fn new<S: Into<PixelUnit>>(unit: S) -> PixelUnit {
-        unit.into()
-    }
-
-    pub fn to_logical<P: Pixel>(&self, scale_factor: f64) -> LogicalUnit<P> {
-        match *self {
-            PixelUnit::Physical(unit) => unit.to_logical(scale_factor),
-            PixelUnit::Logical(unit) => unit.cast(),
-        }
-    }
-
-    pub fn to_physical<P: Pixel>(&self, scale_factor: f64) -> PhysicalUnit<P> {
-        match *self {
-            PixelUnit::Physical(unit) => unit.cast(),
-            PixelUnit::Logical(unit) => unit.to_physical(scale_factor),
-        }
-    }
-}
-
-impl<P: Pixel> From<PhysicalUnit<P>> for PixelUnit {
-    #[inline]
-    fn from(unit: PhysicalUnit<P>) -> PixelUnit {
-        PixelUnit::Physical(unit.cast())
-    }
-}
-
-impl<P: Pixel> From<LogicalUnit<P>> for PixelUnit {
-    #[inline]
-    fn from(unit: LogicalUnit<P>) -> PixelUnit {
-        PixelUnit::Logical(unit.cast())
-    }
-}
-
 /// A position represented in logical pixels.
 ///
 /// The position is stored as floats, so please be careful. Casting floats to integers truncates the
@@ -964,43 +730,6 @@ mod tests {
         assert!(!validate_scale_factor(f64::NEG_INFINITY));
     }
 
-    #[test]
-    fn test_logical_unity() {
-        let log_unit = LogicalUnit::new(1.0);
-        assert_eq!(log_unit.to_physical::<u32>(1.0), PhysicalUnit::new(1));
-        assert_eq!(log_unit.to_physical::<u32>(2.0), PhysicalUnit::new(2));
-        assert_eq!(log_unit.cast::<u32>(), LogicalUnit::new(1));
-        assert_eq!(
-            log_unit,
-            LogicalUnit::from_physical(PhysicalUnit::new(1.0), 1.0)
-        );
-        assert_eq!(
-            log_unit,
-            LogicalUnit::from_physical(PhysicalUnit::new(2.0), 2.0)
-        );
-        assert_eq!(LogicalUnit::from(2.0), LogicalUnit::new(2.0));
-
-        let x: f64 = log_unit.into();
-        assert_eq!(x, 1.0);
-    }
-
-    #[test]
-    fn test_physical_unit() {
-        assert_eq!(
-            PhysicalUnit::from_logical(LogicalUnit::new(1.0), 1.0),
-            PhysicalUnit::new(1)
-        );
-        assert_eq!(
-            PhysicalUnit::from_logical(LogicalUnit::new(2.0), 0.5),
-            PhysicalUnit::new(1)
-        );
-        assert_eq!(PhysicalUnit::from(2.0), PhysicalUnit::new(2.0,));
-        assert_eq!(PhysicalUnit::from(2.0), PhysicalUnit::new(2.0));
-
-        let x: f64 = PhysicalUnit::new(1).into();
-        assert_eq!(x, 1.0);
-    }
-
     #[test]
     fn test_logical_position() {
         let log_pos = LogicalPosition::new(1.0, 2.0);
@@ -1207,38 +936,4 @@ mod tests {
         let _ = format!("{:?}", Size::Physical((1, 2).into()).clone());
         let _ = format!("{:?}", Position::Physical((1, 2).into()).clone());
     }
-
-    #[test]
-    fn ensure_copy_trait() {
-        fn is_copy<T: Copy>() {}
-
-        is_copy::<LogicalUnit<i32>>();
-        is_copy::<PhysicalUnit<f64>>();
-        is_copy::<PixelUnit>();
-
-        is_copy::<LogicalSize<i32>>();
-        is_copy::<PhysicalSize<f64>>();
-        is_copy::<Size>();
-
-        is_copy::<LogicalPosition<i32>>();
-        is_copy::<PhysicalPosition<f64>>();
-        is_copy::<Position>();
-    }
-
-    #[test]
-    fn ensure_partial_eq_trait() {
-        fn is_partial_eq<T: PartialEq>() {}
-
-        is_partial_eq::<LogicalUnit<i32>>();
-        is_partial_eq::<PhysicalUnit<f64>>();
-        is_partial_eq::<PixelUnit>();
-
-        is_partial_eq::<LogicalSize<i32>>();
-        is_partial_eq::<PhysicalSize<f64>>();
-        is_partial_eq::<Size>();
-
-        is_partial_eq::<LogicalPosition<i32>>();
-        is_partial_eq::<PhysicalPosition<f64>>();
-        is_partial_eq::<Position>();
-    }
 }

examples/control_flow.rs

@@ -3,32 +3,32 @@
 use std::thread;
 #[cfg(not(web_platform))]
 use std::time;
-
 #[cfg(web_platform)]
 use web_time as time;
 
-use winit::application::ApplicationHandler;
+use simple_logger::SimpleLogger;
-use winit::event::{ElementState, KeyEvent, StartCause, WindowEvent};
+use winit::{
-use winit::event_loop::{ActiveEventLoop, ControlFlow, EventLoop};
+    event::{ElementState, Event, KeyEvent, WindowEvent},
-use winit::keyboard::{Key, NamedKey};
+    event_loop::{ControlFlow, EventLoop},
-use winit::window::{Window, WindowId};
+    keyboard::{Key, NamedKey},
+    window::Window,
+};
 
 #[path = "util/fill.rs"]
 mod fill;
 
-const WAIT_TIME: time::Duration = time::Duration::from_millis(100);
+#[derive(Debug, Clone, Copy, PartialEq, Eq)]
-const POLL_SLEEP_TIME: time::Duration = time::Duration::from_millis(100);
-
-#[derive(Default, Debug, Clone, Copy, PartialEq, Eq)]
 enum Mode {
-    #[default]
     Wait,
     WaitUntil,
     Poll,
 }
 
+const WAIT_TIME: time::Duration = time::Duration::from_millis(100);
+const POLL_SLEEP_TIME: time::Duration = time::Duration::from_millis(100);
+
 fn main() -> Result<(), impl std::error::Error> {
-    tracing_subscriber::fmt::init();
+    SimpleLogger::new().init().unwrap();
 
     println!("Press '1' to switch to Wait mode.");
     println!("Press '2' to switch to WaitUntil mode.");
@@ -38,110 +38,96 @@ fn main() -> Result<(), impl std::error::Error> {
 
     let event_loop = EventLoop::new().unwrap();
 
-    let mut app = ControlFlowDemo::default();
+    let mut mode = Mode::Wait;
-    event_loop.run_app(&mut app)
+    let mut request_redraw = false;
-}
+    let mut wait_cancelled = false;
+    let mut close_requested = false;
 
-#[derive(Default)]
+    let mut window = None;
-struct ControlFlowDemo {
+    event_loop.run(move |event, event_loop| {
-    mode: Mode,
+        use winit::event::StartCause;
-    request_redraw: bool,
-    wait_cancelled: bool,
-    close_requested: bool,
-    window: Option<Window>,
-}
-
-impl ApplicationHandler for ControlFlowDemo {
-    fn new_events(&mut self, _event_loop: &ActiveEventLoop, cause: StartCause) {
-        println!("new_events: {cause:?}");
-
-        self.wait_cancelled = match cause {
-            StartCause::WaitCancelled { .. } => self.mode == Mode::WaitUntil,
-            _ => false,
-        }
-    }
-
-    fn resumed(&mut self, event_loop: &ActiveEventLoop) {
-        let window_attributes = Window::default_attributes().with_title(
-            "Press 1, 2, 3 to change control flow mode. Press R to toggle redraw requests.",
-        );
-        self.window = Some(event_loop.create_window(window_attributes).unwrap());
-    }
-
-    fn window_event(
-        &mut self,
-        _event_loop: &ActiveEventLoop,
-        _window_id: WindowId,
-        event: WindowEvent,
-    ) {
         println!("{event:?}");
-
         match event {
-            WindowEvent::CloseRequested => {
+            Event::NewEvents(start_cause) => {
-                self.close_requested = true;
+                wait_cancelled = match start_cause {
+                    StartCause::WaitCancelled { .. } => mode == Mode::WaitUntil,
+                    _ => false,
+                }
             }
-            WindowEvent::KeyboardInput {
+            Event::Resumed => {
-                event:
+                let window_attributes = Window::default_attributes().with_title(
-                    KeyEvent {
+                    "Press 1, 2, 3 to change control flow mode. Press R to toggle redraw requests.",
-                        logical_key: key,
+                );
-                        state: ElementState::Pressed,
+                window = Some(event_loop.create_window(window_attributes).unwrap());
-                        ..
+            }
-                    },
+            Event::WindowEvent { event, .. } => match event {
-                ..
+                WindowEvent::CloseRequested => {
-            } => match key.as_ref() {
+                    close_requested = true;
-                // WARNING: Consider using `key_without_modifiers()` if available on your platform.
-                // See the `key_binding` example
-                Key::Character("1") => {
-                    self.mode = Mode::Wait;
-                    println!("\nmode: {:?}\n", self.mode);
                 }
-                Key::Character("2") => {
+                WindowEvent::KeyboardInput {
-                    self.mode = Mode::WaitUntil;
+                    event:
-                    println!("\nmode: {:?}\n", self.mode);
+                        KeyEvent {
-                }
+                            logical_key: key,
-                Key::Character("3") => {
+                            state: ElementState::Pressed,
-                    self.mode = Mode::Poll;
+                            ..
-                    println!("\nmode: {:?}\n", self.mode);
+                        },
-                }
+                    ..
-                Key::Character("r") => {
+                } => match key.as_ref() {
-                    self.request_redraw = !self.request_redraw;
+                    // WARNING: Consider using `key_without_modifiers()` if available on your platform.
-                    println!("\nrequest_redraw: {}\n", self.request_redraw);
+                    // See the `key_binding` example
-                }
+                    Key::Character("1") => {
-                Key::Named(NamedKey::Escape) => {
+                        mode = Mode::Wait;
-                    self.close_requested = true;
+                        println!("\nmode: {mode:?}\n");
+                    }
+                    Key::Character("2") => {
+                        mode = Mode::WaitUntil;
+                        println!("\nmode: {mode:?}\n");
+                    }
+                    Key::Character("3") => {
+                        mode = Mode::Poll;
+                        println!("\nmode: {mode:?}\n");
+                    }
+                    Key::Character("r") => {
+                        request_redraw = !request_redraw;
+                        println!("\nrequest_redraw: {request_redraw}\n");
+                    }
+                    Key::Named(NamedKey::Escape) => {
+                        close_requested = true;
+                    }
+                    _ => (),
+                },
+                WindowEvent::RedrawRequested => {
+                    let window = window.as_ref().unwrap();
+                    window.pre_present_notify();
+                    fill::fill_window(window);
                 }
                 _ => (),
             },
-            WindowEvent::RedrawRequested => {
+            Event::AboutToWait => {
-                let window = self.window.as_ref().unwrap();
+                if request_redraw && !wait_cancelled && !close_requested {
-                window.pre_present_notify();
+                    window.as_ref().unwrap().request_redraw();
-                fill::fill_window(window);
+                }
+
+                match mode {
+                    Mode::Wait => event_loop.set_control_flow(ControlFlow::Wait),
+                    Mode::WaitUntil => {
+                        if !wait_cancelled {
+                            event_loop.set_control_flow(ControlFlow::WaitUntil(
+                                time::Instant::now() + WAIT_TIME,
+                            ));
+                        }
+                    }
+                    Mode::Poll => {
+                        thread::sleep(POLL_SLEEP_TIME);
+                        event_loop.set_control_flow(ControlFlow::Poll);
+                    }
+                };
+
+                if close_requested {
+                    event_loop.exit();
+                }
             }
             _ => (),
         }
-    }
+    })
-
-    fn about_to_wait(&mut self, event_loop: &ActiveEventLoop) {
-        if self.request_redraw && !self.wait_cancelled && !self.close_requested {
-            self.window.as_ref().unwrap().request_redraw();
-        }
-
-        match self.mode {
-            Mode::Wait => event_loop.set_control_flow(ControlFlow::Wait),
-            Mode::WaitUntil => {
-                if !self.wait_cancelled {
-                    event_loop
-                        .set_control_flow(ControlFlow::WaitUntil(time::Instant::now() + WAIT_TIME));
-                }
-            }
-            Mode::Poll => {
-                thread::sleep(POLL_SLEEP_TIME);
-                event_loop.set_control_flow(ControlFlow::Poll);
-            }
-        };
-
-        if self.close_requested {
-            event_loop.exit();
-        }
-    }
 }

examples/full.rs

@@ -0,0 +1,847 @@
+//! An example showcasing various functionality that Winit has.
+//!
+//! Often used by Winit developers to test certain functionality, may be a bit
+//! verbose.
+
+use std::collections::HashMap;
+use std::error::Error;
+#[cfg(not(any(android_platform, ios_platform)))]
+use std::num::NonZeroU32;
+
+use cursor_icon::CursorIcon;
+#[cfg(not(any(android_platform, ios_platform)))]
+use rwh_05::HasRawDisplayHandle;
+#[cfg(not(any(android_platform, ios_platform)))]
+use softbuffer::{Context, Surface};
+
+use winit::dpi::{LogicalSize, PhysicalPosition, PhysicalSize};
+use winit::event::{DeviceEvent, DeviceId, ElementState, Event, Ime, KeyEvent, WindowEvent};
+use winit::event::{MouseButton, MouseScrollDelta};
+use winit::event_loop::{ActiveEventLoop, EventLoop};
+use winit::keyboard::{Key, ModifiersState};
+use winit::window::{
+    Cursor, CursorGrabMode, CustomCursor, Fullscreen, Icon, ResizeDirection, Theme,
+};
+use winit::window::{Window, WindowId};
+
+#[cfg(macos_platform)]
+use winit::platform::macos::{OptionAsAlt, WindowAttributesExtMacOS, WindowExtMacOS};
+#[cfg(any(x11_platform, wayland_platform))]
+use winit::platform::startup_notify::{
+    self, EventLoopExtStartupNotify, WindowAttributesExtStartupNotify, WindowExtStartupNotify,
+};
+
+fn main() -> Result<(), Box<dyn Error>> {
+    let event_loop = EventLoop::<UserEvent>::with_user_event().build()?;
+    let _event_loop_proxy = event_loop.create_proxy();
+
+    // Wire the user event from another thread.
+    #[cfg(not(web_platform))]
+    std::thread::spawn(move || {
+        // Wake up the `event_loop` once every second and dispatch a custom event
+        // from a different thread.
+        println!("Starting to send user event every second");
+        loop {
+            let _ = _event_loop_proxy.send_event(UserEvent::WakeUp);
+            std::thread::sleep(std::time::Duration::from_secs(1));
+        }
+    });
+
+    let mut app = Application::new(&event_loop);
+
+    event_loop.run(move |event, event_loop| match event {
+        Event::NewEvents(_) => (),
+        Event::Resumed => {
+            println!("Resumed the event loop");
+
+            // Create initial window.
+            app.create_window(event_loop, None)
+                .expect("failed to create initial window");
+
+            app.print_help();
+        }
+        Event::AboutToWait => {
+            if app.windows.is_empty() {
+                println!("No windows left, exiting...");
+                event_loop.exit();
+            }
+        }
+        Event::WindowEvent { window_id, event } => {
+            app.handle_window_event(event_loop, window_id, event)
+        }
+        Event::DeviceEvent { device_id, event } => {
+            app.handle_device_event(event_loop, device_id, event)
+        }
+        Event::UserEvent(event) => {
+            println!("User event: {event:?}");
+        }
+        Event::Suspended | Event::LoopExiting | Event::MemoryWarning => (),
+    })?;
+
+    Ok(())
+}
+
+#[allow(dead_code)]
+#[derive(Debug, Clone, Copy)]
+enum UserEvent {
+    WakeUp,
+}
+
+/// Application state and event handling.
+struct Application {
+    /// Custom cursors assets.
+    custom_cursors: Vec<CustomCursor>,
+    /// Application icon.
+    icon: Icon,
+    windows: HashMap<WindowId, WindowState>,
+    /// Drawing context.
+    ///
+    /// With OpenGL it could be EGLDisplay.
+    #[cfg(not(any(android_platform, ios_platform)))]
+    context: Context,
+}
+
+impl Application {
+    fn new<T>(event_loop: &EventLoop<T>) -> Self {
+        // SAFETY: the context is dropped inside the loop, since the state we're using
+        // is moved inside the closure.
+        #[cfg(not(any(android_platform, ios_platform)))]
+        let context = unsafe { Context::from_raw(event_loop.raw_display_handle()).unwrap() };
+
+        // You'll have to choose an icon size at your own discretion. On X11, the desired size varies
+        // by WM, and on Windows, you still have to account for screen scaling. Here we use 32px,
+        // since it seems to work well enough in most cases. Be careful about going too high, or
+        // you'll be bitten by the low-quality downscaling built into the WM.
+        let path = concat!(env!("CARGO_MANIFEST_DIR"), "/examples/data/icon.png");
+
+        // Load icon
+        let icon = {
+            let image = image::open(path)
+                .expect("Failed to open icon path")
+                .into_rgba8();
+            let (width, height) = image.dimensions();
+            let rgba = image.into_raw();
+            Icon::from_rgba(rgba, width, height).expect("Failed to open icon")
+        };
+
+        println!("Loading cursor assets");
+        let decode_cursor = |bytes| {
+            let img = image::load_from_memory(bytes).unwrap().to_rgba8();
+            let samples = img.into_flat_samples();
+            let (_, w, h) = samples.extents();
+            let (w, h) = (w as u16, h as u16);
+            CustomCursor::from_rgba(samples.samples, w, h, w / 2, h / 2).unwrap()
+        };
+        let custom_cursors = vec![
+            event_loop.create_custom_cursor(decode_cursor(include_bytes!("data/cross.png"))),
+            event_loop.create_custom_cursor(decode_cursor(include_bytes!("data/cross2.png"))),
+            event_loop.create_custom_cursor(decode_cursor(include_bytes!("data/gradient.png"))),
+        ];
+
+        Self {
+            #[cfg(not(any(android_platform, ios_platform)))]
+            context,
+            custom_cursors,
+            icon,
+            windows: Default::default(),
+        }
+    }
+
+    fn create_window(
+        &mut self,
+        event_loop: &ActiveEventLoop,
+        _tab_id: Option<String>,
+    ) -> Result<WindowId, Box<dyn Error>> {
+        // TODO read-out activation token.
+
+        #[allow(unused_mut)]
+        let mut window_attributes = Window::default_attributes()
+            .with_title("Winit window")
+            .with_transparent(true)
+            .with_window_icon(Some(self.icon.clone()));
+
+        #[cfg(any(x11_platform, wayland_platform))]
+        if let Some(token) = event_loop.read_token_from_env() {
+            startup_notify::reset_activation_token_env();
+            println!("Using token {:?} to activate a window", token);
+            window_attributes = window_attributes.with_activation_token(token);
+        }
+
+        #[cfg(macos_platform)]
+        if let Some(tab_id) = _tab_id {
+            window_attributes = window_attributes.with_tabbing_identifier(&tab_id);
+        }
+
+        let window = event_loop.create_window(window_attributes)?;
+
+        #[cfg(ios_platform)]
+        {
+            use winit::platform::ios::WindowExtIOS;
+            window.recognize_doubletap_gesture(true);
+            window.recognize_pinch_gesture(true);
+            window.recognize_rotation_gesture(true);
+        }
+
+        #[cfg(not(any(android_platform, ios_platform)))]
+        let surface = {
+            // SAFETY: the surface is dropped before the `window` which
+            // provided it with handle, thus it doesn't outlive it.
+            let mut surface = unsafe { Surface::new(&self.context, &window)? };
+
+            let size = window.inner_size();
+            if let (Some(width), Some(height)) =
+                (NonZeroU32::new(size.width), NonZeroU32::new(size.height))
+            {
+                surface
+                    .resize(width, height)
+                    .expect("failed to resize inner buffer");
+            };
+
+            surface
+        };
+
+        let theme = window.theme().unwrap_or(Theme::Dark);
+        println!("Theme: {theme:?}");
+
+        // Allow IME out of the box.
+        let ime = true;
+        window.set_ime_allowed(ime);
+
+        let state = WindowState {
+            window,
+            custom_idx: self.custom_cursors.len() - 1,
+            cursor_grab: CursorGrabMode::None,
+            named_idx: 0,
+            #[cfg(not(any(android_platform, ios_platform)))]
+            surface,
+            theme,
+            ime,
+            cursor_position: Default::default(),
+            cursor_hidden: Default::default(),
+            modifiers: Default::default(),
+            occluded: Default::default(),
+            rotated: Default::default(),
+            zoom: Default::default(),
+        };
+
+        let window_id = state.window.id();
+        println!("Created new window with id={window_id:?}");
+        self.windows.insert(window_id, state);
+        Ok(window_id)
+    }
+
+    fn handle_action(&mut self, event_loop: &ActiveEventLoop, window_id: WindowId, action: Action) {
+        let state = self.windows.get_mut(&window_id).unwrap();
+        let window = &state.window;
+
+        println!("Executing action: {action:?}");
+        match action {
+            Action::CloseWindow => {
+                let _ = self.windows.remove(&window_id);
+            }
+            Action::CreateNewWindow => {
+                #[cfg(any(x11_platform, wayland_platform))]
+                if let Err(err) = window.request_activation_token() {
+                    println!("Failed to get activation token: {err}");
+                } else {
+                    return;
+                }
+
+                if let Err(err) = self.create_window(event_loop, None) {
+                    eprintln!("Error creating new window: {err}");
+                }
+            }
+            Action::ToggleResizeIncrements => {
+                let new_increments = match window.resize_increments() {
+                    Some(_) => None,
+                    None => Some(LogicalSize::new(25.0, 25.0)),
+                };
+                println!("Had increments: {}", new_increments.is_none());
+                window.set_resize_increments(new_increments);
+            }
+            Action::ToggleCursorVisibility => {
+                state.cursor_hidden = !state.cursor_hidden;
+                window.set_cursor_visible(!state.cursor_hidden);
+            }
+            Action::ToggleResizable => {
+                let resizable = window.is_resizable();
+                window.set_resizable(!resizable);
+            }
+            Action::ToggleDecorations => {
+                let decorated = window.is_decorated();
+                window.set_decorations(!decorated);
+            }
+            Action::ToggleFullscreen => {
+                let fullscreen = if window.fullscreen().is_some() {
+                    None
+                } else {
+                    Some(Fullscreen::Borderless(None))
+                };
+
+                window.set_fullscreen(fullscreen);
+            }
+            Action::ToggleMaximize => {
+                let maximized = window.is_maximized();
+                window.set_maximized(!maximized);
+            }
+            Action::ToggleImeInput => {
+                state.ime = !state.ime;
+                window.set_ime_allowed(state.ime);
+                if let Some(position) = state.ime.then_some(state.cursor_position).flatten() {
+                    window.set_ime_cursor_area(position, PhysicalSize::new(20, 20));
+                }
+            }
+            Action::Minimize => {
+                window.set_minimized(true);
+            }
+            Action::NextCursor => {
+                // Cursor list to cycle through.
+                const CURSORS: &[CursorIcon] = &[
+                    CursorIcon::Default,
+                    CursorIcon::Crosshair,
+                    CursorIcon::Pointer,
+                    CursorIcon::Move,
+                    CursorIcon::Text,
+                    CursorIcon::Wait,
+                    CursorIcon::Help,
+                    CursorIcon::Progress,
+                    CursorIcon::NotAllowed,
+                    CursorIcon::ContextMenu,
+                    CursorIcon::Cell,
+                    CursorIcon::VerticalText,
+                    CursorIcon::Alias,
+                    CursorIcon::Copy,
+                    CursorIcon::NoDrop,
+                    CursorIcon::Grab,
+                    CursorIcon::Grabbing,
+                    CursorIcon::AllScroll,
+                    CursorIcon::ZoomIn,
+                    CursorIcon::ZoomOut,
+                    CursorIcon::EResize,
+                    CursorIcon::NResize,
+                    CursorIcon::NeResize,
+                    CursorIcon::NwResize,
+                    CursorIcon::SResize,
+                    CursorIcon::SeResize,
+                    CursorIcon::SwResize,
+                    CursorIcon::WResize,
+                    CursorIcon::EwResize,
+                    CursorIcon::NsResize,
+                    CursorIcon::NeswResize,
+                    CursorIcon::NwseResize,
+                    CursorIcon::ColResize,
+                    CursorIcon::RowResize,
+                ];
+
+                // Pick the next cursor
+                state.named_idx = (state.named_idx + 1) % CURSORS.len();
+                println!("Setting cursor to \"{:?}\"", CURSORS[state.named_idx]);
+                window.set_cursor(Cursor::Icon(CURSORS[state.named_idx]));
+            }
+            Action::NextCustomCursor => {
+                state.custom_idx = (state.custom_idx + 1) % self.custom_cursors.len();
+                let cursor = Cursor::Custom(self.custom_cursors[state.custom_idx].clone());
+                window.set_cursor(cursor);
+            }
+            Action::CycleCursorGrab => {
+                state.cursor_grab = match state.cursor_grab {
+                    CursorGrabMode::None => CursorGrabMode::Confined,
+                    CursorGrabMode::Confined => CursorGrabMode::Locked,
+                    CursorGrabMode::Locked => CursorGrabMode::None,
+                };
+                println!("Changing cursor grab mode to {:?}", state.cursor_grab);
+                if let Err(err) = window.set_cursor_grab(state.cursor_grab) {
+                    eprintln!("Error setting cursor grab: {err}");
+                }
+            }
+            Action::DragWindow => {
+                if let Err(err) = window.drag_window() {
+                    println!("Error starting window drag: {err}");
+                } else {
+                    println!("Dragging window Window={:?}", window.id());
+                }
+            }
+            Action::DragResizeWindow => {
+                let position = match state.cursor_position {
+                    Some(position) => position,
+                    None => {
+                        println!("Drag-resize requires cursor to be inside the window");
+                        return;
+                    }
+                };
+
+                // The amount of points around the window.
+                const BORDER_SIZE: f64 = 20.0;
+
+                let win_size = window.inner_size();
+                let border_size = BORDER_SIZE * window.scale_factor();
+
+                let x_direction = if position.x < border_size {
+                    ResizeDirection::West
+                } else if position.x > (win_size.width as f64 - border_size) {
+                    ResizeDirection::East
+                } else {
+                    // Use arbitrary direction instead of None for simplicity.
+                    ResizeDirection::SouthEast
+                };
+
+                let y_direction = if position.y < border_size {
+                    ResizeDirection::North
+                } else if position.y > (win_size.height as f64 - border_size) {
+                    ResizeDirection::South
+                } else {
+                    // Use arbitrary direction instead of None for simplicity.
+                    ResizeDirection::SouthEast
+                };
+
+                let direction = match (x_direction, y_direction) {
+                    (ResizeDirection::West, ResizeDirection::North) => ResizeDirection::NorthWest,
+                    (ResizeDirection::West, ResizeDirection::South) => ResizeDirection::SouthWest,
+                    (ResizeDirection::West, _) => ResizeDirection::West,
+                    (ResizeDirection::East, ResizeDirection::North) => ResizeDirection::NorthEast,
+                    (ResizeDirection::East, ResizeDirection::South) => ResizeDirection::SouthEast,
+                    (ResizeDirection::East, _) => ResizeDirection::East,
+                    (_, ResizeDirection::South) => ResizeDirection::South,
+                    (_, ResizeDirection::North) => ResizeDirection::North,
+                    _ => return,
+                };
+
+                if let Err(err) = window.drag_resize_window(direction) {
+                    println!("Error starting window drag-resize: {err}");
+                } else {
+                    println!("Drag-resizing window Window={:?}", window.id());
+                }
+            }
+            Action::ShowWindowMenu => {
+                if let Some(position) = state.cursor_position {
+                    window.show_window_menu(position);
+                }
+            }
+            Action::PrintHelp => self.print_help(),
+            #[cfg(macos_platform)]
+            Action::CycleOptionAsAlt => {
+                let new = match window.option_as_alt() {
+                    OptionAsAlt::None => OptionAsAlt::OnlyLeft,
+                    OptionAsAlt::OnlyLeft => OptionAsAlt::OnlyRight,
+                    OptionAsAlt::OnlyRight => OptionAsAlt::Both,
+                    OptionAsAlt::Both => OptionAsAlt::None,
+                };
+                println!("Setting option as alt {:?}", new);
+                window.set_option_as_alt(new);
+            }
+            #[cfg(macos_platform)]
+            Action::CreateNewTab => {
+                let tab_id = window.tabbing_identifier();
+                if let Err(err) = self.create_window(event_loop, Some(tab_id)) {
+                    eprintln!("Error creating new window: {err}");
+                }
+            }
+        }
+    }
+
+    fn handle_window_event(
+        &mut self,
+        event_loop: &ActiveEventLoop,
+        window_id: WindowId,
+        event: WindowEvent,
+    ) {
+        let state = match self.windows.get_mut(&window_id) {
+            Some(state) => state,
+            None => return,
+        };
+        let window = &state.window;
+
+        match event {
+            // Resize the surface to the new size
+            WindowEvent::Resized(_size) => {
+                #[cfg(not(any(android_platform, ios_platform)))]
+                {
+                    let (width, height) =
+                        match (NonZeroU32::new(_size.width), NonZeroU32::new(_size.height)) {
+                            (Some(width), Some(height)) => (width, height),
+                            _ => return,
+                        };
+                    state
+                        .surface
+                        .resize(width, height)
+                        .expect("failed to resize inner buffer");
+                }
+                window.request_redraw();
+            }
+            WindowEvent::Focused(focused) => {
+                if focused {
+                    println!("Window={window_id:?} fosused");
+                } else {
+                    println!("Window={window_id:?} unfosused");
+                }
+            }
+            WindowEvent::ScaleFactorChanged { scale_factor, .. } => {
+                println!("Window={window_id:?} changed scale to {scale_factor}");
+            }
+            WindowEvent::ThemeChanged(theme) => {
+                println!("Theme changed to {theme:?}");
+                state.theme = theme;
+                window.request_redraw();
+            }
+            #[cfg(not(any(android_platform, ios_platform)))]
+            WindowEvent::RedrawRequested => {
+                // Draw the window contents.
+
+                if state.occluded {
+                    println!("Skipping drawing occluded window={:?}", window_id);
+                }
+
+                const WHITE: u32 = 0xFFFFFFFF;
+                const DARK_GRAY: u32 = 0xFF181818;
+
+                let color = match state.theme {
+                    Theme::Light => WHITE,
+                    Theme::Dark => DARK_GRAY,
+                };
+
+                let mut buffer = state
+                    .surface
+                    .buffer_mut()
+                    .expect("could not retrieve buffer");
+                buffer.fill(color);
+                window.pre_present_notify();
+                buffer.present().expect("failed presenting to window");
+            }
+            #[cfg(any(android_platform, ios_platform))]
+            WindowEvent::RedrawRequested => {
+                println!("Drawing but without rendering...");
+            }
+            // Change window occlusion state.
+            WindowEvent::Occluded(occluded) => {
+                state.occluded = occluded;
+                if !occluded {
+                    window.request_redraw();
+                }
+            }
+            WindowEvent::CloseRequested => {
+                println!("Closing Window={window_id:?}");
+                self.windows.remove(&window_id);
+            }
+            WindowEvent::ModifiersChanged(modifiers) => {
+                state.modifiers = modifiers.state();
+                println!("Modifiers changed to {:?}", state.modifiers);
+            }
+            WindowEvent::MouseWheel { delta, .. } => match delta {
+                MouseScrollDelta::LineDelta(x, y) => {
+                    println!("Mouse wheel Line Delta: ({x},{y})");
+                }
+                MouseScrollDelta::PixelDelta(px) => {
+                    println!("Mouse wheel Pixel Delta: ({},{})", px.x, px.y);
+                }
+            },
+            WindowEvent::KeyboardInput {
+                event:
+                    KeyEvent {
+                        // Dispatch actions only on press.
+                        state: ElementState::Pressed,
+                        logical_key,
+                        ..
+                    },
+                is_synthetic: false,
+                ..
+            } => {
+                if let Key::Character(ch) = logical_key.as_ref() {
+                    let mods = state.modifiers;
+                    if let Some(action) = Self::process_key_binding(&ch.to_uppercase(), &mods) {
+                        self.handle_action(event_loop, window_id, action);
+                    }
+                }
+            }
+            WindowEvent::KeyboardInput { .. } => {}
+            WindowEvent::MouseInput {
+                button,
+                state: ElementState::Pressed,
+                ..
+            } => {
+                if let Some(action) = Self::process_mouse_binding(button, &state.modifiers) {
+                    self.handle_action(event_loop, window_id, action);
+                }
+            }
+            WindowEvent::MouseInput { .. } => {}
+            WindowEvent::CursorLeft { .. } => {
+                println!("Cursor left Window={window_id:?}");
+                state.cursor_position = None;
+            }
+            WindowEvent::CursorMoved { position, .. } => {
+                println!("Moved cursor to {position:?}");
+                state.cursor_position = Some(position);
+                if state.ime {
+                    window.set_ime_cursor_area(position, PhysicalSize::new(20, 20));
+                }
+            }
+            WindowEvent::ActivationTokenDone { token: _token, .. } => {
+                #[cfg(any(x11_platform, wayland_platform))]
+                {
+                    startup_notify::set_activation_token_env(_token);
+                    if let Err(err) = self.create_window(event_loop, None) {
+                        eprintln!("Error creating new window: {err}");
+                    }
+                }
+            }
+            WindowEvent::Ime(event) => match event {
+                Ime::Enabled => println!("IME enabled for Window={window_id:?}"),
+                Ime::Preedit(text, caret_pos) => {
+                    println!("Preedit: {}, with caret at {:?}", text, caret_pos);
+                }
+                Ime::Commit(text) => {
+                    println!("Commited: {}", text);
+                }
+                Ime::Disabled => println!("IME disabled for Window={window_id:?}"),
+            },
+            WindowEvent::PinchGesture { delta, .. } => {
+                state.zoom += delta;
+                let zoom = state.zoom;
+                if delta > 0.0 {
+                    println!("Zoomed in {delta:.5} (now: {zoom:.5})");
+                } else {
+                    println!("Zoomed out {delta:.5} (now: {zoom:.5})");
+                }
+            }
+            WindowEvent::RotationGesture { delta, .. } => {
+                state.rotated += delta;
+                let rotated = state.rotated;
+                if delta > 0.0 {
+                    println!("Rotated counterclockwise {delta:.5} (now: {rotated:.5})");
+                } else {
+                    println!("Rotated clockwise {delta:.5} (now: {rotated:.5})");
+                }
+            }
+            WindowEvent::DoubleTapGesture { .. } => {
+                println!("Smart zoom");
+            }
+            WindowEvent::TouchpadPressure { .. }
+            | WindowEvent::HoveredFileCancelled
+            | WindowEvent::CursorEntered { .. }
+            | WindowEvent::AxisMotion { .. }
+            | WindowEvent::DroppedFile(_)
+            | WindowEvent::HoveredFile(_)
+            | WindowEvent::Destroyed
+            | WindowEvent::Touch(_)
+            | WindowEvent::Moved(_) => (),
+        }
+    }
+
+    fn handle_device_event(&mut self, _: &ActiveEventLoop, _: DeviceId, event: DeviceEvent) {
+        println!("Device event: {event:?}");
+    }
+
+    /// Process the key binding.
+    fn process_key_binding(key: &str, mods: &ModifiersState) -> Option<Action> {
+        KEY_BINDINGS.iter().find_map(|binding| {
+            binding
+                .is_triggered_by(&key, mods)
+                .then_some(binding.action)
+        })
+    }
+
+    /// Process mouse binding.
+    fn process_mouse_binding(button: MouseButton, mods: &ModifiersState) -> Option<Action> {
+        MOUSE_BINDINGS.iter().find_map(|binding| {
+            binding
+                .is_triggered_by(&button, mods)
+                .then_some(binding.action)
+        })
+    }
+
+    fn print_help(&self) {
+        fn modifiers_to_string(mods: ModifiersState) -> String {
+            let mut mods_line = String::new();
+            // Always add + since it's printed as a part of the bindings.
+            for (modifier, desc) in [
+                (ModifiersState::SUPER, "Super+"),
+                (ModifiersState::ALT, "Alt+"),
+                (ModifiersState::CONTROL, "Ctrl+"),
+                (ModifiersState::SHIFT, "Shift+"),
+            ] {
+                if !mods.contains(modifier) {
+                    continue;
+                }
+
+                mods_line.push_str(desc);
+            }
+            mods_line
+        }
+
+        println!("Keyboard bindings:");
+        for binding in KEY_BINDINGS {
+            println!(
+                "{}{:<10} - {:?} ({})",
+                modifiers_to_string(binding.mods),
+                binding.trigger,
+                binding.action,
+                binding.action.help(),
+            );
+        }
+        println!("Mouse bindings:");
+        for binding in MOUSE_BINDINGS {
+            let button_name = match binding.trigger {
+                MouseButton::Left => "LMB",
+                MouseButton::Right => "RMB",
+                MouseButton::Middle => "MMB",
+                MouseButton::Back => "Back",
+                MouseButton::Forward => "Forward",
+                MouseButton::Other(_) => "",
+            };
+
+            println!(
+                "{}{:<10} - {:?} ({})",
+                modifiers_to_string(binding.mods),
+                button_name,
+                binding.action,
+                binding.action.help(),
+            );
+        }
+    }
+}
+
+/// Extra state on a window used in this example.
+struct WindowState {
+    /// The actual Winit window.
+    window: Window,
+    /// IME input.
+    ime: bool,
+    /// Render surface.
+    ///
+    /// NOTE: This surface must be dropped before the `Window`.
+    #[cfg(not(any(android_platform, ios_platform)))]
+    surface: Surface,
+    /// The window theme we're drawing with.
+    theme: Theme,
+    /// Cursor position over the window.
+    cursor_position: Option<PhysicalPosition<f64>>,
+    /// Window modifiers state.
+    modifiers: ModifiersState,
+    /// Occlusion state of the window.
+    occluded: bool,
+    /// Current cursor grab mode.
+    cursor_grab: CursorGrabMode,
+    /// The amount of zoom into window.
+    zoom: f64,
+    /// The amount of rotation of the window.
+    rotated: f32,
+    // Cursor states.
+    named_idx: usize,
+    custom_idx: usize,
+    cursor_hidden: bool,
+}
+
+struct Binding<T: Eq> {
+    trigger: T,
+    mods: ModifiersState,
+    action: Action,
+}
+
+impl<T: Eq> Binding<T> {
+    const fn new(trigger: T, mods: ModifiersState, action: Action) -> Self {
+        Self {
+            trigger,
+            mods,
+            action,
+        }
+    }
+
+    fn is_triggered_by(&self, trigger: &T, mods: &ModifiersState) -> bool {
+        &self.trigger == trigger && &self.mods == mods
+    }
+}
+
+/// Helper enum describing the different kinds of actions this example can do.
+#[derive(Debug, Clone, Copy, PartialEq, Eq)]
+enum Action {
+    CloseWindow,
+    ToggleCursorVisibility,
+    CreateNewWindow,
+    ToggleResizeIncrements,
+    ToggleImeInput,
+    ToggleDecorations,
+    ToggleResizable,
+    ToggleFullscreen,
+    ToggleMaximize,
+    Minimize,
+    NextCursor,
+    NextCustomCursor,
+    CycleCursorGrab,
+    PrintHelp,
+    DragWindow,
+    DragResizeWindow,
+    ShowWindowMenu,
+    #[cfg(macos_platform)]
+    CycleOptionAsAlt,
+    #[cfg(macos_platform)]
+    CreateNewTab,
+}
+
+impl Action {
+    fn help(&self) -> &'static str {
+        match self {
+            Action::CloseWindow => "Close window",
+            Action::ToggleCursorVisibility => "Hide cursor",
+            Action::CreateNewWindow => "Create new window",
+            Action::ToggleImeInput => "Toggle IME input",
+            Action::ToggleDecorations => "Toggle decorations",
+            Action::ToggleResizable => "Toggle window resizable state",
+            Action::ToggleFullscreen => "Toggle fullscreen",
+            Action::ToggleMaximize => "Maximize",
+            Action::Minimize => "Minimize",
+            Action::ToggleResizeIncrements => "Use resize increments when resizing window",
+            Action::NextCursor => "Advance the cursor to the next value",
+            Action::NextCustomCursor => "Advance custom cursor to the next value",
+            Action::CycleCursorGrab => "Cycle through cursor grab mode",
+            Action::PrintHelp => "Print help",
+            Action::DragWindow => "Start window drag",
+            Action::DragResizeWindow => "Start window drag-resize",
+            Action::ShowWindowMenu => "Show window menu",
+            #[cfg(macos_platform)]
+            Action::CycleOptionAsAlt => "Cycle option as alt mode",
+            #[cfg(macos_platform)]
+            Action::CreateNewTab => "Create new tab",
+        }
+    }
+}
+
+const KEY_BINDINGS: &[Binding<&'static str>] = &[
+    Binding::new("Q", ModifiersState::CONTROL, Action::CloseWindow),
+    Binding::new("H", ModifiersState::CONTROL, Action::PrintHelp),
+    Binding::new("F", ModifiersState::CONTROL, Action::ToggleFullscreen),
+    Binding::new("D", ModifiersState::CONTROL, Action::ToggleDecorations),
+    Binding::new("I", ModifiersState::CONTROL, Action::ToggleImeInput),
+    Binding::new("L", ModifiersState::CONTROL, Action::CycleCursorGrab),
+    Binding::new("P", ModifiersState::CONTROL, Action::ToggleResizeIncrements),
+    Binding::new("R", ModifiersState::CONTROL, Action::ToggleResizable),
+    // M.
+    Binding::new("M", ModifiersState::CONTROL, Action::ToggleMaximize),
+    Binding::new("M", ModifiersState::ALT, Action::Minimize),
+    // N.
+    Binding::new("N", ModifiersState::CONTROL, Action::CreateNewWindow),
+    // C.
+    Binding::new("C", ModifiersState::CONTROL, Action::NextCursor),
+    Binding::new("C", ModifiersState::ALT, Action::NextCustomCursor),
+    Binding::new("Z", ModifiersState::CONTROL, Action::ToggleCursorVisibility),
+    #[cfg(macos_platform)]
+    Binding::new("T", ModifiersState::SUPER, Action::CreateNewTab),
+    #[cfg(macos_platform)]
+    Binding::new("O", ModifiersState::CONTROL, Action::CycleOptionAsAlt),
+];
+
+const MOUSE_BINDINGS: &[Binding<MouseButton>] = &[
+    Binding::new(
+        MouseButton::Left,
+        ModifiersState::ALT,
+        Action::DragResizeWindow,
+    ),
+    Binding::new(
+        MouseButton::Left,
+        ModifiersState::CONTROL,
+        Action::DragWindow,
+    ),
+    Binding::new(
+        MouseButton::Right,
+        ModifiersState::CONTROL,
+        Action::ShowWindowMenu,
+    ),
+];

examples/monitors.rs

@@ -0,0 +1,62 @@
+use std::error::Error;
+use winit::{
+    event::{Event, StartCause},
+    event_loop::{ActiveEventLoop, EventLoop},
+};
+
+fn main() -> Result<(), Box<dyn Error>> {
+    let event_loop = EventLoop::new()?;
+
+    Ok(event_loop.run(|event, event_loop| match event {
+        Event::NewEvents(StartCause::Init) => {
+            dump_monitors(event_loop);
+            event_loop.exit()
+        }
+        _ => {}
+    })?)
+}
+
+fn dump_monitors(event_loop: &ActiveEventLoop) {
+    println!("Monitors information");
+    let primary_monitor = event_loop.primary_monitor();
+    for monitor in event_loop.available_monitors() {
+        let intro = if primary_monitor.as_ref() == Some(&monitor) {
+            "Primary monitor"
+        } else {
+            "Monitor"
+        };
+
+        if let Some(name) = monitor.name() {
+            println!("{intro}: {name}");
+        } else {
+            println!("{intro}: [no name]");
+        }
+
+        let size = monitor.size();
+        print!("  Current mode: {}x{}", size.width, size.height);
+        if let Some(m_hz) = monitor.refresh_rate_millihertz() {
+            println!(" @ {}.{} Hz", m_hz / 1000, m_hz % 1000);
+        } else {
+            println!();
+        }
+
+        let position = monitor.position();
+        println!("  Position: {}, {}", position.x, position.y);
+
+        println!("  Scale factor: {}", monitor.scale_factor());
+
+        println!("  Available modes (width x height x bit-depth):");
+        for mode in monitor.video_modes() {
+            let size = mode.size();
+            let m_hz = mode.refresh_rate_millihertz();
+            println!(
+                "    {:04}x{:04}x{:02} @ {:>3}.{} Hz",
+                size.width,
+                size.height,
+                mode.bit_depth(),
+                m_hz / 1000,
+                m_hz % 1000
+            );
+        }
+    }
+}

examples/pump_events.rs

@@ -11,59 +11,51 @@
 fn main() -> std::process::ExitCode {
     use std::{process::ExitCode, thread::sleep, time::Duration};
 
-    use winit::application::ApplicationHandler;
+    use simple_logger::SimpleLogger;
-    use winit::event::WindowEvent;
+    use winit::{
-    use winit::event_loop::{ActiveEventLoop, EventLoop};
+        event::{Event, WindowEvent},
-    use winit::platform::pump_events::{EventLoopExtPumpEvents, PumpStatus};
+        event_loop::EventLoop,
-    use winit::window::{Window, WindowId};
+        platform::pump_events::{EventLoopExtPumpEvents, PumpStatus},
+        window::Window,
+    };
 
     #[path = "util/fill.rs"]
     mod fill;
 
-    #[derive(Default)]
-    struct PumpDemo {
-        window: Option<Window>,
-    }
-
-    impl ApplicationHandler for PumpDemo {
-        fn resumed(&mut self, event_loop: &ActiveEventLoop) {
-            let window_attributes = Window::default_attributes().with_title("A fantastic window!");
-            self.window = Some(event_loop.create_window(window_attributes).unwrap());
-        }
-
-        fn window_event(
-            &mut self,
-            event_loop: &ActiveEventLoop,
-            _window_id: WindowId,
-            event: WindowEvent,
-        ) {
-            println!("{event:?}");
-
-            let window = match self.window.as_ref() {
-                Some(window) => window,
-                None => return,
-            };
-
-            match event {
-                WindowEvent::CloseRequested => event_loop.exit(),
-                WindowEvent::RedrawRequested => {
-                    fill::fill_window(window);
-                    window.request_redraw();
-                }
-                _ => (),
-            }
-        }
-    }
-
     let mut event_loop = EventLoop::new().unwrap();
 
-    tracing_subscriber::fmt::init();
+    SimpleLogger::new().init().unwrap();
 
-    let mut app = PumpDemo::default();
+    let mut window = None;
 
     loop {
         let timeout = Some(Duration::ZERO);
-        let status = event_loop.pump_app_events(timeout, &mut app);
+        let status = event_loop.pump_events(timeout, |event, event_loop| {
+            if let Event::WindowEvent { event, .. } = &event {
+                // Print only Window events to reduce noise
+                println!("{event:?}");
+            }
+
+            match event {
+                Event::Resumed => {
+                    let window_attributes =
+                        Window::default_attributes().with_title("A fantastic window!");
+                    window = Some(event_loop.create_window(window_attributes).unwrap());
+                }
+                Event::WindowEvent { event, .. } => {
+                    let window = window.as_ref().unwrap();
+                    match event {
+                        WindowEvent::CloseRequested => event_loop.exit(),
+                        WindowEvent::RedrawRequested => fill::fill_window(window),
+                        _ => (),
+                    }
+                }
+                Event::AboutToWait => {
+                    window.as_ref().unwrap().request_redraw();
+                }
+                _ => (),
+            }
+        });
 
         if let PumpStatus::Exit(exit_code) = status {
             break ExitCode::from(exit_code as u8);

examples/run_on_demand.rs

@@ -2,94 +2,88 @@
 
 // Limit this example to only compatible platforms.
 #[cfg(any(windows_platform, macos_platform, x11_platform, wayland_platform,))]
-fn main() -> Result<(), Box<dyn std::error::Error>> {
+fn main() -> Result<(), impl std::error::Error> {
     use std::time::Duration;
 
-    use winit::application::ApplicationHandler;
+    use simple_logger::SimpleLogger;
-    use winit::event::WindowEvent;
+
-    use winit::event_loop::{ActiveEventLoop, EventLoop};
+    use winit::{
-    use winit::platform::run_on_demand::EventLoopExtRunOnDemand;
+        error::EventLoopError,
-    use winit::window::{Window, WindowId};
+        event::{Event, WindowEvent},
+        event_loop::EventLoop,
+        platform::run_on_demand::EventLoopExtRunOnDemand,
+        window::{Window, WindowId},
+    };
 
     #[path = "util/fill.rs"]
     mod fill;
 
     #[derive(Default)]
     struct App {
-        idx: usize,
         window_id: Option<WindowId>,
         window: Option<Window>,
     }
 
-    impl ApplicationHandler for App {
+    SimpleLogger::new().init().unwrap();
-        fn about_to_wait(&mut self, _event_loop: &ActiveEventLoop) {
-            if let Some(window) = self.window.as_ref() {
-                window.request_redraw();
-            }
-        }
-
-        fn resumed(&mut self, event_loop: &ActiveEventLoop) {
-            let window_attributes = Window::default_attributes()
-                .with_title("Fantastic window number one!")
-                .with_inner_size(winit::dpi::LogicalSize::new(128.0, 128.0));
-            let window = event_loop.create_window(window_attributes).unwrap();
-            self.window_id = Some(window.id());
-            self.window = Some(window);
-        }
-
-        fn window_event(
-            &mut self,
-            event_loop: &ActiveEventLoop,
-            window_id: WindowId,
-            event: WindowEvent,
-        ) {
-            if event == WindowEvent::Destroyed && self.window_id == Some(window_id) {
-                println!(
-                    "--------------------------------------------------------- Window {} Destroyed",
-                    self.idx
-                );
-                self.window_id = None;
-                event_loop.exit();
-                return;
-            }
-
-            let window = match self.window.as_mut() {
-                Some(window) => window,
-                None => return,
-            };
-
-            match event {
-                WindowEvent::CloseRequested => {
-                    println!("--------------------------------------------------------- Window {} CloseRequested", self.idx);
-                    fill::cleanup_window(window);
-                    self.window = None;
-                }
-                WindowEvent::RedrawRequested => {
-                    fill::fill_window(window);
-                }
-                _ => (),
-            }
-        }
-    }
-
-    tracing_subscriber::fmt::init();
-
     let mut event_loop = EventLoop::new().unwrap();
 
-    let mut app = App {
+    fn run_app(event_loop: &mut EventLoop<()>, idx: usize) -> Result<(), EventLoopError> {
-        idx: 1,
+        let mut app = App::default();
-        ..Default::default()
+
-    };
+        event_loop.run_on_demand(move |event, event_loop| {
-    event_loop.run_app_on_demand(&mut app)?;
+            println!("Run {idx}: {:?}", event);
+
+            if let Some(window) = &app.window {
+                match event {
+                    Event::WindowEvent {
+                        event: WindowEvent::CloseRequested,
+                        window_id,
+                    } if window.id() == window_id => {
+                        println!("--------------------------------------------------------- Window {idx} CloseRequested");
+                        fill::cleanup_window(window);
+                        app.window = None;
+                    }
+                    Event::AboutToWait => window.request_redraw(),
+                    Event::WindowEvent {
+                        event: WindowEvent::RedrawRequested,
+                        ..
+                    }  => {
+                        fill::fill_window(window);
+                    }
+                    _ => (),
+                }
+            } else if let Some(id) = app.window_id {
+                match event {
+                    Event::WindowEvent {
+                        event: WindowEvent::Destroyed,
+                        window_id,
+                    } if id == window_id => {
+                        println!("--------------------------------------------------------- Window {idx} Destroyed");
+                        app.window_id = None;
+                        event_loop.exit();
+                    }
+                    _ => (),
+                }
+            } else if let Event::Resumed = event {
+                let window_attributes = Window::default_attributes()
+                        .with_title("Fantastic window number one!")
+                        .with_inner_size(winit::dpi::LogicalSize::new(128.0, 128.0));
+                let window = event_loop.create_window(window_attributes).unwrap();
+                app.window_id = Some(window.id());
+                app.window = Some(window);
+            }
+        })
+    }
+
+    run_app(&mut event_loop, 1)?;
 
     println!("--------------------------------------------------------- Finished first loop");
     println!("--------------------------------------------------------- Waiting 5 seconds");
     std::thread::sleep(Duration::from_secs(5));
 
-    app.idx += 1;
+    let ret = run_app(&mut event_loop, 2);
-    event_loop.run_app_on_demand(&mut app)?;
     println!("--------------------------------------------------------- Finished second loop");
-    Ok(())
+    ret
 }
 
 #[cfg(not(any(windows_platform, macos_platform, x11_platform, wayland_platform,)))]

examples/window.rs

@@ -1,984 +0,0 @@
-//! Simple winit application.
-
-use std::collections::HashMap;
-use std::error::Error;
-use std::fmt;
-use std::fmt::Debug;
-#[cfg(not(any(android_platform, ios_platform)))]
-use std::num::NonZeroU32;
-use std::path::Path;
-
-use cursor_icon::CursorIcon;
-#[cfg(not(any(android_platform, ios_platform)))]
-use rwh_05::HasRawDisplayHandle;
-#[cfg(not(any(android_platform, ios_platform)))]
-use softbuffer::{Context, Surface};
-
-use winit::application::ApplicationHandler;
-use winit::dpi::{LogicalSize, PhysicalPosition, PhysicalSize};
-use winit::event::{DeviceEvent, DeviceId, Ime, WindowEvent};
-use winit::event::{MouseButton, MouseScrollDelta};
-use winit::event_loop::{ActiveEventLoop, EventLoop};
-use winit::keyboard::{Key, ModifiersState};
-use winit::window::{
-    Cursor, CursorGrabMode, CustomCursor, CustomCursorSource, Fullscreen, Icon, ResizeDirection,
-    Theme,
-};
-use winit::window::{Window, WindowId};
-
-#[cfg(macos_platform)]
-use winit::platform::macos::{OptionAsAlt, WindowAttributesExtMacOS, WindowExtMacOS};
-#[cfg(any(x11_platform, wayland_platform))]
-use winit::platform::startup_notify::{
-    self, EventLoopExtStartupNotify, WindowAttributesExtStartupNotify, WindowExtStartupNotify,
-};
-
-/// The amount of points to around the window for drag resize direction calculations.
-const BORDER_SIZE: f64 = 20.;
-
-fn main() -> Result<(), Box<dyn Error>> {
-    let event_loop = EventLoop::<UserEvent>::with_user_event().build()?;
-    let _event_loop_proxy = event_loop.create_proxy();
-
-    // Wire the user event from another thread.
-    #[cfg(not(web_platform))]
-    std::thread::spawn(move || {
-        // Wake up the `event_loop` once every second and dispatch a custom event
-        // from a different thread.
-        println!("Starting to send user event every second");
-        loop {
-            let _ = _event_loop_proxy.send_event(UserEvent::WakeUp);
-            std::thread::sleep(std::time::Duration::from_secs(1));
-        }
-    });
-
-    let mut state = Application::new(&event_loop);
-
-    event_loop.run_app(&mut state).map_err(Into::into)
-}
-
-#[allow(dead_code)]
-#[derive(Debug, Clone, Copy)]
-enum UserEvent {
-    WakeUp,
-}
-
-/// Application state and event handling.
-struct Application {
-    /// Custom cursors assets.
-    custom_cursors: Vec<CustomCursor>,
-    /// Application icon.
-    icon: Icon,
-    windows: HashMap<WindowId, WindowState>,
-    /// Drawing context.
-    ///
-    /// With OpenGL it could be EGLDisplay.
-    #[cfg(not(any(android_platform, ios_platform)))]
-    context: Option<Context>,
-}
-
-impl Application {
-    fn new<T>(event_loop: &EventLoop<T>) -> Self {
-        // SAFETY: we drop the context right before the event loop is stopped, thus making it safe.
-        #[cfg(not(any(android_platform, ios_platform)))]
-        let context = Some(unsafe { Context::from_raw(event_loop.raw_display_handle()).unwrap() });
-
-        // You'll have to choose an icon size at your own discretion. On X11, the desired size varies
-        // by WM, and on Windows, you still have to account for screen scaling. Here we use 32px,
-        // since it seems to work well enough in most cases. Be careful about going too high, or
-        // you'll be bitten by the low-quality downscaling built into the WM.
-        let path = concat!(env!("CARGO_MANIFEST_DIR"), "/examples/data/icon.png");
-
-        let icon = load_icon(Path::new(path));
-
-        println!("Loading cursor assets");
-        let custom_cursors = vec![
-            event_loop.create_custom_cursor(decode_cursor(include_bytes!("data/cross.png"))),
-            event_loop.create_custom_cursor(decode_cursor(include_bytes!("data/cross2.png"))),
-            event_loop.create_custom_cursor(decode_cursor(include_bytes!("data/gradient.png"))),
-        ];
-
-        Self {
-            #[cfg(not(any(android_platform, ios_platform)))]
-            context,
-            custom_cursors,
-            icon,
-            windows: Default::default(),
-        }
-    }
-
-    fn create_window(
-        &mut self,
-        event_loop: &ActiveEventLoop,
-        _tab_id: Option<String>,
-    ) -> Result<WindowId, Box<dyn Error>> {
-        // TODO read-out activation token.
-
-        #[allow(unused_mut)]
-        let mut window_attributes = Window::default_attributes()
-            .with_title("Winit window")
-            .with_transparent(true)
-            .with_window_icon(Some(self.icon.clone()));
-
-        #[cfg(any(x11_platform, wayland_platform))]
-        if let Some(token) = event_loop.read_token_from_env() {
-            startup_notify::reset_activation_token_env();
-            println!("Using token {:?} to activate a window", token);
-            window_attributes = window_attributes.with_activation_token(token);
-        }
-
-        #[cfg(macos_platform)]
-        if let Some(tab_id) = _tab_id {
-            window_attributes = window_attributes.with_tabbing_identifier(&tab_id);
-        }
-
-        let window = event_loop.create_window(window_attributes)?;
-
-        #[cfg(ios_platform)]
-        {
-            use winit::platform::ios::WindowExtIOS;
-            window.recognize_doubletap_gesture(true);
-            window.recognize_pinch_gesture(true);
-            window.recognize_rotation_gesture(true);
-        }
-
-        let window_state = WindowState::new(self, window)?;
-        let window_id = window_state.window.id();
-        println!("Created new window with id={window_id:?}");
-        self.windows.insert(window_id, window_state);
-        Ok(window_id)
-    }
-
-    fn handle_action(&mut self, event_loop: &ActiveEventLoop, window_id: WindowId, action: Action) {
-        // let cursor_position = self.cursor_position;
-        let window = self.windows.get_mut(&window_id).unwrap();
-        println!("Executing action: {action:?}");
-        match action {
-            Action::CloseWindow => {
-                let _ = self.windows.remove(&window_id);
-            }
-            Action::CreateNewWindow => {
-                #[cfg(any(x11_platform, wayland_platform))]
-                if let Err(err) = window.window.request_activation_token() {
-                    println!("Failed to get activation token: {err}");
-                } else {
-                    return;
-                }
-
-                if let Err(err) = self.create_window(event_loop, None) {
-                    eprintln!("Error creating new window: {err}");
-                }
-            }
-            Action::ToggleResizeIncrements => window.toggle_resize_increments(),
-            Action::ToggleCursorVisibility => window.toggle_cursor_visibility(),
-            Action::ToggleResizable => window.toggle_resizable(),
-            Action::ToggleDecorations => window.toggle_decorations(),
-            Action::ToggleFullscreen => window.toggle_fullscreen(),
-            Action::ToggleMaximize => window.toggle_maximize(),
-            Action::ToggleImeInput => window.toggle_ime(),
-            Action::Minimize => window.minimize(),
-            Action::NextCursor => window.next_cursor(),
-            Action::NextCustomCursor => window.next_custom_cursor(&self.custom_cursors),
-            Action::CycleCursorGrab => window.cycle_cursor_grab(),
-            Action::DragWindow => window.drag_window(),
-            Action::DragResizeWindow => window.drag_resize_window(),
-            Action::ShowWindowMenu => window.show_menu(),
-            Action::PrintHelp => self.print_help(),
-            #[cfg(macos_platform)]
-            Action::CycleOptionAsAlt => window.cycle_option_as_alt(),
-            #[cfg(macos_platform)]
-            Action::CreateNewTab => {
-                let tab_id = window.window.tabbing_identifier();
-                if let Err(err) = self.create_window(event_loop, Some(tab_id)) {
-                    eprintln!("Error creating new window: {err}");
-                }
-            }
-        }
-    }
-
-    fn dump_monitors(&self, event_loop: &ActiveEventLoop) {
-        println!("Monitors information");
-        let primary_monitor = event_loop.primary_monitor();
-        for monitor in event_loop.available_monitors() {
-            let intro = if primary_monitor.as_ref() == Some(&monitor) {
-                "Primary monitor"
-            } else {
-                "Monitor"
-            };
-
-            if let Some(name) = monitor.name() {
-                println!("{intro}: {name}");
-            } else {
-                println!("{intro}: [no name]");
-            }
-
-            let PhysicalSize { width, height } = monitor.size();
-            print!("  Current mode: {width}x{height}");
-            if let Some(m_hz) = monitor.refresh_rate_millihertz() {
-                println!(" @ {}.{} Hz", m_hz / 1000, m_hz % 1000);
-            } else {
-                println!();
-            }
-
-            let PhysicalPosition { x, y } = monitor.position();
-            println!("  Position: {x},{y}");
-
-            println!("  Scale factor: {}", monitor.scale_factor());
-
-            println!("  Available modes (width x height x bit-depth):");
-            for mode in monitor.video_modes() {
-                let PhysicalSize { width, height } = mode.size();
-                let bits = mode.bit_depth();
-                let m_hz = mode.refresh_rate_millihertz();
-                println!(
-                    "    {width}x{height}x{bits} @ {}.{} Hz",
-                    m_hz / 1000,
-                    m_hz % 1000
-                );
-            }
-        }
-    }
-
-    /// Process the key binding.
-    fn process_key_binding(key: &str, mods: &ModifiersState) -> Option<Action> {
-        KEY_BINDINGS.iter().find_map(|binding| {
-            binding
-                .is_triggered_by(&key, mods)
-                .then_some(binding.action)
-        })
-    }
-
-    /// Process mouse binding.
-    fn process_mouse_binding(button: MouseButton, mods: &ModifiersState) -> Option<Action> {
-        MOUSE_BINDINGS.iter().find_map(|binding| {
-            binding
-                .is_triggered_by(&button, mods)
-                .then_some(binding.action)
-        })
-    }
-
-    fn print_help(&self) {
-        println!("Keyboard bindings:");
-        for binding in KEY_BINDINGS {
-            println!(
-                "{}{:<10} - {} ({})",
-                modifiers_to_string(binding.mods),
-                binding.trigger,
-                binding.action,
-                binding.action.help(),
-            );
-        }
-        println!("Mouse bindings:");
-        for binding in MOUSE_BINDINGS {
-            println!(
-                "{}{:<10} - {} ({})",
-                modifiers_to_string(binding.mods),
-                mouse_button_to_string(binding.trigger),
-                binding.action,
-                binding.action.help(),
-            );
-        }
-    }
-}
-
-impl ApplicationHandler<UserEvent> for Application {
-    fn user_event(&mut self, _event_loop: &ActiveEventLoop, event: UserEvent) {
-        println!("User event: {event:?}");
-    }
-
-    fn window_event(
-        &mut self,
-        event_loop: &ActiveEventLoop,
-        window_id: WindowId,
-        event: WindowEvent,
-    ) {
-        let window = match self.windows.get_mut(&window_id) {
-            Some(window) => window,
-            None => return,
-        };
-
-        match event {
-            WindowEvent::Resized(size) => {
-                window.resize(size);
-            }
-            WindowEvent::Focused(focused) => {
-                if focused {
-                    println!("Window={window_id:?} fosused");
-                } else {
-                    println!("Window={window_id:?} unfosused");
-                }
-            }
-            WindowEvent::ScaleFactorChanged { scale_factor, .. } => {
-                println!("Window={window_id:?} changed scale to {scale_factor}");
-            }
-            WindowEvent::ThemeChanged(theme) => {
-                println!("Theme changed to {theme:?}");
-                window.set_theme(theme);
-            }
-            WindowEvent::RedrawRequested => {
-                if let Err(err) = window.draw() {
-                    eprintln!("Error drawing window: {err}");
-                }
-            }
-            WindowEvent::Occluded(occluded) => {
-                window.set_occluded(occluded);
-            }
-            WindowEvent::CloseRequested => {
-                println!("Closing Window={window_id:?}");
-                self.windows.remove(&window_id);
-            }
-            WindowEvent::ModifiersChanged(modifiers) => {
-                window.modifiers = modifiers.state();
-                println!("Modifiers changed to {:?}", window.modifiers);
-            }
-            WindowEvent::MouseWheel { delta, .. } => match delta {
-                MouseScrollDelta::LineDelta(x, y) => {
-                    println!("Mouse wheel Line Delta: ({x},{y})");
-                }
-                MouseScrollDelta::PixelDelta(px) => {
-                    println!("Mouse wheel Pixel Delta: ({},{})", px.x, px.y);
-                }
-            },
-            WindowEvent::KeyboardInput {
-                event,
-                is_synthetic: false,
-                ..
-            } => {
-                let mods = window.modifiers;
-
-                // Dispatch actions only on press.
-                if event.state.is_pressed() {
-                    let action = if let Key::Character(ch) = event.logical_key.as_ref() {
-                        Self::process_key_binding(&ch.to_uppercase(), &mods)
-                    } else {
-                        None
-                    };
-
-                    if let Some(action) = action {
-                        self.handle_action(event_loop, window_id, action);
-                    }
-                }
-            }
-            WindowEvent::MouseInput { button, state, .. } => {
-                let mods = window.modifiers;
-                if let Some(action) = state
-                    .is_pressed()
-                    .then(|| Self::process_mouse_binding(button, &mods))
-                    .flatten()
-                {
-                    self.handle_action(event_loop, window_id, action);
-                }
-            }
-            WindowEvent::CursorLeft { .. } => {
-                println!("Cursor left Window={window_id:?}");
-                window.cursor_left();
-            }
-            WindowEvent::CursorMoved { position, .. } => {
-                println!("Moved cursor to {position:?}");
-                window.cursor_moved(position);
-            }
-            WindowEvent::ActivationTokenDone { token: _token, .. } => {
-                #[cfg(any(x11_platform, wayland_platform))]
-                {
-                    startup_notify::set_activation_token_env(_token);
-                    if let Err(err) = self.create_window(event_loop, None) {
-                        eprintln!("Error creating new window: {err}");
-                    }
-                }
-            }
-            WindowEvent::Ime(event) => match event {
-                Ime::Enabled => println!("IME enabled for Window={window_id:?}"),
-                Ime::Preedit(text, caret_pos) => {
-                    println!("Preedit: {}, with caret at {:?}", text, caret_pos);
-                }
-                Ime::Commit(text) => {
-                    println!("Committed: {}", text);
-                }
-                Ime::Disabled => println!("IME disabled for Window={window_id:?}"),
-            },
-            WindowEvent::PinchGesture { delta, .. } => {
-                window.zoom += delta;
-                let zoom = window.zoom;
-                if delta > 0.0 {
-                    println!("Zoomed in {delta:.5} (now: {zoom:.5})");
-                } else {
-                    println!("Zoomed out {delta:.5} (now: {zoom:.5})");
-                }
-            }
-            WindowEvent::RotationGesture { delta, .. } => {
-                window.rotated += delta;
-                let rotated = window.rotated;
-                if delta > 0.0 {
-                    println!("Rotated counterclockwise {delta:.5} (now: {rotated:.5})");
-                } else {
-                    println!("Rotated clockwise {delta:.5} (now: {rotated:.5})");
-                }
-            }
-            WindowEvent::DoubleTapGesture { .. } => {
-                println!("Smart zoom");
-            }
-            WindowEvent::TouchpadPressure { .. }
-            | WindowEvent::HoveredFileCancelled
-            | WindowEvent::KeyboardInput { .. }
-            | WindowEvent::CursorEntered { .. }
-            | WindowEvent::AxisMotion { .. }
-            | WindowEvent::DroppedFile(_)
-            | WindowEvent::HoveredFile(_)
-            | WindowEvent::Destroyed
-            | WindowEvent::Touch(_)
-            | WindowEvent::Moved(_) => (),
-        }
-    }
-
-    fn device_event(
-        &mut self,
-        _event_loop: &ActiveEventLoop,
-        device_id: DeviceId,
-        event: DeviceEvent,
-    ) {
-        println!("Device {device_id:?} event: {event:?}");
-    }
-
-    fn resumed(&mut self, event_loop: &ActiveEventLoop) {
-        println!("Resumed the event loop");
-        self.dump_monitors(event_loop);
-
-        // Create initial window.
-        self.create_window(event_loop, None)
-            .expect("failed to create initial window");
-
-        self.print_help();
-    }
-
-    fn about_to_wait(&mut self, event_loop: &ActiveEventLoop) {
-        if self.windows.is_empty() {
-            println!("No windows left, exiting...");
-            event_loop.exit();
-        }
-    }
-
-    #[cfg(not(any(android_platform, ios_platform)))]
-    fn exiting(&mut self, _event_loop: &ActiveEventLoop) {
-        // We must drop the context here.
-        self.context = None;
-    }
-}
-
-/// State of the window.
-struct WindowState {
-    /// IME input.
-    ime: bool,
-    /// Render surface.
-    ///
-    /// NOTE: This surface must be dropped before the `Window`.
-    #[cfg(not(any(android_platform, ios_platform)))]
-    surface: Surface,
-    /// The actual winit Window.
-    window: Window,
-    /// The window theme we're drawing with.
-    theme: Theme,
-    /// Cursor position over the window.
-    cursor_position: Option<PhysicalPosition<f64>>,
-    /// Window modifiers state.
-    modifiers: ModifiersState,
-    /// Occlusion state of the window.
-    occluded: bool,
-    /// Current cursor grab mode.
-    cursor_grab: CursorGrabMode,
-    /// The amount of zoom into window.
-    zoom: f64,
-    /// The amount of rotation of the window.
-    rotated: f32,
-
-    #[cfg(macos_platform)]
-    option_as_alt: OptionAsAlt,
-
-    // Cursor states.
-    named_idx: usize,
-    custom_idx: usize,
-    cursor_hidden: bool,
-}
-
-impl WindowState {
-    fn new(app: &Application, window: Window) -> Result<Self, Box<dyn Error>> {
-        // SAFETY: the surface is dropped before the `window` which provided it with handle, thus
-        // it doesn't outlive it.
-        #[cfg(not(any(android_platform, ios_platform)))]
-        let surface = unsafe { Surface::new(app.context.as_ref().unwrap(), &window)? };
-
-        let theme = window.theme().unwrap_or(Theme::Dark);
-        println!("Theme: {theme:?}");
-        let named_idx = 0;
-        window.set_cursor(CURSORS[named_idx]);
-
-        // Allow IME out of the box.
-        let ime = true;
-        window.set_ime_allowed(ime);
-
-        let size = window.inner_size();
-        let mut state = Self {
-            #[cfg(macos_platform)]
-            option_as_alt: window.option_as_alt(),
-            custom_idx: app.custom_cursors.len() - 1,
-            cursor_grab: CursorGrabMode::None,
-            named_idx,
-            #[cfg(not(any(android_platform, ios_platform)))]
-            surface,
-            window,
-            theme,
-            ime,
-            cursor_position: Default::default(),
-            cursor_hidden: Default::default(),
-            modifiers: Default::default(),
-            occluded: Default::default(),
-            rotated: Default::default(),
-            zoom: Default::default(),
-        };
-
-        state.resize(size);
-        Ok(state)
-    }
-
-    pub fn toggle_ime(&mut self) {
-        self.ime = !self.ime;
-        self.window.set_ime_allowed(self.ime);
-        if let Some(position) = self.ime.then_some(self.cursor_position).flatten() {
-            self.window
-                .set_ime_cursor_area(position, PhysicalSize::new(20, 20));
-        }
-    }
-
-    pub fn minimize(&mut self) {
-        self.window.set_minimized(true);
-    }
-
-    pub fn cursor_moved(&mut self, position: PhysicalPosition<f64>) {
-        self.cursor_position = Some(position);
-        if self.ime {
-            self.window
-                .set_ime_cursor_area(position, PhysicalSize::new(20, 20));
-        }
-    }
-
-    pub fn cursor_left(&mut self) {
-        self.cursor_position = None;
-    }
-
-    /// Toggle maximized.
-    fn toggle_maximize(&self) {
-        let maximized = self.window.is_maximized();
-        self.window.set_maximized(!maximized);
-    }
-
-    /// Toggle window decorations.
-    fn toggle_decorations(&self) {
-        let decorated = self.window.is_decorated();
-        self.window.set_decorations(!decorated);
-    }
-
-    /// Toggle window resizable state.
-    fn toggle_resizable(&self) {
-        let resizable = self.window.is_resizable();
-        self.window.set_resizable(!resizable);
-    }
-
-    /// Toggle cursor visibility
-    fn toggle_cursor_visibility(&mut self) {
-        self.cursor_hidden = !self.cursor_hidden;
-        self.window.set_cursor_visible(!self.cursor_hidden);
-    }
-
-    /// Toggle resize increments on a window.
-    fn toggle_resize_increments(&mut self) {
-        let new_increments = match self.window.resize_increments() {
-            Some(_) => None,
-            None => Some(LogicalSize::new(25.0, 25.0)),
-        };
-        println!("Had increments: {}", new_increments.is_none());
-        self.window.set_resize_increments(new_increments);
-    }
-
-    /// Toggle fullscreen.
-    fn toggle_fullscreen(&self) {
-        let fullscreen = if self.window.fullscreen().is_some() {
-            None
-        } else {
-            Some(Fullscreen::Borderless(None))
-        };
-
-        self.window.set_fullscreen(fullscreen);
-    }
-
-    /// Cycle through the grab modes ignoring errors.
-    fn cycle_cursor_grab(&mut self) {
-        self.cursor_grab = match self.cursor_grab {
-            CursorGrabMode::None => CursorGrabMode::Confined,
-            CursorGrabMode::Confined => CursorGrabMode::Locked,
-            CursorGrabMode::Locked => CursorGrabMode::None,
-        };
-        println!("Changing cursor grab mode to {:?}", self.cursor_grab);
-        if let Err(err) = self.window.set_cursor_grab(self.cursor_grab) {
-            eprintln!("Error setting cursor grab: {err}");
-        }
-    }
-
-    #[cfg(macos_platform)]
-    fn cycle_option_as_alt(&mut self) {
-        self.option_as_alt = match self.option_as_alt {
-            OptionAsAlt::None => OptionAsAlt::OnlyLeft,
-            OptionAsAlt::OnlyLeft => OptionAsAlt::OnlyRight,
-            OptionAsAlt::OnlyRight => OptionAsAlt::Both,
-            OptionAsAlt::Both => OptionAsAlt::None,
-        };
-        println!("Setting option as alt {:?}", self.option_as_alt);
-        self.window.set_option_as_alt(self.option_as_alt);
-    }
-
-    /// Pick the next cursor.
-    fn next_cursor(&mut self) {
-        self.named_idx = (self.named_idx + 1) % CURSORS.len();
-        println!("Setting cursor to \"{:?}\"", CURSORS[self.named_idx]);
-        self.window
-            .set_cursor(Cursor::Icon(CURSORS[self.named_idx]));
-    }
-
-    /// Pick the next custom cursor.
-    fn next_custom_cursor(&mut self, custom_cursors: &[CustomCursor]) {
-        self.custom_idx = (self.custom_idx + 1) % custom_cursors.len();
-        let cursor = Cursor::Custom(custom_cursors[self.custom_idx].clone());
-        self.window.set_cursor(cursor);
-    }
-
-    /// Resize the window to the new size.
-    fn resize(&mut self, _size: PhysicalSize<u32>) {
-        #[cfg(not(any(android_platform, ios_platform)))]
-        {
-            let (width, height) =
-                match (NonZeroU32::new(_size.width), NonZeroU32::new(_size.height)) {
-                    (Some(width), Some(height)) => (width, height),
-                    _ => return,
-                };
-            self.surface
-                .resize(width, height)
-                .expect("failed to resize inner buffer");
-        }
-        self.window.request_redraw();
-    }
-
-    /// Change the theme.
-    fn set_theme(&mut self, theme: Theme) {
-        self.theme = theme;
-        self.window.request_redraw();
-    }
-
-    /// Show window menu.
-    fn show_menu(&self) {
-        if let Some(position) = self.cursor_position {
-            self.window.show_window_menu(position);
-        }
-    }
-
-    /// Drag the window.
-    fn drag_window(&self) {
-        if let Err(err) = self.window.drag_window() {
-            println!("Error starting window drag: {err}");
-        } else {
-            println!("Dragging window Window={:?}", self.window.id());
-        }
-    }
-
-    /// Drag-resize the window.
-    fn drag_resize_window(&self) {
-        let position = match self.cursor_position {
-            Some(position) => position,
-            None => {
-                println!("Drag-resize requires cursor to be inside the window");
-                return;
-            }
-        };
-
-        let win_size = self.window.inner_size();
-        let border_size = BORDER_SIZE * self.window.scale_factor();
-
-        let x_direction = if position.x < border_size {
-            ResizeDirection::West
-        } else if position.x > (win_size.width as f64 - border_size) {
-            ResizeDirection::East
-        } else {
-            // Use arbitrary direction instead of None for simplicity.
-            ResizeDirection::SouthEast
-        };
-
-        let y_direction = if position.y < border_size {
-            ResizeDirection::North
-        } else if position.y > (win_size.height as f64 - border_size) {
-            ResizeDirection::South
-        } else {
-            // Use arbitrary direction instead of None for simplicity.
-            ResizeDirection::SouthEast
-        };
-
-        let direction = match (x_direction, y_direction) {
-            (ResizeDirection::West, ResizeDirection::North) => ResizeDirection::NorthWest,
-            (ResizeDirection::West, ResizeDirection::South) => ResizeDirection::SouthWest,
-            (ResizeDirection::West, _) => ResizeDirection::West,
-            (ResizeDirection::East, ResizeDirection::North) => ResizeDirection::NorthEast,
-            (ResizeDirection::East, ResizeDirection::South) => ResizeDirection::SouthEast,
-            (ResizeDirection::East, _) => ResizeDirection::East,
-            (_, ResizeDirection::South) => ResizeDirection::South,
-            (_, ResizeDirection::North) => ResizeDirection::North,
-            _ => return,
-        };
-
-        if let Err(err) = self.window.drag_resize_window(direction) {
-            println!("Error starting window drag-resize: {err}");
-        } else {
-            println!("Drag-resizing window Window={:?}", self.window.id());
-        }
-    }
-
-    /// Change window occlusion state.
-    fn set_occluded(&mut self, occluded: bool) {
-        self.occluded = occluded;
-        if !occluded {
-            self.window.request_redraw();
-        }
-    }
-
-    /// Draw the window contents.
-    #[cfg(not(any(android_platform, ios_platform)))]
-    fn draw(&mut self) -> Result<(), Box<dyn Error>> {
-        if self.occluded {
-            println!("Skipping drawing occluded window={:?}", self.window.id());
-            return Ok(());
-        }
-
-        const WHITE: u32 = 0xFFFFFFFF;
-        const DARK_GRAY: u32 = 0xFF181818;
-
-        let color = match self.theme {
-            Theme::Light => WHITE,
-            Theme::Dark => DARK_GRAY,
-        };
-
-        let mut buffer = self.surface.buffer_mut()?;
-        buffer.fill(color);
-        self.window.pre_present_notify();
-        buffer.present()?;
-        Ok(())
-    }
-
-    #[cfg(any(android_platform, ios_platform))]
-    fn draw(&mut self) -> Result<(), Box<dyn Error>> {
-        println!("Drawing but without rendering...");
-        Ok(())
-    }
-}
-
-struct Binding<T: Eq> {
-    trigger: T,
-    mods: ModifiersState,
-    action: Action,
-}
-
-impl<T: Eq> Binding<T> {
-    const fn new(trigger: T, mods: ModifiersState, action: Action) -> Self {
-        Self {
-            trigger,
-            mods,
-            action,
-        }
-    }
-
-    fn is_triggered_by(&self, trigger: &T, mods: &ModifiersState) -> bool {
-        &self.trigger == trigger && &self.mods == mods
-    }
-}
-
-#[derive(Debug, Clone, Copy, PartialEq, Eq)]
-enum Action {
-    CloseWindow,
-    ToggleCursorVisibility,
-    CreateNewWindow,
-    ToggleResizeIncrements,
-    ToggleImeInput,
-    ToggleDecorations,
-    ToggleResizable,
-    ToggleFullscreen,
-    ToggleMaximize,
-    Minimize,
-    NextCursor,
-    NextCustomCursor,
-    CycleCursorGrab,
-    PrintHelp,
-    DragWindow,
-    DragResizeWindow,
-    ShowWindowMenu,
-    #[cfg(macos_platform)]
-    CycleOptionAsAlt,
-    #[cfg(macos_platform)]
-    CreateNewTab,
-}
-
-impl Action {
-    fn help(&self) -> &'static str {
-        match self {
-            Action::CloseWindow => "Close window",
-            Action::ToggleCursorVisibility => "Hide cursor",
-            Action::CreateNewWindow => "Create new window",
-            Action::ToggleImeInput => "Toggle IME input",
-            Action::ToggleDecorations => "Toggle decorations",
-            Action::ToggleResizable => "Toggle window resizable state",
-            Action::ToggleFullscreen => "Toggle fullscreen",
-            Action::ToggleMaximize => "Maximize",
-            Action::Minimize => "Minimize",
-            Action::ToggleResizeIncrements => "Use resize increments when resizing window",
-            Action::NextCursor => "Advance the cursor to the next value",
-            Action::NextCustomCursor => "Advance custom cursor to the next value",
-            Action::CycleCursorGrab => "Cycle through cursor grab mode",
-            Action::PrintHelp => "Print help",
-            Action::DragWindow => "Start window drag",
-            Action::DragResizeWindow => "Start window drag-resize",
-            Action::ShowWindowMenu => "Show window menu",
-            #[cfg(macos_platform)]
-            Action::CycleOptionAsAlt => "Cycle option as alt mode",
-            #[cfg(macos_platform)]
-            Action::CreateNewTab => "Create new tab",
-        }
-    }
-}
-
-impl fmt::Display for Action {
-    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
-        Debug::fmt(&self, f)
-    }
-}
-
-fn decode_cursor(bytes: &[u8]) -> CustomCursorSource {
-    let img = image::load_from_memory(bytes).unwrap().to_rgba8();
-    let samples = img.into_flat_samples();
-    let (_, w, h) = samples.extents();
-    let (w, h) = (w as u16, h as u16);
-    CustomCursor::from_rgba(samples.samples, w, h, w / 2, h / 2).unwrap()
-}
-
-fn load_icon(path: &Path) -> Icon {
-    let (icon_rgba, icon_width, icon_height) = {
-        let image = image::open(path)
-            .expect("Failed to open icon path")
-            .into_rgba8();
-        let (width, height) = image.dimensions();
-        let rgba = image.into_raw();
-        (rgba, width, height)
-    };
-    Icon::from_rgba(icon_rgba, icon_width, icon_height).expect("Failed to open icon")
-}
-
-fn modifiers_to_string(mods: ModifiersState) -> String {
-    let mut mods_line = String::new();
-    // Always add + since it's printed as a part of the bindings.
-    for (modifier, desc) in [
-        (ModifiersState::SUPER, "Super+"),
-        (ModifiersState::ALT, "Alt+"),
-        (ModifiersState::CONTROL, "Ctrl+"),
-        (ModifiersState::SHIFT, "Shift+"),
-    ] {
-        if !mods.contains(modifier) {
-            continue;
-        }
-
-        mods_line.push_str(desc);
-    }
-    mods_line
-}
-
-fn mouse_button_to_string(button: MouseButton) -> &'static str {
-    match button {
-        MouseButton::Left => "LMB",
-        MouseButton::Right => "RMB",
-        MouseButton::Middle => "MMB",
-        MouseButton::Back => "Back",
-        MouseButton::Forward => "Forward",
-        MouseButton::Other(_) => "",
-    }
-}
-
-/// Cursor list to cycle through.
-const CURSORS: &[CursorIcon] = &[
-    CursorIcon::Default,
-    CursorIcon::Crosshair,
-    CursorIcon::Pointer,
-    CursorIcon::Move,
-    CursorIcon::Text,
-    CursorIcon::Wait,
-    CursorIcon::Help,
-    CursorIcon::Progress,
-    CursorIcon::NotAllowed,
-    CursorIcon::ContextMenu,
-    CursorIcon::Cell,
-    CursorIcon::VerticalText,
-    CursorIcon::Alias,
-    CursorIcon::Copy,
-    CursorIcon::NoDrop,
-    CursorIcon::Grab,
-    CursorIcon::Grabbing,
-    CursorIcon::AllScroll,
-    CursorIcon::ZoomIn,
-    CursorIcon::ZoomOut,
-    CursorIcon::EResize,
-    CursorIcon::NResize,
-    CursorIcon::NeResize,
-    CursorIcon::NwResize,
-    CursorIcon::SResize,
-    CursorIcon::SeResize,
-    CursorIcon::SwResize,
-    CursorIcon::WResize,
-    CursorIcon::EwResize,
-    CursorIcon::NsResize,
-    CursorIcon::NeswResize,
-    CursorIcon::NwseResize,
-    CursorIcon::ColResize,
-    CursorIcon::RowResize,
-];
-
-const KEY_BINDINGS: &[Binding<&'static str>] = &[
-    Binding::new("Q", ModifiersState::CONTROL, Action::CloseWindow),
-    Binding::new("H", ModifiersState::CONTROL, Action::PrintHelp),
-    Binding::new("F", ModifiersState::CONTROL, Action::ToggleFullscreen),
-    Binding::new("D", ModifiersState::CONTROL, Action::ToggleDecorations),
-    Binding::new("I", ModifiersState::CONTROL, Action::ToggleImeInput),
-    Binding::new("L", ModifiersState::CONTROL, Action::CycleCursorGrab),
-    Binding::new("P", ModifiersState::CONTROL, Action::ToggleResizeIncrements),
-    Binding::new("R", ModifiersState::CONTROL, Action::ToggleResizable),
-    // M.
-    Binding::new("M", ModifiersState::CONTROL, Action::ToggleMaximize),
-    Binding::new("M", ModifiersState::ALT, Action::Minimize),
-    // N.
-    Binding::new("N", ModifiersState::CONTROL, Action::CreateNewWindow),
-    // C.
-    Binding::new("C", ModifiersState::CONTROL, Action::NextCursor),
-    Binding::new("C", ModifiersState::ALT, Action::NextCustomCursor),
-    Binding::new("Z", ModifiersState::CONTROL, Action::ToggleCursorVisibility),
-    #[cfg(macos_platform)]
-    Binding::new("T", ModifiersState::SUPER, Action::CreateNewTab),
-    #[cfg(macos_platform)]
-    Binding::new("O", ModifiersState::CONTROL, Action::CycleOptionAsAlt),
-];
-
-const MOUSE_BINDINGS: &[Binding<MouseButton>] = &[
-    Binding::new(
-        MouseButton::Left,
-        ModifiersState::ALT,
-        Action::DragResizeWindow,
-    ),
-    Binding::new(
-        MouseButton::Left,
-        ModifiersState::CONTROL,
-        Action::DragWindow,
-    ),
-    Binding::new(
-        MouseButton::Right,
-        ModifiersState::CONTROL,
-        Action::ShowWindowMenu,
-    ),
-];

examples/x11_embed.rs

@@ -3,37 +3,40 @@ use std::error::Error;
 
 #[cfg(x11_platform)]
 fn main() -> Result<(), Box<dyn Error>> {
-    use winit::application::ApplicationHandler;
+    use simple_logger::SimpleLogger;
-    use winit::event::WindowEvent;
+
-    use winit::event_loop::{ActiveEventLoop, EventLoop};
+    use winit::{
-    use winit::platform::x11::WindowAttributesExtX11;
+        event::{Event, WindowEvent},
-    use winit::window::{Window, WindowId};
+        event_loop::EventLoop,
+        platform::x11::WindowAttributesExtX11,
+        window::Window,
+    };
 
     #[path = "util/fill.rs"]
     mod fill;
 
-    pub struct XEmbedDemo {
+    // First argument should be a 32-bit X11 window ID.
-        parent_window_id: u32,
+    let parent_window_id = std::env::args()
-        window: Option<Window>,
+        .nth(1)
-    }
+        .ok_or("Expected a 32-bit X11 window ID as the first argument.")?
+        .parse::<u32>()?;
 
-    impl ApplicationHandler for XEmbedDemo {
+    SimpleLogger::new().init().unwrap();
-        fn resumed(&mut self, event_loop: &ActiveEventLoop) {
+    let event_loop = EventLoop::new()?;
+
+    let mut window = None;
+    event_loop.run(move |event, event_loop| match event {
+        Event::Resumed => {
             let window_attributes = Window::default_attributes()
                 .with_title("An embedded window!")
                 .with_inner_size(winit::dpi::LogicalSize::new(128.0, 128.0))
-                .with_embed_parent_window(self.parent_window_id);
+                .with_embed_parent_window(parent_window_id);
 
-            self.window = Some(event_loop.create_window(window_attributes).unwrap());
+            window = Some(event_loop.create_window(window_attributes).unwrap());
         }
+        Event::WindowEvent { event, .. } => {
+            let window = window.as_ref().unwrap();
 
-        fn window_event(
-            &mut self,
-            event_loop: &ActiveEventLoop,
-            _window_id: WindowId,
-            event: WindowEvent,
-        ) {
-            let window = self.window.as_ref().unwrap();
             match event {
                 WindowEvent::CloseRequested => event_loop.exit(),
                 WindowEvent::RedrawRequested => {
@@ -43,26 +46,13 @@ fn main() -> Result<(), Box<dyn Error>> {
                 _ => (),
             }
         }
-
+        Event::AboutToWait => {
-        fn about_to_wait(&mut self, _event_loop: &ActiveEventLoop) {
+            window.as_ref().unwrap().request_redraw();
-            self.window.as_ref().unwrap().request_redraw();
         }
-    }
+        _ => (),
+    })?;
 
-    // First argument should be a 32-bit X11 window ID.
+    Ok(())
-    let parent_window_id = std::env::args()
-        .nth(1)
-        .ok_or("Expected a 32-bit X11 window ID as the first argument.")?
-        .parse::<u32>()?;
-
-    tracing_subscriber::fmt::init();
-    let event_loop = EventLoop::new()?;
-
-    let mut app = XEmbedDemo {
-        parent_window_id,
-        window: None,
-    };
-    event_loop.run_app(&mut app).map_err(Into::into)
 }
 
 #[cfg(not(x11_platform))]

it/common-tests/Cargo.toml

@@ -1,12 +0,0 @@
-[package]
-name = "common-tests"
-version = "0.1.0"
-rust-version.workspace = true
-repository.workspace = true
-license.workspace = true
-edition.workspace = true
-
-[dependencies]
-gui-test.workspace = true
-macro_rules_attribute = "0.2.0"
-winit.workspace = true

it/common-tests/src/main.rs

@@ -1,23 +0,0 @@
-//! Run the test.
-
-use gui_test::{test, Harness};
-use macro_rules_attribute::apply;
-
-use winit::event_loop::EventLoop;
-
-#[allow(deprecated)]
-#[apply(test)]
-fn initialize(harness: &mut Harness) {
-    let mut group = harness.group("sanity");
-    group.harness().with_test("startup/shutdown", || {
-        let evl = EventLoop::new().expect("initialization");
-        evl.run(|_event, elwt| {
-            elwt.exit();
-        })
-        .expect("running");
-    });
-}
-
-gui_test::main! {
-    gui_test::remote::handler()
-}

it/gui-test-runner/Cargo.toml

@@ -1,13 +0,0 @@
-[package]
-name = "gui-test-runner"
-version = "0.1.0"
-rust-version.workspace = true
-repository.workspace = true
-license.workspace = true
-edition.workspace = true
-
-[dependencies]
-camino = "1.1.6"
-fastrand = "2.0.1"
-gui-test.workspace = true
-serde_json.workspace = true

it/gui-test-runner/src/command.rs

@@ -1,81 +0,0 @@
-// Copyright 2024 The Winit Contributors
-//
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-//     http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-
-//! A wrapper around the `Command` type that dumps the command to stderr.
-//!
-//! Essentially it's like `set -x` in Bash.
-
-use std::ffi::{OsStr, OsString};
-use std::io::{self, prelude::*};
-use std::process::Child;
-
-/// Simple `Command` wrapper.
-pub(super) struct Command {
-    /// Actual inner command.
-    inner: std::process::Command,
-
-    /// Command to run.
-    text: Vec<OsString>,
-}
-
-impl Command {
-    /// Create a new `Command`.
-    pub(super) fn new(cmd: impl AsRef<OsStr>) -> Self {
-        let cmd = cmd.as_ref();
-        Self {
-            inner: std::process::Command::new(cmd),
-            text: vec![cmd.to_os_string()],
-        }
-    }
-
-    /// Add an argument to the `Command`.
-    pub(super) fn arg(&mut self, arg: impl AsRef<OsStr>) -> &mut Self {
-        let arg = arg.as_ref();
-        self.inner.arg(arg);
-        self.text.push(arg.to_os_string());
-        self
-    }
-
-    /// Add multiple arguments to the `Command`.
-    pub(super) fn args<T: AsRef<OsStr>>(&mut self, args: impl IntoIterator<Item = T>) -> &mut Self {
-        for arg in args {
-            let arg = arg.as_ref();
-            self.inner.arg(arg);
-            self.text.push(arg.to_os_string());
-        }
-
-        self
-    }
-
-    /// Spawn the process.
-    pub(super) fn spawn(&mut self) -> io::Result<Child> {
-        dump_text(&self.text);
-        self.inner.spawn()
-    }
-}
-
-/// Dump `OsString` list to stderr.
-fn dump_text(text: &[OsString]) {
-    let mut cerr = io::stderr().lock();
-    write!(&mut cerr, "+").unwrap();
-
-    for arg in text {
-        match arg.to_str() {
-            Some(arg) => write!(&mut cerr, " {}", arg).unwrap(),
-            None => write!(&mut cerr, " {:?}", arg).unwrap(),
-        }
-    }
-
-    writeln!(&mut cerr).unwrap();
-}

it/gui-test-runner/src/docker/command.rs

@@ -1,91 +0,0 @@
-// Copyright 2024 The Winit Contributors
-//
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-//     http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-
-//! Run the actual Docker command.
-
-use crate::command::Command;
-
-use camino::Utf8Path;
-
-use std::ffi::OsStr;
-use std::io;
-use std::process::Child;
-
-/// The Docker command line.
-pub(super) struct DockerRun {
-    command: Command,
-}
-
-impl DockerRun {
-    /// Start the command.
-    pub(super) fn new() -> Self {
-        let mut command = Command::new("docker");
-        command.arg("run");
-
-        Self { command }
-    }
-
-    /// Run with an environment variable.
-    pub(super) fn env(&mut self, name: impl AsRef<str>, value: impl AsRef<str>) -> &mut Self {
-        let env_arg = format!("{}={}", name.as_ref(), value.as_ref());
-        self.command.args(["--env", &env_arg]);
-        self
-    }
-
-    /// Run with a simple `init` process.
-    pub(super) fn init(&mut self) -> &mut Self {
-        self.command.arg("--init");
-        self
-    }
-
-    /// Set the working directory.
-    pub(super) fn workdir(&mut self, dir: impl AsRef<OsStr>) -> &mut Self {
-        self.command.arg("--workdir");
-        self.command.arg(dir);
-        self
-    }
-
-    /// Remove the container once it is complete.
-    pub(super) fn rm(&mut self) -> &mut Self {
-        self.command.arg("--rm");
-        self
-    }
-
-    /// Pass a volume into the container.
-    pub(super) fn volume(
-        &mut self,
-        host: impl AsRef<Utf8Path>,
-        container: impl AsRef<Utf8Path>,
-    ) -> &mut Self {
-        let list = format!("{}:{}", host.as_ref(), container.as_ref());
-        self.command.args(["--volume", &list]);
-        self
-    }
-
-    /// Run the container with a command.
-    pub(super) fn run_with_command<T: AsRef<OsStr>>(
-        &mut self,
-        container_name: impl AsRef<str>,
-        container_version: impl AsRef<str>,
-        command: impl IntoIterator<Item = T>,
-    ) -> io::Result<Child> {
-        self.command.arg(format!(
-            "{}:{}",
-            container_name.as_ref(),
-            container_version.as_ref()
-        ));
-        self.command.args(command);
-        self.command.spawn()
-    }
-}

it/gui-test-runner/src/docker/linux.rs

@@ -1,114 +0,0 @@
-// Copyright 2024 The Winit Contributors
-//
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-//     http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-
-//! Run tests inside of a Linux docker container.
-
-use super::command::DockerRun;
-use crate::stream::StreamReader;
-
-use gui_test::remote::handler;
-use gui_test::TestHandler;
-
-use std::io;
-use std::os::unix::net::UnixListener;
-use std::path::Path;
-use std::thread;
-
-const UBUNTU_DOCKERFILE: &str = "ghcr.io/rust-windowing/testubuntu";
-const LATEST: &str = "latest";
-
-/// Run the provided test in a Linux docker container.
-pub(crate) fn linux_test(test_name: &str) -> io::Result<()> {
-    // Create a Unix socket to listen for events on.
-    let unix_path = format!("/tmp/gui_test_{}.sock", fastrand::u16(..));
-    let listener = UnixListener::bind(&unix_path)?;
-
-    // Spawn the Docker container.
-    let mut container = {
-        let mut docker = DockerRun::new();
-
-        // Usual options.
-        docker.rm().init();
-
-        // Pass through the socket as a volume.
-        docker.volume(&unix_path, &unix_path);
-
-        // Pass through the winit directory.
-        let winit_directory = Path::new(env!("CARGO_MANIFEST_DIR"))
-            .ancestors()
-            .find_map(|path| {
-                let cargo_toml = path.join("Cargo.toml");
-                let contents = std::fs::read(cargo_toml).ok()?;
-
-                if std::str::from_utf8(&contents)
-                    .ok()?
-                    .contains("name = \"winit\"")
-                {
-                    Some(path)
-                } else {
-                    None
-                }
-            })
-            .unwrap();
-        docker.volume(
-            camino::Utf8Path::from_path(winit_directory).unwrap(),
-            "/app/winit/",
-        );
-
-        // Set the working dir to this directory.
-        docker.workdir("/app/winit/");
-
-        // Set GUI_TEST_UNIX_STREAM to the socket.
-        docker.env("GUI_TEST_UNIX_STREAM", &unix_path);
-
-        // Set CARGO_TARGET_DIR to a random other directory.
-        docker.env("CARGO_TARGET_DIR", "/tmp/");
-
-        // The command to run the test.
-        let command = ["xvfb-run", "cargo", "run", "-p", test_name];
-
-        // Spawn the test container.
-        docker.run_with_command(UBUNTU_DOCKERFILE, LATEST, command)?
-    };
-
-    // Run the console listener in another thread.
-    let handle = thread::spawn(move || {
-        // Attach to the listener.
-        let (event_reader, _) = listener.accept().unwrap();
-
-        // Read events and output them as we get them.
-        let input = StreamReader::new(event_reader);
-        let mut output = handler();
-
-        for event in input {
-            let event = event?;
-            output.handle_test(event);
-        }
-
-        io::Result::Ok(())
-    });
-
-    // Wait for the container to finish.
-    if !container.wait()?.success() {
-        return Err(io::Error::new(
-            io::ErrorKind::Other,
-            "docker exited with a failure exit code",
-        ));
-    }
-
-    // Stop the thread.
-    handle.join().unwrap().unwrap();
-
-    Ok(())
-}

it/gui-test-runner/src/docker/mod.rs

@@ -1,20 +0,0 @@
-// Copyright 2024 The Winit Contributors
-//
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-//     http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-
-//! Dealing with Docker.
-
-mod command;
-
-#[cfg(unix)]
-pub(super) mod linux;

it/gui-test-runner/src/main.rs

@@ -1,69 +0,0 @@
-//! Runner for the `gui-test` system.
-
-mod command;
-mod docker;
-mod stream;
-
-use std::env;
-use std::process::{Command, Stdio};
-
-fn main() {
-    let mut args = env::args();
-
-    // Get the test crate name.
-    let test_crate = args.nth(1).unwrap();
-
-    // Get the target.
-    let target_tag = args.next().unwrap();
-
-    // Split the target into the target and the tag.
-    let (target, tag) = {
-        let mut split = target_tag.splitn(1, ':');
-        let target = split.next().unwrap();
-        let tag = split.next();
-        (target, tag)
-    };
-
-    // Get the current target.
-    let current_target = current_target();
-
-    // If we are building for Linux, run the Linux Docker container.
-    // TODO: Architecture differences.
-    if target.contains("linux") {
-        docker::linux::linux_test(&test_crate).unwrap();
-        return;
-    }
-
-    // For now, we only support building for the current target.
-    assert_eq!(target, current_target);
-    assert!(tag.is_none());
-
-    // Just run the crate.
-    if !Command::new("cargo")
-        .args(["run", "-p", &test_crate])
-        .status()
-        .unwrap()
-        .success()
-    {
-        panic!("test failed");
-    }
-}
-
-/// Get the current target.
-fn current_target() -> String {
-    let output = Command::new("rustc")
-        .arg("-vV")
-        .stdout(Stdio::piped())
-        .output()
-        .unwrap();
-
-    // Look for the line that starts with "host".
-    let stdout = String::from_utf8(output.stdout).unwrap();
-    for line in stdout.lines() {
-        if let Some(host) = line.strip_prefix("host: ") {
-            return host.to_string();
-        }
-    }
-
-    panic!("failed to find host: line in rustc output")
-}

it/gui-test-runner/src/stream.rs

@@ -1,81 +0,0 @@
-// Copyright 2024 The Winit Contributors
-//
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-//     http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-
-//! Read test events from a stream.
-
-use gui_test::{TestEvent, TestEventType};
-use std::io::{self, Read};
-
-/// Read events from a stream.
-pub(super) struct StreamReader<R> {
-    /// The inner reader.
-    reader: Option<R>,
-
-    /// Reused buffer.
-    buffer: Vec<u8>,
-}
-
-impl<R: Read> StreamReader<R> {
-    /// Create a new stream reader.
-    pub(super) fn new(reader: R) -> Self {
-        Self {
-            reader: Some(reader),
-            buffer: vec![0u8; 1024],
-        }
-    }
-}
-
-macro_rules! leap {
-    ($self:expr, $e:expr) => {{
-        match ($e) {
-            Ok(x) => x,
-            Err(err) => {
-                ($self).reader = None;
-                return Some(Err(err));
-            }
-        }
-    }};
-}
-
-impl<R: Read> Iterator for StreamReader<R> {
-    type Item = io::Result<TestEvent>;
-
-    fn next(&mut self) -> Option<Self::Item> {
-        let reader = self.reader.as_mut()?;
-
-        // Read eight bytes from the reader to get payload length.
-        let mut len_buffer = [0u8; 8];
-        leap!(self, reader.read_exact(&mut len_buffer));
-
-        // Parse that, then read the length's worth of bytes.
-        let length = u64::from_be_bytes(len_buffer);
-        self.buffer.resize(length as usize, 0);
-        leap!(self, reader.read_exact(&mut self.buffer));
-
-        // Parse as a test event.
-        let event: TestEvent = leap!(
-            self,
-            serde_json::from_slice(&self.buffer)
-                .map_err(|err| io::Error::new(io::ErrorKind::Other, err))
-        );
-
-        // If this is complete, stop running.
-        if matches!(event.ty, TestEventType::Complete { .. }) {
-            self.reader = None;
-        }
-
-        // We are okay.
-        Some(Ok(event))
-    }
-}

it/gui-test/Cargo.toml

@@ -1,17 +0,0 @@
-[package]
-name = "gui-test"
-version = "0.1.0"
-rust-version.workspace = true
-repository.workspace = true
-license.workspace = true
-edition.workspace = true
-
-[dependencies]
-async-executor = "1.8.0"
-async-io.workspace = true
-async-lock = "3.3.0"
-async-process = "2.1.0"
-inventory = "0.3.15"
-owo-colors = "4.0.0"
-serde = { workspace = true, features = ["derive"] }
-serde_json.workspace = true

it/gui-test/src/lib.rs

@@ -1,443 +0,0 @@
-//! A testing framework that can be run remotely.
-
-pub mod remote;
-pub mod stream;
-pub mod user;
-
-use serde::{Deserialize, Serialize};
-
-use std::env;
-use std::ffi::{OsStr, OsString};
-use std::mem;
-use std::num::NonZeroUsize;
-use std::panic;
-
-const GUI_TEST_CURRENT_TEST_NAME: &str = "GUI_TEST_CURRENT_TEST_NAME";
-const GUI_TEST_SUBPROCESS_LIMIT: &str = "GUI_TEST_SUBPROCESS_LIMIT";
-const DEFAULT_LIMIT: usize = 1;
-
-#[doc(hidden)]
-pub use inventory as __inventory;
-
-/// Replacement for the `main` function.
-#[macro_export]
-macro_rules! main {
-    ($handler:expr) => {
-        fn main() {
-            $crate::__entry(|| $handler)
-        }
-    };
-}
-
-/// Set up a test for the test framework.
-#[macro_export]
-macro_rules! test {
-    (
-        $(#[$attr:meta])*
-        fn $name:ident ($hname:ident : $htype:ty) $bl:block
-    ) => {
-        const _: () = {
-            $(#[$attr])*
-            fn $name ($hname: $htype) $bl
-
-            $crate::__inventory::submit! {
-                $crate::__TestStart::__new(
-                    stringify!($name),
-                    $name
-                )
-            }
-        };
-    };
-}
-
-/// Test start.
-#[doc(hidden)]
-pub struct __TestStart {
-    /// The name of the test.
-    name: &'static str,
-
-    /// The function to call.
-    func: fn(&mut Harness),
-}
-
-impl __TestStart {
-    /// Create a new test start.
-    #[doc(hidden)]
-    pub const fn __new(name: &'static str, func: fn(&mut Harness)) -> Self {
-        Self { name, func }
-    }
-}
-
-inventory::collect! {
-    __TestStart
-}
-
-/// A harness for running the tests.
-pub struct Harness {
-    /// Name of the test start.
-    name: String,
-
-    /// The inner test handler.
-    handler: Box<dyn TestHandler + Send + 'static>,
-
-    /// Number of tests that have been run so far.
-    test_count: usize,
-
-    /// Number of tests that have failed so far.
-    test_fails: usize,
-
-    /// Number of tests that have succeeded.
-    test_passed: usize,
-
-    /// Current state of the test harness.
-    state: State,
-}
-
-impl Harness {
-    /// Create a new test harness.
-    fn new<H: TestHandler + Send + 'static>(name: &str, handler: H) -> Self {
-        Self {
-            name: name.to_string(),
-            handler: Box::new(handler),
-            test_count: 0,
-            test_fails: 0,
-            test_passed: 0,
-            state: State::Default,
-        }
-    }
-
-    /// Begin a test.
-    pub fn test(&mut self, name: impl Into<String>) -> Testing<'_> {
-        // Make sure we aren't mid test.
-        match mem::replace(&mut self.state, State::Default) {
-            State::InTest { past_groups } => {
-                self.state = State::InTest { past_groups };
-                panic!("tried to start a test while another was underway");
-            }
-
-            State::InGroups(groups) => {
-                self.state = State::InTest {
-                    past_groups: Some(groups),
-                };
-            }
-
-            State::Default => {
-                self.state = State::InTest { past_groups: None };
-            }
-        }
-
-        // Send the "test started" event to the handler.
-        self.send_event(TestEventType::TestStarted { name: name.into() });
-
-        // Return the handle.
-        Testing {
-            harness: Some(self),
-        }
-    }
-
-    /// Run a closure as a test.
-    pub fn with_test<T>(&mut self, name: impl Into<String>, f: impl FnOnce() -> T) -> T {
-        let test = self.test(name.into());
-        match panic::catch_unwind(panic::AssertUnwindSafe(f)) {
-            Ok(x) => x,
-
-            Err(err) => {
-                if let Some(panic) = err.downcast_ref::<&'static str>() {
-                    test.fail(panic.to_string());
-                } else if let Some(panic) = err.downcast_ref::<String>() {
-                    test.fail(panic.clone());
-                } else {
-                    test.fail("unintelligible error".to_string());
-                }
-
-                panic::resume_unwind(err)
-            }
-        }
-    }
-
-    /// Begin a test group.
-    pub fn group(&mut self, name: impl Into<String>) -> Grouping<'_> {
-        // Make sure we can begin a group.
-        match mem::replace(&mut self.state, State::Default) {
-            State::Default => {
-                self.state = State::InGroups(NonZeroUsize::new(1).unwrap());
-            }
-            State::InGroups(groups) => {
-                self.state = State::InGroups(groups.checked_add(1).unwrap());
-            }
-            State::InTest { past_groups } => {
-                self.state = State::InTest { past_groups };
-                panic!("cannot start group mid-test")
-            }
-        }
-
-        // Send the "group started" event to the handler.
-        self.send_event(TestEventType::GroupStarted { name: name.into() });
-
-        // Return the handle.
-        Grouping { harness: self }
-    }
-
-    /// Run a closure inside of a group.
-    pub fn with_group<T>(&mut self, name: impl Into<String>, f: impl FnOnce(&mut Self) -> T) -> T {
-        let mut group = self.group(name.into());
-        f(group.harness())
-    }
-
-    /// End an ongoing test.
-    fn end_test(&mut self, reason: TestResult) {
-        self.test_count += 1;
-        match &reason {
-            TestResult::Passed => self.test_passed += 1,
-            TestResult::Failed(..) => self.test_fails += 1,
-            _ => {}
-        }
-
-        self.send_event(TestEventType::TestEnded { result: reason });
-
-        let count = match mem::replace(&mut self.state, State::Default) {
-            State::InTest { past_groups } => past_groups,
-            _ => unreachable!(),
-        };
-
-        self.state = match count {
-            None => State::Default,
-            Some(count) => State::InGroups(count),
-        };
-    }
-
-    /// End the current group.
-    fn end_group(&mut self) {
-        self.send_event(TestEventType::GroupEnded);
-
-        let count = match mem::replace(&mut self.state, State::Default) {
-            State::InGroups(groups) => groups,
-            _ => unreachable!(),
-        };
-
-        self.state = match NonZeroUsize::new(count.get() - 1) {
-            None => State::Default,
-            Some(groups) => State::InGroups(groups),
-        };
-    }
-
-    /// Send a test event of the provided type.
-    fn send_event(&mut self, ty: TestEventType) {
-        let event = TestEvent {
-            runner: self.name.clone(),
-            ty,
-        };
-
-        self.handler.handle_test(event);
-    }
-}
-
-impl Drop for Harness {
-    fn drop(&mut self) {
-        self.send_event(TestEventType::Complete {
-            total: self.test_count,
-            fail: self.test_fails,
-            pass: self.test_passed,
-        });
-    }
-}
-
-/// An in-progress test.
-pub struct Testing<'a> {
-    harness: Option<&'a mut Harness>,
-}
-
-impl Testing<'_> {
-    /// Skip this test.
-    pub fn skip(mut self) {
-        // Send the "skipped" event.
-        self.harness.take().unwrap().end_test(TestResult::Skipped);
-    }
-
-    /// Fail this test.
-    fn fail(mut self, panic: String) {
-        self.harness
-            .take()
-            .unwrap()
-            .end_test(TestResult::Failed(panic));
-    }
-}
-
-impl Drop for Testing<'_> {
-    fn drop(&mut self) {
-        if let Some(harness) = self.harness.take() {
-            let result = if std::thread::panicking() {
-                TestResult::Failed("thread panicked".into())
-            } else {
-                TestResult::Passed
-            };
-
-            harness.end_test(result);
-        }
-    }
-}
-
-/// We are running a test group.
-pub struct Grouping<'a> {
-    harness: &'a mut Harness,
-}
-
-impl Grouping<'_> {
-    /// Get the underlying test harness.
-    pub fn harness(&mut self) -> &mut Harness {
-        &mut self.harness
-    }
-}
-
-impl Drop for Grouping<'_> {
-    fn drop(&mut self) {
-        self.harness.end_group();
-    }
-}
-
-/// Current testing state.
-enum State {
-    /// We are in the middle of this many groups.
-    InGroups(NonZeroUsize),
-
-    /// We are in the middle of a test.
-    InTest { past_groups: Option<NonZeroUsize> },
-
-    /// We are in the default state.
-    Default,
-}
-
-/// A handler for incoming test events.
-pub trait TestHandler {
-    /// Handle a test.
-    fn handle_test(&mut self, event: TestEvent);
-}
-
-impl<T: TestHandler + ?Sized> TestHandler for Box<T> {
-    fn handle_test(&mut self, event: TestEvent) {
-        (**self).handle_test(event)
-    }
-}
-
-/// An event produced by the test harness.
-#[derive(Debug, Serialize, Deserialize)]
-pub struct TestEvent {
-    /// The name of the runner associated with the event.
-    pub runner: String,
-
-    /// The type of the event.
-    pub ty: TestEventType,
-}
-
-/// The type of the event.
-#[non_exhaustive]
-#[derive(Debug, Serialize, Deserialize)]
-pub enum TestEventType {
-    /// The tests are complete and the harness can be disconnected.
-    Complete {
-        /// Total number of tests.
-        total: usize,
-
-        /// Total number of passing tests.
-        pass: usize,
-
-        /// Total number of failed tests.
-        fail: usize,
-    },
-
-    /// A test has started.
-    TestStarted { name: String },
-
-    /// A test has completed.
-    TestEnded { result: TestResult },
-
-    /// A test group has started.
-    GroupStarted { name: String },
-
-    /// A test group has ended.
-    GroupEnded,
-}
-
-/// The result of a test.
-#[non_exhaustive]
-#[derive(Debug, Serialize, Deserialize)]
-pub enum TestResult {
-    /// The test passed.
-    Passed,
-
-    /// The test failed with the provided error.
-    Failed(String),
-
-    /// The test was skipped.
-    Skipped,
-}
-
-/// Entry point of the test.
-#[doc(hidden)]
-pub fn __entry<H: TestHandler + Send + 'static>(handler: impl FnOnce() -> H) {
-    // Look for the test name environment variable.
-    if let Some(test_name) = env::var(GUI_TEST_CURRENT_TEST_NAME)
-        .ok()
-        .filter(|test_name| !test_name.is_empty())
-    {
-        // Find the provided test.
-        let test_to_run = inventory::iter::<__TestStart>
-            .into_iter()
-            .find(|test| test.name == test_name)
-            .unwrap_or_else(|| panic!("unable to find test '{test_name}'"));
-
-        // Create a harness.
-        let mut harness = Harness::new(test_to_run.name, handler());
-
-        // Run the test.
-        panic::catch_unwind(panic::AssertUnwindSafe(move || {
-            (test_to_run.func)(&mut harness)
-        }))
-        .ok();
-    } else {
-        // Run a subprocess for every test.
-        let limit = env::var(GUI_TEST_SUBPROCESS_LIMIT)
-            .ok()
-            .and_then(|limit| limit.parse::<usize>().ok())
-            .unwrap_or(DEFAULT_LIMIT);
-        let process_name = env::args_os().next().unwrap();
-
-        let sema = async_lock::Semaphore::new(limit);
-        let ex = async_executor::Executor::new();
-
-        async_io::block_on(ex.run(async {
-            let mut tasks = vec![];
-
-            // Set up an environment variable for this.
-            for test in inventory::iter::<__TestStart> {
-                // Acquire a guard.
-                let guard = sema.acquire().await;
-
-                // Spawn a subprocess.
-                let mut process = async_process::Command::new(&process_name)
-                    .envs(env::vars_os().chain(Some({
-                        (path(&GUI_TEST_CURRENT_TEST_NAME), path(&test.name))
-                    })))
-                    .spawn()
-                    .expect("failed to spawn child process");
-
-                // Spawn a task to poll that subprocess.
-                let task = ex.spawn(async move {
-                    let _guard = guard;
-                    process.status().await.unwrap()
-                });
-
-                tasks.push(task);
-            }
-
-            // Finish all of the tasks.
-            for task in tasks {
-                task.await;
-            }
-        }));
-    }
-}
-
-fn path<A: AsRef<OsStr>>(s: &A) -> OsString {
-    s.as_ref().into()
-}

it/gui-test/src/remote.rs

@@ -1,31 +0,0 @@
-//! Create a test handler that can be run remotely.
-
-use crate::stream::WriteHandler;
-use crate::user::UserHandler;
-use crate::TestHandler;
-
-use std::env;
-use std::net::TcpStream;
-
-/// Create a test handler adjusted for the current environment.
-pub fn handler() -> Box<dyn TestHandler + Send + 'static> {
-    // If GUI_TEST_UNIX_STREAM is enabled, use that as a Unix stream.
-    #[cfg(unix)]
-    if let Some(stream_path) = env::var_os("GUI_TEST_UNIX_STREAM").filter(|s| !s.is_empty()) {
-        let stream = std::os::unix::net::UnixStream::connect(stream_path)
-            .expect("unable to connect to gui-test handler");
-        return Box::new(WriteHandler::new(stream));
-    }
-
-    // If GUI_TEST_TCP_STREAM is enabled, use that as a TCP stream.
-    if let Some(tcp_ip) = env::var("GUI_TEST_TCP_STREAM")
-        .ok()
-        .filter(|s| !s.is_empty())
-    {
-        let stream = TcpStream::connect(tcp_ip).unwrap();
-        return Box::new(WriteHandler::new(stream));
-    }
-
-    // By default, use the user handler.
-    Box::new(UserHandler::new())
-}

it/gui-test/src/stream.rs

@@ -1,39 +0,0 @@
-//! Write events to an output stream.
-//!
-//! The format is as follows:
-//! - First 8 bytes: big-endian length of payload.
-//! - Next {len} bytes: JSON payload to deserialize from.
-
-use crate::{TestEvent, TestHandler};
-use std::io::Write;
-
-/// A wrapper around a writer that sends data down a stream.
-#[derive(Debug)]
-pub struct WriteHandler<W: Write> {
-    /// The inner writer.
-    writer: W,
-}
-
-impl<W: Write> WriteHandler<W> {
-    /// Create a new write handler.
-    pub fn new(writer: W) -> Self {
-        Self { writer }
-    }
-}
-
-impl<W: Write> TestHandler for WriteHandler<W> {
-    fn handle_test(&mut self, event: TestEvent) {
-        let payload = serde_json::to_vec(&event).unwrap();
-        let length = u64::to_be_bytes(payload.len() as u64);
-
-        // Write the payload to the stream.
-        self.writer.write_all(&length).unwrap();
-        self.writer.write_all(&payload).unwrap();
-    }
-}
-
-impl<W: Write> Drop for WriteHandler<W> {
-    fn drop(&mut self) {
-        self.writer.flush().ok();
-    }
-}

it/gui-test/src/user.rs

@@ -1,180 +0,0 @@
-//! User-facing reporter.
-
-use crate::{TestEvent, TestEventType, TestHandler, TestResult};
-use owo_colors::OwoColorize;
-
-use std::collections::BTreeMap;
-use std::io::{self, prelude::*};
-
-const TABSIZE: usize = 2;
-
-/// User-facing reporter.
-///
-/// This reporter dumps events to the console in a user-readable format.
-pub struct UserHandler {
-    /// Current indent.
-    indent: usize,
-
-    /// The test set we're currently displaying.
-    current_start: Option<String>,
-
-    /// Test name we are running, if any.
-    test_name: Option<String>,
-
-    /// Cached events.
-    cache: BTreeMap<String, Vec<TestEventType>>,
-
-    /// Failures we had.
-    failures: Vec<(String, String)>,
-}
-
-impl UserHandler {
-    /// Create a new handler.
-    pub fn new() -> Self {
-        Self {
-            indent: 0,
-            current_start: None,
-            test_name: None,
-            cache: BTreeMap::new(),
-            failures: vec![],
-        }
-    }
-
-    /// Process the provided events.
-    fn process_events(&mut self, events: impl IntoIterator<Item = TestEvent>) {
-        for event in events {
-            // Tell if this is an end event.
-            let mut ender = matches!(event.ty, TestEventType::Complete { .. });
-
-            // If there is no test name set, run the current one.
-            match self.current_start.as_ref() {
-                None => {
-                    let TestEvent { runner, ty } = event;
-                    self.current_start = Some(runner);
-                    self.dump_events(Some(ty));
-                }
-
-                Some(test_name) => {
-                    // If there is a test name set and it's ours, post it immediately.
-                    if test_name == &event.runner {
-                        self.dump_events(Some(event.ty));
-                    } else {
-                        // Add it to the back of another one of the events.
-                        self.cache
-                            .entry(test_name.clone())
-                            .or_default()
-                            .push(event.ty);
-                    }
-                }
-            }
-
-            // If this is the end, dump other events.
-            while ender {
-                ender = false;
-                assert!(self.current_start.take().is_some());
-
-                // Pick one set.
-                if let Some(entry) = self.cache.first_entry() {
-                    let (test_name, entries) = entry.remove_entry();
-                    self.current_start = Some(test_name);
-
-                    // Dump events and look for a conclusion.
-                    self.dump_events(entries.into_iter().inspect(|ty| {
-                        ender |= matches!(ty, TestEventType::Complete { .. });
-                    }));
-                }
-
-                println!();
-            }
-        }
-    }
-
-    /// Dump the provided events to the console.
-    fn dump_events(&mut self, events: impl IntoIterator<Item = TestEventType>) {
-        let mut stdout = io::stdout().lock();
-
-        for event in events {
-            // Write the indent.
-            for _ in 0..(self.indent * TABSIZE) {
-                stdout.write_all(b" ").unwrap();
-            }
-
-            match event {
-                TestEventType::GroupStarted { name } => {
-                    assert!(self.test_name.is_none());
-
-                    // Write the group name and bump the indent.
-                    writeln!(stdout, "{}", name.yellow().italic()).unwrap();
-
-                    // Add to the indent.
-                    self.indent += 1;
-                }
-
-                TestEventType::GroupEnded => {
-                    assert!(self.test_name.is_none());
-
-                    // Drop the indent.
-                    self.indent = self.indent.checked_sub(1).unwrap();
-                }
-
-                TestEventType::TestStarted { name } => {
-                    assert!(self.test_name.is_none());
-
-                    // Write the line.
-                    write!(stdout, "{} ", name.white().italic()).unwrap();
-                    self.test_name = Some(name);
-                }
-
-                TestEventType::TestEnded { result } => {
-                    let test_name = self.test_name.take().unwrap();
-
-                    // Write the result.
-                    match result {
-                        TestResult::Passed => {
-                            writeln!(stdout, "{}", "ok".green().bold()).unwrap();
-                        }
-
-                        TestResult::Failed(failure) => {
-                            self.failures.push((test_name, failure));
-                            writeln!(stdout, "{}", "FAIL".red().bold()).unwrap();
-                        }
-
-                        TestResult::Skipped => {
-                            writeln!(stdout, "{}", "skipped".yellow().bold()).unwrap();
-                        }
-                    }
-                }
-
-                _ => {
-                    // Completion.
-                }
-            }
-        }
-    }
-}
-
-impl TestHandler for UserHandler {
-    fn handle_test(&mut self, event: TestEvent) {
-        self.process_events(Some(event));
-    }
-}
-
-impl Drop for UserHandler {
-    fn drop(&mut self) {
-        assert!(self.cache.is_empty());
-
-        // Write the final bit to the stdout.
-        let mut stdout = io::stdout().lock();
-
-        if !self.failures.is_empty() {
-            writeln!(stdout, "Test Failures:").ok();
-
-            for (test_name, panic) in &self.failures {
-                writeln!(stdout, "  {}", test_name).ok();
-                writeln!(stdout, "-------------").ok();
-                writeln!(stdout, "{}", panic).ok();
-                writeln!(stdout, "-------------").ok();
-            }
-        }
-    }
-}

src/application.rs

@@ -1,221 +0,0 @@
-//! End user application handling.
-
-use crate::event::{DeviceEvent, DeviceId, StartCause, WindowEvent};
-use crate::event_loop::ActiveEventLoop;
-use crate::window::WindowId;
-
-/// The handler of the application events.
-pub trait ApplicationHandler<T: 'static = ()> {
-    /// Emitted when new events arrive from the OS to be processed.
-    ///
-    /// This is a useful place to put code that should be done before you start processing
-    /// events, such as updating frame timing information for benchmarking or checking the
-    /// [`StartCause`] to see if a timer set by
-    /// [`ControlFlow::WaitUntil`][crate::event_loop::ControlFlow::WaitUntil] has elapsed.
-    fn new_events(&mut self, event_loop: &ActiveEventLoop, cause: StartCause) {
-        let _ = (event_loop, cause);
-    }
-
-    /// Emitted when the application has been resumed.
-    ///
-    /// For consistency, all platforms emit a `Resumed` event even if they don't themselves have a
-    /// formal suspend/resume lifecycle. For systems without a formal suspend/resume lifecycle
-    /// the `Resumed` event is always emitted after the [`NewEvents(StartCause::Init)`][StartCause::Init]
-    /// event.
-    ///
-    /// # Portability
-    ///
-    /// It's recommended that applications should only initialize their graphics context and create
-    /// a window after they have received their first `Resumed` event. Some systems
-    /// (specifically Android) won't allow applications to create a render surface until they are
-    /// resumed.
-    ///
-    /// Considering that the implementation of [`Suspended`] and `Resumed` events may be internally
-    /// driven by multiple platform-specific events, and that there may be subtle differences across
-    /// platforms with how these internal events are delivered, it's recommended that applications
-    /// be able to gracefully handle redundant (i.e. back-to-back) [`Suspended`] or `Resumed` events.
-    ///
-    /// Also see [`Suspended`] notes.
-    ///
-    /// ## Android
-    ///
-    /// On Android, the `Resumed` event is sent when a new [`SurfaceView`] has been created. This is
-    /// expected to closely correlate with the [`onResume`] lifecycle event but there may technically
-    /// be a discrepancy.
-    ///
-    /// [`onResume`]: https://developer.android.com/reference/android/app/Activity#onResume()
-    ///
-    /// Applications that need to run on Android must wait until they have been `Resumed`
-    /// before they will be able to create a render surface (such as an `EGLSurface`,
-    /// [`VkSurfaceKHR`] or [`wgpu::Surface`]) which depend on having a
-    /// [`SurfaceView`]. Applications must also assume that if they are [`Suspended`], then their
-    /// render surfaces are invalid and should be dropped.
-    ///
-    /// Also see [`Suspended`] notes.
-    ///
-    /// [`SurfaceView`]: https://developer.android.com/reference/android/view/SurfaceView
-    /// [Activity lifecycle]: https://developer.android.com/guide/components/activities/activity-lifecycle
-    /// [`VkSurfaceKHR`]: https://www.khronos.org/registry/vulkan/specs/1.3-extensions/man/html/VkSurfaceKHR.html
-    /// [`wgpu::Surface`]: https://docs.rs/wgpu/latest/wgpu/struct.Surface.html
-    ///
-    /// ## iOS
-    ///
-    /// On iOS, the `Resumed` event is emitted in response to an [`applicationDidBecomeActive`]
-    /// callback which means the application is "active" (according to the
-    /// [iOS application lifecycle]).
-    ///
-    /// [`applicationDidBecomeActive`]: https://developer.apple.com/documentation/uikit/uiapplicationdelegate/1622956-applicationdidbecomeactive
-    /// [iOS application lifecycle]: https://developer.apple.com/documentation/uikit/app_and_environment/managing_your_app_s_life_cycle
-    ///
-    /// ## Web
-    ///
-    /// On Web, the `Resumed` event is emitted in response to a [`pageshow`] event
-    /// with the property [`persisted`] being true, which means that the page is being
-    /// restored from the [`bfcache`] (back/forward cache) - an in-memory cache that
-    /// stores a complete snapshot of a page (including the JavaScript heap) as the
-    /// user is navigating away.
-    ///
-    /// [`pageshow`]: https://developer.mozilla.org/en-US/docs/Web/API/Window/pageshow_event
-    /// [`persisted`]: https://developer.mozilla.org/en-US/docs/Web/API/PageTransitionEvent/persisted
-    /// [`bfcache`]: https://web.dev/bfcache/
-    /// [`Suspended`]: Self::suspended
-    fn resumed(&mut self, event_loop: &ActiveEventLoop);
-
-    /// Emitted when an event is sent from [`EventLoopProxy::send_event`].
-    ///
-    /// [`EventLoopProxy::send_event`]: crate::event_loop::EventLoopProxy::send_event
-    fn user_event(&mut self, event_loop: &ActiveEventLoop, event: T) {
-        let _ = (event_loop, event);
-    }
-
-    /// Emitted when the OS sends an event to a winit window.
-    fn window_event(
-        &mut self,
-        event_loop: &ActiveEventLoop,
-        window_id: WindowId,
-        event: WindowEvent,
-    );
-
-    /// Emitted when the OS sends an event to a device.
-    fn device_event(
-        &mut self,
-        event_loop: &ActiveEventLoop,
-        device_id: DeviceId,
-        event: DeviceEvent,
-    ) {
-        let _ = (event_loop, device_id, event);
-    }
-
-    /// Emitted when the event loop is about to block and wait for new events.
-    ///
-    /// Most applications shouldn't need to hook into this event since there is no real relationship
-    /// between how often the event loop needs to wake up and the dispatching of any specific events.
-    ///
-    /// High frequency event sources, such as input devices could potentially lead to lots of wake
-    /// ups and also lots of corresponding `AboutToWait` events.
-    ///
-    /// This is not an ideal event to drive application rendering from and instead applications
-    /// should render in response to [`WindowEvent::RedrawRequested`] events.
-    fn about_to_wait(&mut self, event_loop: &ActiveEventLoop) {
-        let _ = event_loop;
-    }
-
-    /// Emitted when the application has been suspended.
-    ///
-    /// # Portability
-    ///
-    /// Not all platforms support the notion of suspending applications, and there may be no
-    /// technical way to guarantee being able to emit a `Suspended` event if the OS has
-    /// no formal application lifecycle (currently only Android, iOS, and Web do). For this reason,
-    /// Winit does not currently try to emit pseudo `Suspended` events before the application
-    /// quits on platforms without an application lifecycle.
-    ///
-    /// Considering that the implementation of `Suspended` and [`Resumed`] events may be internally
-    /// driven by multiple platform-specific events, and that there may be subtle differences across
-    /// platforms with how these internal events are delivered, it's recommended that applications
-    /// be able to gracefully handle redundant (i.e. back-to-back) `Suspended` or [`Resumed`] events.
-    ///
-    /// Also see [`Resumed`] notes.
-    ///
-    /// ## Android
-    ///
-    /// On Android, the `Suspended` event is only sent when the application's associated
-    /// [`SurfaceView`] is destroyed. This is expected to closely correlate with the [`onPause`]
-    /// lifecycle event but there may technically be a discrepancy.
-    ///
-    /// [`onPause`]: https://developer.android.com/reference/android/app/Activity#onPause()
-    ///
-    /// Applications that need to run on Android should assume their [`SurfaceView`] has been
-    /// destroyed, which indirectly invalidates any existing render surfaces that may have been
-    /// created outside of Winit (such as an `EGLSurface`, [`VkSurfaceKHR`] or [`wgpu::Surface`]).
-    ///
-    /// After being `Suspended` on Android applications must drop all render surfaces before
-    /// the event callback completes, which may be re-created when the application is next [`Resumed`].
-    ///
-    /// [`SurfaceView`]: https://developer.android.com/reference/android/view/SurfaceView
-    /// [Activity lifecycle]: https://developer.android.com/guide/components/activities/activity-lifecycle
-    /// [`VkSurfaceKHR`]: https://www.khronos.org/registry/vulkan/specs/1.3-extensions/man/html/VkSurfaceKHR.html
-    /// [`wgpu::Surface`]: https://docs.rs/wgpu/latest/wgpu/struct.Surface.html
-    ///
-    /// ## iOS
-    ///
-    /// On iOS, the `Suspended` event is currently emitted in response to an
-    /// [`applicationWillResignActive`] callback which means that the application is
-    /// about to transition from the active to inactive state (according to the
-    /// [iOS application lifecycle]).
-    ///
-    /// [`applicationWillResignActive`]: https://developer.apple.com/documentation/uikit/uiapplicationdelegate/1622950-applicationwillresignactive
-    /// [iOS application lifecycle]: https://developer.apple.com/documentation/uikit/app_and_environment/managing_your_app_s_life_cycle
-    ///
-    /// ## Web
-    ///
-    /// On Web, the `Suspended` event is emitted in response to a [`pagehide`] event
-    /// with the property [`persisted`] being true, which means that the page is being
-    /// put in the [`bfcache`] (back/forward cache) - an in-memory cache that stores a
-    /// complete snapshot of a page (including the JavaScript heap) as the user is
-    /// navigating away.
-    ///
-    /// [`pagehide`]: https://developer.mozilla.org/en-US/docs/Web/API/Window/pagehide_event
-    /// [`persisted`]: https://developer.mozilla.org/en-US/docs/Web/API/PageTransitionEvent/persisted
-    /// [`bfcache`]: https://web.dev/bfcache/
-    /// [`Resumed`]: Self::resumed
-    fn suspended(&mut self, event_loop: &ActiveEventLoop) {
-        let _ = event_loop;
-    }
-
-    /// Emitted when the event loop is being shut down.
-    ///
-    /// This is irreversible - if this method is called, it is guaranteed that the event loop
-    /// will exist right after.
-    fn exiting(&mut self, event_loop: &ActiveEventLoop) {
-        let _ = event_loop;
-    }
-
-    /// Emitted when the application has received a memory warning.
-    ///
-    /// ## Platform-specific
-    ///
-    /// ### Android
-    ///
-    /// On Android, the `MemoryWarning` event is sent when [`onLowMemory`] was called. The application
-    /// must [release memory] or risk being killed.
-    ///
-    /// [`onLowMemory`]: https://developer.android.com/reference/android/app/Application.html#onLowMemory()
-    /// [release memory]: https://developer.android.com/topic/performance/memory#release
-    ///
-    /// ### iOS
-    ///
-    /// On iOS, the `MemoryWarning` event is emitted in response to an [`applicationDidReceiveMemoryWarning`]
-    /// callback. The application must free as much memory as possible or risk being terminated, see
-    /// [how to respond to memory warnings].
-    ///
-    /// [`applicationDidReceiveMemoryWarning`]: https://developer.apple.com/documentation/uikit/uiapplicationdelegate/1623063-applicationdidreceivememorywarni
-    /// [how to respond to memory warnings]: https://developer.apple.com/documentation/uikit/app_and_environment/managing_your_app_s_life_cycle/responding_to_memory_warnings
-    ///
-    /// ### Others
-    ///
-    /// - **macOS / Orbital / Wayland / Web / Windows:** Unsupported.
-    fn memory_warning(&mut self, event_loop: &ActiveEventLoop) {
-        let _ = event_loop;
-    }
-}

src/changelog/mod.rs

@@ -1,75 +0,0 @@
-//! # Changelog and migrations
-//!
-//! All notable changes to this project will be documented in this module,
-//! along with migration instructions for larger changes.
-//!
-// Put the current entry at the top of this page, for discoverability.
-// See `.cargo/config.toml` for details about `unreleased_changelogs`.
-#![cfg_attr(unreleased_changelogs, doc = include_str!("unreleased.md"))]
-#![cfg_attr(not(unreleased_changelogs), doc = include_str!("v0.29.md"))]
-
-#[doc = include_str!("v0.29.md")]
-pub mod v0_29 {}
-
-#[doc = include_str!("v0.28.md")]
-pub mod v0_28 {}
-
-#[doc = include_str!("v0.27.md")]
-pub mod v0_27 {}
-
-#[doc = include_str!("v0.26.md")]
-pub mod v0_26 {}
-
-#[doc = include_str!("v0.25.md")]
-pub mod v0_25 {}
-
-#[doc = include_str!("v0.24.md")]
-pub mod v0_24 {}
-
-#[doc = include_str!("v0.23.md")]
-pub mod v0_23 {}
-
-#[doc = include_str!("v0.22.md")]
-pub mod v0_22 {}
-
-#[doc = include_str!("v0.21.md")]
-pub mod v0_21 {}
-
-#[doc = include_str!("v0.20.md")]
-pub mod v0_20 {}
-
-#[doc = include_str!("v0.19.md")]
-pub mod v0_19 {}
-
-#[doc = include_str!("v0.18.md")]
-pub mod v0_18 {}
-
-#[doc = include_str!("v0.17.md")]
-pub mod v0_17 {}
-
-#[doc = include_str!("v0.16.md")]
-pub mod v0_16 {}
-
-#[doc = include_str!("v0.15.md")]
-pub mod v0_15 {}
-
-#[doc = include_str!("v0.14.md")]
-pub mod v0_14 {}
-
-#[doc = include_str!("v0.13.md")]
-pub mod v0_13 {}
-
-#[doc = include_str!("v0.12.md")]
-pub mod v0_12 {}
-
-#[doc = include_str!("v0.11.md")]
-pub mod v0_11 {}
-
-#[doc = include_str!("v0.10.md")]
-pub mod v0_10 {}
-
-#[doc = include_str!("v0.9.md")]
-pub mod v0_9 {}
-
-#[doc = include_str!("v0.8.md")]
-pub mod v0_8 {}

src/changelog/unreleased.md

@@ -1,42 +0,0 @@
-## Unreleased
-
-- Deprecate `EventLoop::run` in favor of `EventLoop::run_app`.
-- Deprecate `EventLoopExtRunOnDemand::run_on_demand` in favor of `EventLoop::run_app_on_demand`.
-- Deprecate `EventLoopExtPumpEvents::pump_events` in favor of `EventLoopExtPumpEvents::pump_app_events`.
-- Add `ApplicationHandler<T>` trait which mimics `Event<T>`.
-- Move `dpi` types to its own crate, and re-export it from the root crate.
-- Implement `Sync` for `EventLoopProxy<T: Send>`.
-- **Breaking:** Move `Window::new` to `ActiveEventLoop::create_window` and `EventLoop::create_window` (with the latter being deprecated).
-- **Breaking:** Rename `EventLoopWindowTarget` to `ActiveEventLoop`.
-- **Breaking:** Remove `Deref` implementation for `EventLoop` that gave `EventLoopWindowTarget`.
-- **Breaking**: Remove `WindowBuilder` in favor of `WindowAttributes`.
-- **Breaking:** Removed unnecessary generic parameter `T` from `EventLoopWindowTarget`.
-- On Windows, macOS, X11, Wayland and Web, implement setting images as cursors. See the `custom_cursors.rs` example.
-  - **Breaking:** Remove `Window::set_cursor_icon`
-  - Add `WindowBuilder::with_cursor` and `Window::set_cursor` which takes a `CursorIcon` or `CustomCursor`
-  - Add `CustomCursor::from_rgba` to allow creating cursor images from RGBA data.
-  - Add `CustomCursorExtWebSys::from_url` to allow loading cursor images from URLs.
-  - Add `CustomCursorExtWebSys::from_animation` to allow creating animated cursors from other `CustomCursor`s.
-  - Add `{Active,}EventLoop::create_custom_cursor` to load custom cursor image sources.
-- On macOS, add services menu.
-- **Breaking:** On Web, remove queuing fullscreen request in absence of transient activation.
-- On Web, fix setting cursor icon overriding cursor visibility.
-- **Breaking:** On Web, return `RawWindowHandle::WebCanvas` instead of `RawWindowHandle::Web`.
-- **Breaking:** On Web, macOS and iOS, return `HandleError::Unavailable` when a window handle is not available.
-- **Breaking:** Bump MSRV from `1.65` to `1.70`.
-- On Web, add the ability to toggle calling `Event.preventDefault()` on `Window`.
-- **Breaking:** Remove `WindowAttributes::fullscreen()` and expose as field directly.
-- **Breaking:** Rename `VideoMode` to `VideoModeHandle` to represent that it doesn't hold static data.
-- **Breaking:** No longer export `platform::x11::XNotSupported`.
-- **Breaking:** Renamed `platform::x11::XWindowType` to `platform::x11::WindowType`.
-- Add the `OwnedDisplayHandle` type for allowing safe display handle usage outside of trivial cases.
-- **Breaking:** Rename `TouchpadMagnify` to `PinchGesture`, `SmartMagnify` to `DoubleTapGesture` and `TouchpadRotate` to `RotationGesture` to represent the action rather than the intent.
-- on iOS, add detection support for `PinchGesture`, `DoubleTapGesture` and `RotationGesture`.
-- on Windows: add `with_system_backdrop`, `with_border_color`, `with_title_background_color`, `with_title_text_color` and `with_corner_preference`
-- On Windows, Remove `WS_CAPTION`, `WS_BORDER` and `WS_EX_WINDOWEDGE` styles for child windows without decorations.
-- **Breaking:** Removed `EventLoopError::AlreadyRunning`, which can't happen as it is already prevented by the type system.
-- Added `EventLoop::builder`, which is intended to replace the (now deprecated) `EventLoopBuilder::new`.
-- **Breaking:** Changed the signature of `EventLoop::with_user_event` to return a builder.
-- **Breaking:** Removed `EventLoopBuilder::with_user_event`, the functionality is now available in `EventLoop::with_user_event`.
-- Add `Window::default_attributes` to get default `WindowAttributes`.
-- `log` has been replaced with `tracing`. The old behavior can be emulated by setting the `log` feature on the `tracing` crate.

src/changelog/v0.10.md

@@ -1,13 +0,0 @@
-## 0.10.1
-
-_Yanked_
-
-## 0.10.0
-
-- Add support for `Touch` for emscripten backend.
-- Added support for `DroppedFile`, `HoveredFile`, and `HoveredFileCancelled` to X11 backend.
-- **Breaking:** `unix::WindowExt` no longer returns pointers for things that aren't actually pointers; `get_xlib_window` now returns `Option<std::os::raw::c_ulong>` and `get_xlib_screen_id` returns `Option<std::os::raw::c_int>`. Additionally, methods that previously returned `libc::c_void` have been changed to return `std::os::raw::c_void`, which are not interchangeable types, so users wanting the former will need to explicitly cast.
-- Added `set_decorations` method to `Window` to allow decorations to be toggled after the window is built. Presently only implemented on X11.
-- Raised the minimum supported version of Rust to 1.20 on MacOS due to usage of associated constants in new versions of cocoa and core-graphics.
-- Added `modifiers` field to `MouseInput`, `MouseWheel`, and `CursorMoved` events to track the modifiers state (`ModifiersState`).
-- Fixed the emscripten backend to return the size of the canvas instead of the size of the window.

src/changelog/v0.11.md

@@ -1,27 +0,0 @@
-## 0.11.3
-
-- Added `set_min_dimensions` and `set_max_dimensions` methods to `Window`, and implemented on Windows, X11, Wayland, and OSX.
-- On X11, dropping a `Window` actually closes it now, and clicking the window's × button (or otherwise having the WM signal to close it) will result in the window closing.
-- Added `WindowBuilderExt` methods for macos: `with_titlebar_transparent`,
-  `with_title_hidden`, `with_titlebar_buttons_hidden`,
-  `with_fullsize_content_view`.
-- Mapped X11 numpad keycodes (arrows, Home, End, PageUp, PageDown, Insert and Delete) to corresponding virtual keycodes
-
-## 0.11.2
-
-- Impl `Hash`, `PartialEq`, and `Eq` for `events::ModifiersState`.
-- Implement `MonitorId::get_hidpi_factor` for MacOS.
-- Added method `os::macos::MonitorIdExt::get_nsscreen() -> *mut c_void` that gets a `NSScreen` object matching the monitor ID.
-- Send `Awakened` event on Android when event loop is woken up.
-
-## 0.11.1
-
-- Fixed windows not receiving mouse events when click-dragging the mouse outside the client area of a window, on Windows platforms.
-- Added method `os::android::EventsLoopExt:set_suspend_callback(Option<Box<Fn(bool) -> ()>>)` that allows glutin to register a callback when a suspend event happens
-
-## 0.11.0
-
-- Implement `MonitorId::get_dimensions` for Android.
-- Added method `os::macos::WindowBuilderExt::with_movable_by_window_background(bool)` that allows to move a window without a titlebar - `with_decorations(false)`
-- Implement `Window::set_fullscreen`, `Window::set_maximized` and `Window::set_decorations` for Wayland.
-- Added `Caret` as VirtualKeyCode and support OSX ^-Key with german input.

src/changelog/v0.12.md

@@ -1,8 +0,0 @@
-## 0.12.0
-
-- Added subclass to macos windows so they can be made resizable even with no decorations.
-- Dead keys now work properly on X11, no longer resulting in a panic.
-- On X11, input method creation first tries to use the value from the user's `XMODIFIERS` environment variable, so application developers should no longer need to manually call `XSetLocaleModifiers`. If that fails, fallbacks are tried, which should prevent input method initialization from ever outright failing.
-- Fixed thread safety issues with input methods on X11.
-- Add support for `Touch` for win32 backend.
-- Fixed `Window::get_inner_size` and friends to return the size in pixels instead of points when using HIDPI displays on OSX.

src/changelog/v0.13.md

@@ -1,20 +0,0 @@
-## 0.13.1
-
-- Ensure necessary `x11-dl` version is used.
-
-## 0.13.0
-
-- Implement `WindowBuilder::with_maximized`, `Window::set_fullscreen`, `Window::set_maximized` and `Window::set_decorations` for MacOS.
-- Implement `WindowBuilder::with_maximized`, `Window::set_fullscreen`, `Window::set_maximized` and `Window::set_decorations` for Windows.
-- On Windows, `WindowBuilder::with_fullscreen` no longer changing monitor display resolution.
-- Overhauled X11 window geometry calculations. `get_position` and `set_position` are more universally accurate across different window managers, and `get_outer_size` actually works now.
-- Fixed SIGSEGV/SIGILL crashes on macOS caused by stabilization of the `!` (never) type.
-- Implement `WindowEvent::HiDPIFactorChanged` for macOS
-- On X11, input methods now work completely out of the box, no longer requiring application developers to manually call `setlocale`. Additionally, when input methods are started, stopped, or restarted on the server end, it's correctly handled.
-- Implemented `Refresh` event on Windows.
-- Properly calculate the minimum and maximum window size on Windows, including window decorations.
-- Map more `MouseCursor` variants to cursor icons on Windows.
-- Corrected `get_position` on macOS to return outer frame position, not content area position.
-- Corrected `set_position` on macOS to set outer frame position, not content area position.
-- Added `get_inner_position` method to `Window`, which gets the position of the window's client area. This is implemented on all applicable platforms (all desktop platforms other than Wayland, where this isn't possible).
-- **Breaking:** the `Closed` event has been replaced by `CloseRequested` and `Destroyed`. To migrate, you typically just need to replace all usages of `Closed` with `CloseRequested`; see example programs for more info. The exception is iOS, where `Closed` must be replaced by `Destroyed`.

src/changelog/v0.14.md

@@ -1,21 +0,0 @@
-## 0.14.0
-
-- Created the `Copy`, `Paste` and `Cut` `VirtualKeyCode`s and added support for them on X11 and Wayland
-- Fix `.with_decorations(false)` in macOS
-- On Mac, `NSWindow` and supporting objects might be alive long after they were `closed` which resulted in apps consuming more heap then needed. Mainly it was affecting multi window applications. Not expecting any user visible change of behaviour after the fix.
-- Fix regression of Window platform extensions for macOS where `NSFullSizeContentViewWindowMask` was not being correctly applied to `.fullsize_content_view`.
-- Corrected `get_position` on Windows to be relative to the screen rather than to the taskbar.
-- Corrected `Moved` event on Windows to use position values equivalent to those returned by `get_position`. It previously supplied client area positions instead of window positions, and would additionally interpret negative values as being very large (around `u16::MAX`).
-- Implemented `Moved` event on macOS.
-- On X11, the `Moved` event correctly use window positions rather than client area positions. Additionally, a stray `Moved` that unconditionally accompanied `Resized` with the client area position relative to the parent has been eliminated; `Moved` is still received alongside `Resized`, but now only once and always correctly.
-- On Windows, implemented all variants of `DeviceEvent` other than `Text`. Mouse `DeviceEvent`s are now received even if the window isn't in the foreground.
-- `DeviceId` on Windows is no longer a unit struct, and now contains a `u32`. For `WindowEvent`s, this will always be 0, but on `DeviceEvent`s it will be the handle to that device. `DeviceIdExt::get_persistent_identifier` can be used to acquire a unique identifier for that device that persists across replugs/reboots/etc.
-- Corrected `run_forever` on X11 to stop discarding `Awakened` events.
-- Various safety and correctness improvements to the X11 backend internals.
-- Fixed memory leak on X11 every time the mouse entered the window.
-- On X11, drag and drop now works reliably in release mode.
-- Added `WindowBuilderExt::with_resize_increments` and `WindowBuilderExt::with_base_size` to X11, allowing for more optional hints to be set.
-- Rework of the wayland backend, migrating it to use [Smithay's Client Toolkit](https://github.com/Smithay/client-toolkit).
-- Added `WindowBuilder::with_window_icon` and `Window::set_window_icon`, finally making it possible to set the window icon on Windows and X11. The `icon_loading` feature can be enabled to allow for icons to be easily loaded; see example program `window_icon.rs` for usage.
-- Windows additionally has `WindowBuilderExt::with_taskbar_icon` and `WindowExt::set_taskbar_icon`.
-- On Windows, fix panic when trying to call `set_fullscreen(None)` on a window that has not been fullscreened prior.

src/changelog/v0.15.md

@@ -1,42 +0,0 @@
-## 0.15.1
-
-- On X11, the `Moved` event is no longer sent when the window is resized without changing position.
-- `MouseCursor` and `CursorState` now implement `Default`.
-- `WindowBuilder::with_resizable` implemented for Windows, X11, Wayland, and macOS.
-- `Window::set_resizable` implemented for Windows, X11, Wayland, and macOS.
-- On X11, if the monitor's width or height in millimeters is reported as 0, the DPI is now 1.0 instead of +inf.
-- On X11, the environment variable `WINIT_HIDPI_FACTOR` has been added for overriding DPI factor.
-- On X11, enabling transparency no longer causes the window contents to flicker when resizing.
-- On X11, `with_override_redirect` now actually enables override redirect.
-- macOS now generates `VirtualKeyCode::LAlt` and `VirtualKeyCode::RAlt` instead of `None` for both.
-- On macOS, `VirtualKeyCode::RWin` and `VirtualKeyCode::LWin` are no longer switched.
-- On macOS, windows without decorations can once again be resized.
-- Fixed race conditions when creating an `EventsLoop` on X11, most commonly manifesting as `"[xcb] Unknown sequence number while processing queue"`.
-- On macOS, `CursorMoved` and `MouseInput` events are only generated if they occurs within the window's client area.
-- On macOS, resizing the window no longer generates a spurious `MouseInput` event.
-
-## 0.15.0
-
-- `Icon::to_cardinals` is no longer public, since it was never supposed to be.
-- Wayland: improve diagnostics if initialization fails
-- Fix some system event key doesn't work when focused, do not block keyevent forward to system on macOS
-- On X11, the scroll wheel position is now correctly reset on i3 and other WMs that have the same quirk.
-- On X11, `Window::get_current_monitor` now reliably returns the correct monitor.
-- On X11, `Window::hidpi_factor` returns values from XRandR rather than the inaccurate values previously queried from the core protocol.
-- On X11, the primary monitor is detected correctly even when using versions of XRandR less than 1.5.
-- `MonitorId` now implements `Debug`.
-- Fixed bug on macOS where using `with_decorations(false)` would cause `set_decorations(true)` to produce a transparent titlebar with no title.
-- Implemented `MonitorId::get_position` on macOS.
-- On macOS, `Window::get_current_monitor` now returns accurate values.
-- Added `WindowBuilderExt::with_resize_increments` to macOS.
-- **Breaking:** On X11, `WindowBuilderExt::with_resize_increments` and `WindowBuilderExt::with_base_size` now take `u32` values rather than `i32`.
-- macOS keyboard handling has been overhauled, allowing for the use of dead keys, IME, etc. Right modifier keys are also no longer reported as being left.
-- Added the `Window::set_ime_spot(x: i32, y: i32)` method, which is implemented on X11 and macOS.
-- **Breaking**: `os::unix::WindowExt::send_xim_spot(x: i16, y: i16)` no longer exists. Switch to the new `Window::set_ime_spot(x: i32, y: i32)`, which has equivalent functionality.
-- Fixed detection of `Pause` and `Scroll` keys on Windows.
-- On Windows, alt-tabbing while the cursor is grabbed no longer makes it impossible to re-grab the cursor.
-- On Windows, using `CursorState::Hide` when the cursor is grabbed now ungrabs the cursor first.
-- Implemented `MouseCursor::NoneCursor` on Windows.
-- Added `WindowBuilder::with_always_on_top` and `Window::set_always_on_top`. Implemented on Windows, macOS, and X11.
-- On X11, `WindowBuilderExt` now has `with_class`, `with_override_redirect`, and `with_x11_window_type` to allow for more control over window creation. `WindowExt` additionally has `set_urgent`.
-- More hints are set by default on X11, including `_NET_WM_PID` and `WM_CLIENT_MACHINE`. Note that prior to this, the `WM_CLASS` hint was automatically set to whatever value was passed to `with_title`. It's now set to the executable name to better conform to expectations and the specification; if this is undesirable, you must explicitly use `WindowBuilderExt::with_class`.

src/changelog/v0.16.md

@@ -1,32 +0,0 @@
-## 0.16.2
-
-- On Windows, non-resizable windows now have the maximization button disabled. This is consistent with behavior on macOS and popular X11 WMs.
-- Corrected incorrect `unreachable!` usage when guessing the DPI factor with no detected monitors.
-
-## 0.16.1
-
-- Added logging through `log`. Logging will become more extensive over time.
-- On X11 and Windows, the window's DPI factor is guessed before creating the window. This _greatly_ cuts back on unsightly auto-resizing that would occur immediately after window creation.
-- Fixed X11 backend compilation for environments where `c_char` is unsigned.
-
-## 0.16.0
-
-- Windows additionally has `WindowBuilderExt::with_no_redirection_bitmap`.
-- **Breaking:** Removed `VirtualKeyCode::LMenu` and `VirtualKeyCode::RMenu`; Windows now generates `VirtualKeyCode::LAlt` and `VirtualKeyCode::RAlt` instead.
-- On X11, exiting fullscreen no longer leaves the window in the monitor's top left corner.
-- **Breaking:** `Window::hidpi_factor` has been renamed to `Window::get_hidpi_factor` for better consistency. `WindowEvent::HiDPIFactorChanged` has been renamed to `WindowEvent::HiDpiFactorChanged`. DPI factors are always represented as `f64` instead of `f32` now.
-- The Windows backend is now DPI aware. `WindowEvent::HiDpiFactorChanged` is implemented, and `MonitorId::get_hidpi_factor` and `Window::hidpi_factor` return accurate values.
-- Implemented `WindowEvent::HiDpiFactorChanged` on X11.
-- On macOS, `Window::set_cursor_position` is now relative to the client area.
-- On macOS, setting the maximum and minimum dimensions now applies to the client area dimensions rather than to the window dimensions.
-- On iOS, `MonitorId::get_dimensions` has been implemented and both `MonitorId::get_hidpi_factor` and `Window::get_hidpi_factor` return accurate values.
-- On Emscripten, `MonitorId::get_hidpi_factor` now returns the same value as `Window::get_hidpi_factor` (it previously would always return 1.0).
-- **Breaking:** The entire API for sizes, positions, etc. has changed. In the majority of cases, winit produces and consumes positions and sizes as `LogicalPosition` and `LogicalSize`, respectively. The notable exception is `MonitorId` methods, which deal in `PhysicalPosition` and `PhysicalSize`. See the documentation for specifics and explanations of the types. Additionally, winit automatically conserves logical size when the DPI factor changes.
-- **Breaking:** All deprecated methods have been removed. For `Window::platform_display` and `Window::platform_window`, switch to the appropriate platform-specific `WindowExt` methods. For `Window::get_inner_size_points` and `Window::get_inner_size_pixels`, use the `LogicalSize` returned by `Window::get_inner_size` and convert as needed.
-- HiDPI support for Wayland.
-- `EventsLoop::get_available_monitors` and `EventsLoop::get_primary_monitor` now have identical counterparts on `Window`, so this information can be acquired without an `EventsLoop` borrow.
-- `AvailableMonitorsIter` now implements `Debug`.
-- Fixed quirk on macOS where certain keys would generate characters at twice the normal rate when held down.
-- On X11, all event loops now share the same `XConnection`.
-- **Breaking:** `Window::set_cursor_state` and `CursorState` enum removed in favor of the more composable `Window::grab_cursor` and `Window::hide_cursor`. As a result, grabbing the cursor no longer automatically hides it; you must call both methods to retain the old behavior on Windows and macOS. `Cursor::NoneCursor` has been removed, as it's no longer useful.
-- **Breaking:** `Window::set_cursor_position` now returns `Result<(), String>`, thus allowing for `Box<Error>` conversion via `?`.

src/changelog/v0.17.md

@@ -1,23 +0,0 @@
-## 0.17.2
-
-- On macOS, fix `<C-Tab>` so applications receive the event.
-- On macOS, fix `<Cmd-{key}>` so applications receive the event.
-- On Wayland, key press events will now be repeated.
-
-## 0.17.1
-
-- On X11, prevent a compilation failure in release mode for versions of Rust greater than or equal to 1.30.
-- Fixed deadlock that broke fullscreen mode on Windows.
-
-## 0.17.0
-
-- Cocoa and core-graphics updates.
-- Fixed thread-safety issues in several `Window` functions on Windows.
-- On MacOS, the key state for modifiers key events is now properly set.
-- On iOS, the view is now set correctly. This makes it possible to render things (instead of being stuck on a black screen), and touch events work again.
-- Added NetBSD support.
-- **Breaking:** On iOS, `UIView` is now the default root view. `WindowBuilderExt::with_root_view_class` can be used to set the root view objective-c class to `GLKView` (OpenGLES) or `MTKView` (Metal/MoltenVK).
-- On iOS, the `UIApplication` is not started until `Window::new` is called.
-- Fixed thread unsafety with cursor hiding on macOS.
-- On iOS, fixed the size of the `JmpBuf` type used for `setjmp`/`longjmp` calls. Previously this was a buffer overflow on most architectures.
-- On Windows, use cached window DPI instead of repeatedly querying the system. This fixes sporadic crashes on Windows 7.

src/changelog/v0.18.md

@@ -1,52 +0,0 @@
-## 0.18.1
-
-- On macOS, fix `Yen` (JIS) so applications receive the event.
-- On X11 with a tiling WM, fixed high CPU usage when moving windows across monitors.
-- On X11, fixed panic caused by dropping the window before running the event loop.
-- on macOS, added `WindowExt::set_simple_fullscreen` which does not require a separate space
-- Introduce `WindowBuilderExt::with_app_id` to allow setting the application ID on Wayland.
-- On Windows, catch panics in event loop child thread and forward them to the parent thread. This prevents an invocation of undefined behavior due to unwinding into foreign code.
-- On Windows, fix issue where resizing or moving window combined with grabbing the cursor would freeze program.
-- On Windows, fix issue where resizing or moving window would eat `Awakened` events.
-- On Windows, exiting fullscreen after entering fullscreen with disabled decorations no longer shrinks window.
-- On X11, fixed a segfault when using virtual monitors with XRandR.
-- Derive `Ord` and `PartialOrd` for `VirtualKeyCode` enum.
-- On Windows, fix issue where hovering or dropping a non file item would create a panic.
-- On Wayland, fix resizing and DPI calculation when a `wl_output` is removed without sending a `leave` event to the `wl_surface`, such as disconnecting a monitor from a laptop.
-- On Wayland, DPI calculation is handled by smithay-client-toolkit.
-- On X11, `WindowBuilder::with_min_dimensions` and `WindowBuilder::with_max_dimensions` now correctly account for DPI.
-- Added support for generating dummy `DeviceId`s and `WindowId`s to better support unit testing.
-- On macOS, fixed unsoundness in drag-and-drop that could result in drops being rejected.
-- On macOS, implemented `WindowEvent::Refresh`.
-- On macOS, all `MouseCursor` variants are now implemented and the cursor will no longer reset after unfocusing.
-- Removed minimum supported Rust version guarantee.
-
-## 0.18.0
-
-- **Breaking:** `image` crate upgraded to 0.20. This is exposed as part of the `icon_loading` API.
-- On Wayland, pointer events will now provide the current modifiers state.
-- On Wayland, titles will now be displayed in the window header decoration.
-- On Wayland, key repetition is now ended when keyboard loses focus.
-- On Wayland, windows will now use more stylish and modern client side decorations.
-- On Wayland, windows will use server-side decorations when available.
-- **Breaking:** Added support for F16-F24 keys (variants were added to the `VirtualKeyCode` enum).
-- Fixed graphical glitches when resizing on Wayland.
-- On Windows, fix freezes when performing certain actions after a window resize has been triggered. Reintroduces some visual artifacts when resizing.
-- Updated window manager hints under X11 to v1.5 of [Extended Window Manager Hints](https://specifications.freedesktop.org/wm-spec/wm-spec-1.5.html#idm140200472629520).
-- Added `WindowBuilderExt::with_gtk_theme_variant` to X11-specific `WindowBuilder` functions.
-- Fixed UTF8 handling bug in X11 `set_title` function.
-- On Windows, `Window::set_cursor` now applies immediately instead of requiring specific events to occur first.
-- On Windows, the `HoveredFile` and `HoveredFileCancelled` events are now implemented.
-- On Windows, fix `Window::set_maximized`.
-- On Windows 10, fix transparency (#260).
-- On macOS, fix modifiers during key repeat.
-- Implemented the `Debug` trait for `Window`, `EventsLoop`, `EventsLoopProxy` and `WindowBuilder`.
-- On X11, now a `Resized` event will always be generated after a DPI change to ensure the window's logical size is consistent with the new DPI.
-- Added further clarifications to the DPI docs.
-- On Linux, if neither X11 nor Wayland manage to initialize, the corresponding panic now consists of a single line only.
-- Add optional `serde` feature with implementations of `Serialize`/`Deserialize` for DPI types and various event types.
-- Add `PartialEq`, `Eq`, and `Hash` implementations on public types that could have them but were missing them.
-- On X11, drag-and-drop receiving an unsupported drop type can no longer cause the WM to freeze.
-- Fix issue whereby the OpenGL context would not appear at startup on macOS Mojave (#1069).
-- **Breaking:** Removed `From<NSApplicationActivationPolicy>` impl from `ActivationPolicy` on macOS.
-- On macOS, the application can request the user's attention with `WindowExt::request_user_attention`.

src/changelog/v0.19.md

@@ -1,27 +0,0 @@
-## 0.19.1
-
-- On Wayland, added a `get_wayland_display` function to `EventsLoopExt`.
-- On Windows, fix `CursorMoved(0, 0)` getting dispatched on window focus.
-- On macOS, fix command key event left and right reverse.
-- On FreeBSD, NetBSD, and OpenBSD, fix build of X11 backend.
-- On Linux, the numpad's add, subtract and divide keys are now mapped to the `Add`, `Subtract` and `Divide` virtual key codes
-- On macOS, the numpad's subtract key has been added to the `Subtract` mapping
-- On Wayland, the numpad's home, end, page up and page down keys are now mapped to the `Home`, `End`, `PageUp` and `PageDown` virtual key codes
-- On Windows, fix icon not showing up in corner of window.
-- On X11, change DPI scaling factor behavior. First, winit tries to read it from "Xft.dpi" XResource, and uses DPI calculation from xrandr dimensions as fallback behavior.
-
-## 0.19.0
-
-- On X11, we will use the faster `XRRGetScreenResourcesCurrent` function instead of `XRRGetScreenResources` when available.
-- On macOS, fix keycodes being incorrect when using a non-US keyboard layout.
-- On Wayland, fix `with_title()` not setting the windows title
-- On Wayland, add `set_wayland_theme()` to control client decoration color theme
-- Added serde serialization to `os::unix::XWindowType`.
-- **Breaking:** Remove the `icon_loading` feature and the associated `image` dependency.
-- On X11, make event loop thread safe by replacing XNextEvent with select(2) and XCheckIfEvent
-- On Windows, fix malformed function pointer typecast that could invoke undefined behavior.
-- Refactored Windows state/flag-setting code.
-- On Windows, hiding the cursor no longer hides the cursor for all Winit windows - just the one `hide_cursor` was called on.
-- On Windows, cursor grabs used to get perpetually canceled when the grabbing window lost focus. Now, cursor grabs automatically get re-initialized when the window regains focus and the mouse moves over the client area.
-- On Windows, only vertical mouse wheel events were handled. Now, horizontal mouse wheel events are also handled.
-- On Windows, ignore the AltGr key when populating the `ModifiersState` type.

src/changelog/v0.20.md

@@ -1,200 +0,0 @@
-## 0.20.0
-
-- On X11, fix `ModifiersChanged` emitting incorrect modifier change events
-- **Breaking**: Overhaul how Winit handles DPI:
-  - Window functions and events now return `PhysicalSize` instead of `LogicalSize`.
-  - Functions that take `Size` or `Position` types can now take either `Logical` or `Physical` types.
-  - `hidpi_factor` has been renamed to `scale_factor`.
-  - `HiDpiFactorChanged` has been renamed to `ScaleFactorChanged`, and lets you control how the OS
-    resizes the window in response to the change.
-  - On X11, deprecate `WINIT_HIDPI_FACTOR` environment variable in favor of `WINIT_X11_SCALE_FACTOR`.
-  - `Size` and `Position` types are now generic over their exact pixel type.
-
-## 0.20.0-alpha6
-
-- On macOS, fix `set_cursor_visible` hides cursor outside of window.
-- On macOS, fix `CursorEntered` and `CursorLeft` events fired at old window size.
-- On macOS, fix error when `set_fullscreen` is called during fullscreen transition.
-- On all platforms except mobile and WASM, implement `Window::set_minimized`.
-- On X11, fix `CursorEntered` event being generated for non-winit windows.
-- On macOS, fix crash when starting maximized without decorations.
-- On macOS, fix application not terminating on `run_return`.
-- On Wayland, fix cursor icon updates on window borders when using CSD.
-- On Wayland, under mutter(GNOME Wayland), fix CSD being behind the status bar, when starting window in maximized mode.
-- On Windows, theme the title bar according to whether the system theme is "Light" or "Dark".
-- Added `WindowEvent::ThemeChanged` variant to handle changes to the system theme. Currently only implemented on Windows.
-- **Breaking**: Changes to the `RedrawRequested` event (#1041):
-  - `RedrawRequested` has been moved from `WindowEvent` to `Event`.
-  - `EventsCleared` has been renamed to `MainEventsCleared`.
-  - `RedrawRequested` is now issued only after `MainEventsCleared`.
-  - `RedrawEventsCleared` is issued after each set of `RedrawRequested` events.
-- Implement synthetic window focus key events on Windows.
-- **Breaking**: Change `ModifiersState` to a `bitflags` struct.
-- On Windows, implement `VirtualKeyCode` translation for `LWin` and `RWin`.
-- On Windows, fix closing the last opened window causing `DeviceEvent`s to stop getting emitted.
-- On Windows, fix `Window::set_visible` not setting internal flags correctly. This resulted in some weird behavior.
-- Add `DeviceEvent::ModifiersChanged`.
-  - Deprecate `modifiers` fields in other events in favor of `ModifiersChanged`.
-- On X11, `WINIT_HIDPI_FACTOR` now dominates `Xft.dpi` when picking DPI factor for output.
-- On X11, add special value `randr` for `WINIT_HIDPI_FACTOR` to make winit use self computed DPI factor instead of the one from `Xft.dpi`.
-
-## 0.20.0-alpha5
-
-- On macOS, fix application termination on `ControlFlow::Exit`
-- On Windows, fix missing `ReceivedCharacter` events when Alt is held.
-- On macOS, stop emitting private corporate characters in `ReceivedCharacter` events.
-- On X11, fix misreporting DPI factor at startup.
-- On X11, fix events not being reported when using `run_return`.
-- On X11, fix key modifiers being incorrectly reported.
-- On X11, fix window creation hanging when another window is fullscreen.
-- On Windows, fix focusing unfocused windows when switching from fullscreen to windowed.
-- On X11, fix reporting incorrect DPI factor when waking from suspend.
-- Change `EventLoopClosed` to contain the original event.
-- **Breaking**: Add `is_synthetic` field to `WindowEvent` variant `KeyboardInput`,
-  indicating that the event is generated by winit.
-- On X11, generate synthetic key events for keys held when a window gains or loses focus.
-- On X11, issue a `CursorMoved` event when a `Touch` event occurs,
-  as X11 implicitly moves the cursor for such events.
-
-## 0.20.0-alpha4
-
-- Add web support via the 'stdweb' or 'web-sys' features
-- On Windows, implemented function to get HINSTANCE
-- On macOS, implement `run_return`.
-- On iOS, fix inverted parameter in `set_prefers_home_indicator_hidden`.
-- On X11, performance is improved when rapidly calling `Window::set_cursor_icon`.
-- On iOS, fix improper `msg_send` usage that was UB and/or would break if `!` is stabilized.
-- On Windows, unset `maximized` when manually changing the window's position or size.
-- On Windows, add touch pressure information for touch events.
-- On macOS, differentiate between `CursorIcon::Grab` and `CursorIcon::Grabbing`.
-- On Wayland, fix event processing sometimes stalling when using OpenGL with vsync.
-- Officially remove the Emscripten backend.
-- On Windows, fix handling of surrogate pairs when dispatching `ReceivedCharacter`.
-- On macOS 10.15, fix freeze upon exiting exclusive fullscreen mode.
-- On iOS, fix panic upon closing the app.
-- On X11, allow setting multiple `XWindowType`s.
-- On iOS, fix null window on initial `HiDpiFactorChanged` event.
-- On Windows, fix fullscreen window shrinking upon getting restored to a normal window.
-- On macOS, fix events not being emitted during modal loops, such as when windows are being resized
-  by the user.
-- On Windows, fix hovering the mouse over the active window creating an endless stream of CursorMoved events.
-- Always dispatch a `RedrawRequested` event after creating a new window.
-- On X11, return dummy monitor data to avoid panicking when no monitors exist.
-- On X11, prevent stealing input focus when creating a new window.
-  Only steal input focus when entering fullscreen mode.
-- On Wayland, fixed DeviceEvents for relative mouse movement is not always produced
-- On Wayland, add support for set_cursor_visible and set_cursor_grab.
-- On Wayland, fixed DeviceEvents for relative mouse movement is not always produced.
-- Removed `derivative` crate dependency.
-- On Wayland, add support for set_cursor_icon.
-- Use `impl Iterator<Item = MonitorHandle>` instead of `AvailableMonitorsIter` consistently.
-- On macOS, fix fullscreen state being updated after entering fullscreen instead of before,
-  resulting in `Window::fullscreen` returning the old state in `Resized` events instead of
-  reflecting the new fullscreen state
-- On X11, fix use-after-free during window creation
-- On Windows, disable monitor change keyboard shortcut while in exclusive fullscreen.
-- On Windows, ensure that changing a borderless fullscreen window's monitor via keyboard shortcuts keeps the window fullscreen on the new monitor.
-- Prevent `EventLoop::new` and `EventLoop::with_user_event` from getting called outside the main thread.
-  - This is because some platforms cannot run the event loop outside the main thread. Preventing this
-    reduces the potential for cross-platform compatibility gotchyas.
-- On Windows and Linux X11/Wayland, add platform-specific functions for creating an `EventLoop` outside the main thread.
-- On Wayland, drop resize events identical to the current window size.
-- On Windows, fix window rectangle not getting set correctly on high-DPI systems.
-
-## 0.20.0-alpha3
-
-- On macOS, drop the run closure on exit.
-- On Windows, location of `WindowEvent::Touch` are window client coordinates instead of screen coordinates.
-- On X11, fix delayed events after window redraw.
-- On macOS, add `WindowBuilderExt::with_disallow_hidpi` to have the option to turn off best resolution openGL surface.
-- On Windows, screen saver won't start if the window is in fullscreen mode.
-- Change all occurrences of the `new_user_event` method to `with_user_event`.
-- On macOS, the dock and the menu bar are now hidden in fullscreen mode.
-- `Window::set_fullscreen` now takes `Option<Fullscreen>` where `Fullscreen`
-  consists of `Fullscreen::Exclusive(VideoMode)` and
-  `Fullscreen::Borderless(MonitorHandle)` variants.
-  - Adds support for exclusive fullscreen mode.
-- On iOS, add support for hiding the home indicator.
-- On iOS, add support for deferring system gestures.
-- On iOS, fix a crash that occurred while acquiring a monitor's name.
-- On iOS, fix armv7-apple-ios compile target.
-- Removed the `T: Clone` requirement from the `Clone` impl of `EventLoopProxy<T>`.
-- On iOS, disable overscan compensation for external displays (removes black
-  bars surrounding the image).
-- On Linux, the functions `is_wayland`, `is_x11`, `xlib_xconnection` and `wayland_display` have been moved to a new `EventLoopWindowTargetExtUnix` trait.
-- On iOS, add `set_prefers_status_bar_hidden` extension function instead of
-  hijacking `set_decorations` for this purpose.
-- On macOS and iOS, corrected the auto trait impls of `EventLoopProxy`.
-- On iOS, add touch pressure information for touch events.
-- Implement `raw_window_handle::HasRawWindowHandle` for `Window` type on all supported platforms.
-- On macOS, fix the signature of `-[NSView drawRect:]`.
-- On iOS, fix the behavior of `ControlFlow::Poll`. It wasn't polling if that was the only mode ever used by the application.
-- On iOS, fix DPI sent out by views on creation was `0.0` - now it gives a reasonable number.
-- On iOS, RedrawRequested now works for gl/metal backed views.
-- On iOS, RedrawRequested is generally ordered after EventsCleared.
-
-## 0.20.0-alpha2
-
-- On X11, non-resizable windows now have maximize explicitly disabled.
-- On Windows, support paths longer than MAX_PATH (260 characters) in `WindowEvent::DroppedFile`
-and `WindowEvent::HoveredFile`.
-- On Mac, implement `DeviceEvent::Button`.
-- Change `Event::Suspended(true / false)` to `Event::Suspended` and `Event::Resumed`.
-- On X11, fix sanity check which checks that a monitor's reported width and height (in millimeters) are non-zero when calculating the DPI factor.
-- Revert the use of invisible surfaces in Wayland, which introduced graphical glitches with OpenGL (#835)
-- On X11, implement `_NET_WM_PING` to allow desktop environment to kill unresponsive programs.
-- On Windows, when a window is initially invisible, it won't take focus from the existing visible windows.
-- On Windows, fix multiple calls to `request_redraw` during `EventsCleared` sending multiple `RedrawRequested events.`
-- On Windows, fix edge case where `RedrawRequested` could be dispatched before input events in event loop iteration.
-- On Windows, fix timing issue that could cause events to be improperly dispatched after `RedrawRequested` but before `EventsCleared`.
-- On macOS, drop unused Metal dependency.
-- On Windows, fix the trail effect happening on transparent decorated windows. Borderless (or un-decorated) windows were not affected.
-- On Windows, fix `with_maximized` not properly setting window size to entire window.
-- On macOS, change `WindowExtMacOS::request_user_attention()` to take an `enum` instead of a `bool`.
-
-## 0.20.0-alpha1
-
-- Changes below are considered **breaking**.
-- Change all occurrences of `EventsLoop` to `EventLoop`.
-- Previously flat API is now exposed through `event`, `event_loop`, `monitor`, and `window` modules.
-- `os` module changes:
-  - Renamed to `platform`.
-  - All traits now have platform-specific suffixes.
-  - Exposes new `desktop` module on Windows, Mac, and Linux.
-- Changes to event loop types:
-  - `EventLoopProxy::wakeup` has been removed in favor of `send_event`.
-  - **Major:** New `run` method drives winit event loop.
-    - Returns `!` to ensure API behaves identically across all supported platforms.
-      - This allows `emscripten` implementation to work without lying about the API.
-    - `ControlFlow`'s variants have been replaced with `Wait`, `WaitUntil(Instant)`, `Poll`, and `Exit`.
-      - Is read after `EventsCleared` is processed.
-      - `Wait` waits until new events are available.
-      - `WaitUntil` waits until either new events are available or the provided time has been reached.
-      - `Poll` instantly resumes the event loop.
-      - `Exit` aborts the event loop.
-    - Takes a closure that implements `'static + FnMut(Event<T>, &EventLoop<T>, &mut ControlFlow)`.
-      - `&EventLoop<T>` is provided to allow new `Window`s to be created.
-  - **Major:** `platform::desktop` module exposes `EventLoopExtDesktop` trait with `run_return` method.
-    - Behaves identically to `run`, but returns control flow to the calling context and can take non-`'static` closures.
-  - `EventLoop`'s `poll_events` and `run_forever` methods have been removed in favor of `run` and `run_return`.
-- Changes to events:
-  - Remove `Event::Awakened` in favor of `Event::UserEvent(T)`.
-    - Can be sent with `EventLoopProxy::send_event`.
-  - Rename `WindowEvent::Refresh` to `WindowEvent::RedrawRequested`.
-    - `RedrawRequested` can be sent by the user with the `Window::request_redraw` method.
-  - `EventLoop`, `EventLoopProxy`, and `Event` are now generic over `T`, for use in `UserEvent`.
-  - **Major:** Add `NewEvents(StartCause)`, `EventsCleared`, and `LoopDestroyed` variants to `Event`.
-    - `NewEvents` is emitted when new events are ready to be processed by event loop.
-      - `StartCause` describes why new events are available, with `ResumeTimeReached`, `Poll`, `WaitCancelled`, and `Init` (sent once at start of loop).
-    - `EventsCleared` is emitted when all available events have been processed.
-      - Can be used to perform logic that depends on all events being processed (e.g. an iteration of a game loop).
-    - `LoopDestroyed` is emitted when the `run` or `run_return` method is about to exit.
-- Rename `MonitorId` to `MonitorHandle`.
-- Removed `serde` implementations from `ControlFlow`.
-- Rename several functions to improve both internal consistency and compliance with Rust API guidelines.
-- Remove `WindowBuilder::multitouch` field, since it was only implemented on a few platforms. Multitouch is always enabled now.
-- **Breaking:** On macOS, change `ns` identifiers to use snake_case for consistency with iOS's `ui` identifiers.
-- Add `MonitorHandle::video_modes` method for retrieving supported video modes for the given monitor.
-- On Wayland, the window now exists even if nothing has been drawn.
-- On Windows, fix initial dimensions of a fullscreen window.
-- On Windows, Fix transparent borderless windows rendering wrong.

src/changelog/v0.21.md

@@ -1,16 +0,0 @@
-## 0.21.0
-
-- On Windows, fixed "error: linking with `link.exe` failed: exit code: 1120" error on older versions of windows.
-- On macOS, fix set_minimized(true) works only with decorations.
-- On macOS, add `hide_application` to `EventLoopWindowTarget` via a new `EventLoopWindowTargetExtMacOS` trait. `hide_application` will hide the entire application by calling `-[NSApplication hide: nil]`.
-- On macOS, fix not sending ReceivedCharacter event for specific keys combinations.
-- On macOS, fix `CursorMoved` event reporting the cursor position using logical coordinates.
-- On macOS, fix issue where unbundled applications would sometimes open without being focused.
-- On macOS, fix `run_return` does not return unless it receives a message.
-- On Windows, fix bug where `RedrawRequested` would only get emitted every other iteration of the event loop.
-- On X11, fix deadlock on window state when handling certain window events.
-- `WindowBuilder` now implements `Default`.
-- **Breaking:** `WindowEvent::CursorMoved` changed to `f64` units, preserving high-precision data supplied by most backends
-- On Wayland, fix coordinates in mouse events when scale factor isn't 1
-- On Web, add the ability to provide a custom canvas
-- **Breaking:** On Wayland, the `WaylandTheme` struct has been replaced with a `Theme` trait, allowing for extra configuration

src/changelog/v0.22.md

@@ -1,37 +0,0 @@
-## 0.22.2
-
-- Added Clone implementation for 'static events.
-- On Windows, fix window intermittently hanging when `ControlFlow` was set to `Poll`.
-- On Windows, fix `WindowBuilder::with_maximized` being ignored.
-- On Android, minimal platform support.
-- On iOS, touch positions are now properly converted to physical pixels.
-- On macOS, updated core-* dependencies and cocoa
-
-## 0.22.1
-
-- On X11, fix `ResumeTimeReached` being fired too early.
-- On Web, replaced zero timeout for `ControlFlow::Poll` with `requestAnimationFrame`
-- On Web, fix a possible panic during event handling
-- On macOS, fix `EventLoopProxy` leaking memory for every instance.
-
-## 0.22.0
-
-- On Windows, fix minor timing issue in wait_until_time_or_msg
-- On Windows, rework handling of request_redraw() to address panics.
-- On macOS, fix `set_simple_screen` to remember frame excluding title bar.
-- On Wayland, fix coordinates in touch events when scale factor isn't 1.
-- On Wayland, fix color from `close_button_icon_color` not applying.
-- Ignore locale if unsupported by X11 backend
-- On Wayland, Add HiDPI cursor support
-- On Web, add the ability to query "Light" or "Dark" system theme send `ThemeChanged` on change.
-- Fix `Event::to_static` returning `None` for user events.
-- On Wayland, Hide CSD for fullscreen windows.
-- On Windows, ignore spurious mouse move messages.
-- **Breaking:** Move `ModifiersChanged` variant from `DeviceEvent` to `WindowEvent`.
-- On Windows, add `IconExtWindows` trait which exposes creating an `Icon` from an external file or embedded resource
-- Add `BadIcon::OsError` variant for when OS icon functionality fails
-- On Windows, fix crash at startup on systems that do not properly support Windows' Dark Mode
-- Revert On macOS, fix not sending ReceivedCharacter event for specific keys combinations.
-- on macOS, fix incorrect ReceivedCharacter events for some key combinations.
-- **Breaking:** Use `i32` instead of `u32` for position type in `WindowEvent::Moved`.
-- On macOS, a mouse motion event is now generated before every mouse click.

src/changelog/v0.23.md

@@ -1,65 +0,0 @@
-## 0.23.0
-
-- On iOS, fixed support for the "Debug View Hierarchy" feature in Xcode.
-- On all platforms, `available_monitors` and `primary_monitor` are now on `EventLoopWindowTarget` rather than `EventLoop` to list monitors event in the event loop.
-- On Unix, X11 and Wayland are now optional features (enabled by default)
-- On X11, fix deadlock when calling `set_fullscreen_inner`.
-- On Web, prevent the webpage from scrolling when the user is focused on a winit canvas
-- On Web, calling `window.set_cursor_icon` no longer breaks HiDPI scaling
-- On Windows, drag and drop is now optional (enabled by default) and can be disabled with `WindowBuilderExtWindows::with_drag_and_drop(false)`.
-- On Wayland, fix deadlock when calling to `set_inner_size` from a callback.
-- On macOS, add `hide__other_applications` to `EventLoopWindowTarget` via existing `EventLoopWindowTargetExtMacOS` trait. `hide_other_applications` will hide other applications by calling `-[NSApplication hideOtherApplications: nil]`.
-- On android added support for `run_return`.
-- On MacOS, Fixed fullscreen and dialog support for `run_return`.
-- On Windows, fix bug where we'd try to emit `MainEventsCleared` events during nested win32 event loops.
-- On Web, use mouse events if pointer events aren't supported. This affects Safari.
-- On Windows, `set_ime_position` is now a no-op instead of a runtime crash.
-- On Android, `set_fullscreen` is now a no-op instead of a runtime crash.
-- On iOS and Android, `set_inner_size` is now a no-op instead of a runtime crash.
-- On Android, fix `ControlFlow::Poll` not polling the Android event queue.
-- On macOS, add `NSWindow.hasShadow` support.
-- On Web, fix vertical mouse wheel scrolling being inverted.
-- On Web, implement mouse capturing for click-dragging out of the canvas.
-- On Web, fix `ControlFlow::Exit` not properly handled.
-- On Web (web-sys only), send `WindowEvent::ScaleFactorChanged` event when `window.devicePixelRatio` is changed.
-- **Breaking:** On Web, `set_cursor_position` and `set_cursor_grab` will now always return an error.
-- **Breaking:** `PixelDelta` scroll events now return a `PhysicalPosition`.
-- On NetBSD, fixed crash due to incorrect detection of the main thread.
-- **Breaking:** On X11, `-` key is mapped to the `Minus` virtual key code, instead of `Subtract`.
-- On macOS, fix inverted horizontal scroll.
-- **Breaking:** `current_monitor` now returns `Option<MonitorHandle>`.
-- **Breaking:** `primary_monitor` now returns `Option<MonitorHandle>`.
-- On macOS, updated core-* dependencies and cocoa.
-- Bump `parking_lot` to 0.11
-- On Android, bump `ndk`, `ndk-sys` and `ndk-glue` to 0.2. Checkout the new ndk-glue main proc attribute.
-- On iOS, fixed starting the app in landscape where the view still had portrait dimensions.
-- Deprecate the stdweb backend, to be removed in a future release
-- **Breaking:** Prefixed virtual key codes `Add`, `Multiply`, `Divide`, `Decimal`, and `Subtract` with `Numpad`.
-- Added `Asterisk` and `Plus` virtual key codes.
-- On Web (web-sys only), the `Event::LoopDestroyed` event is correctly emitted when leaving the page.
-- On Web, the `WindowEvent::Destroyed` event now gets emitted when a `Window` is dropped.
-- On Web (web-sys only), the event listeners are now removed when a `Window` is dropped or when the event loop is destroyed.
-- On Web, the event handler closure passed to `EventLoop::run` now gets dropped after the event loop is destroyed.
-- **Breaking:** On Web, the canvas element associated to a `Window` is no longer removed from the DOM when the `Window` is dropped.
-- On Web, `WindowEvent::Resized` is now emitted when `Window::set_inner_size` is called.
-- **Breaking:** `Fullscreen` enum now uses `Borderless(Option<MonitorHandle>)` instead of `Borderless(MonitorHandle)` to allow picking the current monitor.
-- On MacOS, fix `WindowEvent::Moved` ignoring the scale factor.
-- On Wayland, add missing virtual keycodes.
-- On Wayland, implement proper `set_cursor_grab`.
-- On Wayland, the cursor will use similar icons if the requested one isn't available.
-- On Wayland, right clicking on client side decorations will request application menu.
-- On Wayland, fix tracking of window size after state changes.
-- On Wayland, fix client side decorations not being hidden properly in fullscreen.
-- On Wayland, fix incorrect size event when entering fullscreen with client side decorations.
-- On Wayland, fix `resizable` attribute not being applied properly on startup.
-- On Wayland, fix disabled repeat rate not being handled.
-- On Wayland, fix decoration buttons not working after tty switch.
-- On Wayland, fix scaling not being applied on output re-enable.
-- On Wayland, fix crash when `XCURSOR_SIZE` is `0`.
-- On Wayland, fix pointer getting created in some cases without pointer capability.
-- On Wayland, on kwin, fix space between window and decorations on startup.
-- **Breaking:** On Wayland, `Theme` trait was reworked.
-- On Wayland, disable maximize button for non-resizable window.
-- On Wayland, added support for `set_ime_position`.
-- On Wayland, fix crash on startup since GNOME 3.37.90.
-- On X11, fix incorrect modifiers state on startup.

src/changelog/v0.24.md

@@ -1,28 +0,0 @@
-## 0.24.0
-
-- On Windows, fix applications not exiting gracefully due to thread_event_target_callback accessing corrupted memory.
-- On Windows, implement `Window::set_ime_position`.
-- **Breaking:** On Windows, Renamed `WindowBuilderExtWindows`'s `is_dark_mode` to `theme`.
-- **Breaking:** On Windows, renamed `WindowBuilderExtWindows::is_dark_mode` to `theme`.
-- On Windows, add `WindowBuilderExtWindows::with_theme` to set a preferred theme.
-- On Windows, fix bug causing message boxes to appear delayed.
-- On Android, calling `WindowEvent::Focused` now works properly instead of always returning false.
-- On Windows, fix Alt-Tab behaviour by removing borderless fullscreen "always on top" flag.
-- On Windows, fix bug preventing windows with transparency enabled from having fully-opaque regions.
-- **Breaking:** On Windows, include prefix byte in scancodes.
-- On Wayland, fix window not being resizeable when using `WindowBuilder::with_min_inner_size`.
-- On Unix, fix cross-compiling to wasm32 without enabling X11 or Wayland.
-- On Windows, fix use-after-free crash during window destruction.
-- On Web, fix `WindowEvent::ReceivedCharacter` never being sent on key input.
-- On macOS, fix compilation when targeting aarch64.
-- On X11, fix `Window::request_redraw` not waking the event loop.
-- On Wayland, the keypad arrow keys are now recognized.
-- **Breaking** Rename `desktop::EventLoopExtDesktop` to `run_return::EventLoopExtRunReturn`.
-- Added `request_user_attention` method to `Window`.
-- **Breaking:** On macOS, removed `WindowExt::request_user_attention`, use `Window::request_user_attention`.
-- **Breaking:** On X11, removed `WindowExt::set_urgent`, use `Window::request_user_attention`.
-- On Wayland, default font size in CSD increased from 11 to 17.
-- On Windows, fix bug causing message boxes to appear delayed.
-- On Android, support multi-touch.
-- On Wayland, extra mouse buttons are not dropped anymore.
-- **Breaking**: `MouseButton::Other` now uses `u16`.

src/changelog/v0.25.md

@@ -1,31 +0,0 @@
-## 0.25.0
-
-- **Breaking:** On macOS, replace `WindowBuilderExtMacOS::with_activation_policy` with `EventLoopExtMacOS::set_activation_policy`
-- On macOS, wait with activating the application until the application has initialized.
-- On macOS, fix creating new windows when the application has a main menu.
-- On Windows, fix fractional deltas for mouse wheel device events.
-- On macOS, fix segmentation fault after dropping the main window.
-- On Android, `InputEvent::KeyEvent` is partially implemented providing the key scancode.
-- Added `is_maximized` method to `Window`.
-- On Windows, fix bug where clicking the decoration bar would make the cursor blink.
-- On Windows, fix bug causing newly created windows to erroneously display the "wait" (spinning) cursor.
-- On macOS, wake up the event loop immediately when a redraw is requested.
-- On Windows, change the default window size (1024x768) to match the default on other desktop platforms (800x600).
-- On Windows, fix bug causing mouse capture to not be released.
-- On Windows, fix fullscreen not preserving minimized/maximized state.
-- On Android, unimplemented events are marked as unhandled on the native event loop.
-- On Windows, added `WindowBuilderExtWindows::with_menu` to set a custom menu at window creation time.
-- On Android, bump `ndk` and `ndk-glue` to 0.3: use predefined constants for event `ident`.
-- On macOS, fix objects captured by the event loop closure not being dropped on panic.
-- On Windows, fixed `WindowEvent::ThemeChanged` not properly firing and fixed `Window::theme` returning the wrong theme.
-- On Web, added support for `DeviceEvent::MouseMotion` to listen for relative mouse movements.
-- Added `WindowBuilder::with_position` to allow setting the position of a `Window` on creation. Supported on Windows, macOS and X11.
-- Added `Window::drag_window`. Implemented on Windows, macOS, X11 and Wayland.
-- On X11, bump `mio` to 0.7.
-- On Windows, added `WindowBuilderExtWindows::with_owner_window` to allow creating popup windows.
-- On Windows, added `WindowExtWindows::set_enable` to allow creating modal popup windows.
-- On macOS, emit `RedrawRequested` events immediately while the window is being resized.
-- Implement `Default`, `Hash`, and `Eq` for `LogicalPosition`, `PhysicalPosition`, `LogicalSize`, and `PhysicalSize`.
-- On macOS, initialize the Menu Bar with minimal defaults. (Can be prevented using `enable_default_menu_creation`)
-- On macOS, change the default behavior for first click when the window was unfocused. Now the window becomes focused and then emits a `MouseInput` event on a "first mouse click".
-- Implement mint (math interoperability standard types) conversions (under feature flag `mint`).

src/changelog/v0.26.md

@@ -1,36 +0,0 @@
-## 0.26.1
-
-- Fix linking to the `ColorSync` framework on macOS 10.7, and in newer Rust versions.
-- On Web, implement cursor grabbing through the pointer lock API.
-- On X11, add mappings for numpad comma, numpad enter, numlock and pause.
-- On macOS, fix Pinyin IME input by reverting a change that intended to improve IME.
-- On Windows, fix a crash with transparent windows on Windows 11.
-
-## 0.26.0
-
-- Update `raw-window-handle` to `v0.4`. This is _not_ a breaking change, we still implement `HasRawWindowHandle` from `v0.3`, see [rust-windowing/raw-window-handle#74](https://github.com/rust-windowing/raw-window-handle/pull/74). Note that you might have to run `cargo update -p raw-window-handle` after upgrading.
-- On X11, bump `mio` to 0.8.
-- On Android, fixed `WindowExtAndroid::config` initially returning an empty `Configuration`.
-- On Android, fixed `Window::scale_factor` and `MonitorHandle::scale_factor` initially always returning 1.0.
-- On X11, select an appropriate visual for transparency if is requested
-- On Wayland and X11, fix diagonal window resize cursor orientation.
-- On macOS, drop the event callback before exiting.
-- On Android, implement `Window::request_redraw`
-- **Breaking:** On Web, remove the `stdweb` backend.
-- Added `Window::focus_window`to bring the window to the front and set input focus.
-- On Wayland and X11, implement `is_maximized` method on `Window`.
-- On Windows, prevent ghost window from showing up in the taskbar after either several hours of use or restarting `explorer.exe`.
-- On macOS, fix issue where `ReceivedCharacter` was not being emitted during some key repeat events.
-- On Wayland, load cursor icons `hand2` and `hand1` for `CursorIcon::Hand`.
-- **Breaking:** On Wayland, Theme trait and its support types are dropped.
-- On Wayland, bump `smithay-client-toolkit` to 0.15.1.
-- On Wayland, implement `request_user_attention` with `xdg_activation_v1`.
-- On X11, emit missing `WindowEvent::ScaleFactorChanged` when the only monitor gets reconnected.
-- On X11, if RANDR based scale factor is higher than 20 reset it to 1
-- On Wayland, add an enabled-by-default feature called `wayland-dlopen` so users can opt out of using `dlopen` to load system libraries.
-- **Breaking:** On Android, bump `ndk` and `ndk-glue` to 0.5.
-- On Windows, increase wait timer resolution for more accurate timing when using `WaitUntil`.
-- On macOS, fix native file dialogs hanging the event loop.
-- On Wayland, implement a workaround for wrong configure size when using `xdg_decoration` in `kwin_wayland`
-- On macOS, fix an issue that prevented the menu bar from showing in borderless fullscreen mode.
-- On X11, EINTR while polling for events no longer causes a panic. Instead it will be treated as a spurious wakeup.

src/changelog/v0.27.md

@@ -1,107 +0,0 @@
-## 0.27.5
-
-- On Wayland, fix byte offset in `Ime::Preedit` pointing to invalid bytes.
-
-## 0.27.4
-
-- On Windows, emit `ReceivedCharacter` events on system keybindings.
-- On Windows, fixed focus event emission on minimize.
-- On X11, fixed IME crashing during reload.
-
-## 0.27.3
-
-- On Windows, added `WindowExtWindows::set_undecorated_shadow` and `WindowBuilderExtWindows::with_undecorated_shadow` to draw the drop shadow behind a borderless window.
-- On Windows, fixed default window features (ie snap, animations, shake, etc.) when decorations are disabled.
-- On Windows, fixed ALT+Space shortcut to open window menu.
-- On Wayland, fixed `Ime::Preedit` not being sent on IME reset.
-- Fixed unbound version specified for `raw-window-handle` leading to compilation failures.
-- Empty `Ime::Preedit` event will be sent before `Ime::Commit` to help clearing preedit.
-- On X11, fixed IME context picking by querying for supported styles beforehand.
-
-## 0.27.2
-
-- On macOS, fixed touch phase reporting when scrolling.
-- On X11, fix min, max and resize increment hints not persisting for resizable windows (e.g. on DPI change).
-- On Windows, respect min/max inner sizes when creating the window.
-- For backwards compatibility, `Window` now (additionally) implements the old version (`0.4`) of the `HasRawWindowHandle` trait
-- On Windows, added support for `EventLoopWindowTarget::set_device_event_filter`.
-- On Wayland, fix user requested `WindowEvent::RedrawRequested` being delayed by a frame.
-
-## 0.27.1
-
-- The minimum supported Rust version was lowered to `1.57.0` and now explicitly tested.
-- On X11, fix crash on start due to inability to create an IME context without any preedit.
-
-## 0.27.0
-
-- On Windows, fix hiding a maximized window.
-- On Android, `ndk-glue`'s `NativeWindow` lock is now held between `Event::Resumed` and `Event::Suspended`.
-- On Web, added `EventLoopExtWebSys` with a `spawn` method to start the event loop without throwing an exception.
-- Added `WindowEvent::Occluded(bool)`, currently implemented on macOS and X11.
-- On X11, fix events for caps lock key not being sent
-- Build docs on `docs.rs` for iOS and Android as well.
-- **Breaking:** Removed the `WindowAttributes` struct, since all its functionality is accessible from `WindowBuilder`.
-- Added `WindowBuilder::transparent` getter to check if the user set `transparent` attribute.
-- On macOS, Fix emitting `Event::LoopDestroyed` on CMD+Q.
-- On macOS, fixed an issue where having multiple windows would prevent run_return from ever returning.
-- On Wayland, fix bug where the cursor wouldn't hide in GNOME.
-- On macOS, Windows, and Wayland, add `set_cursor_hittest` to let the window ignore mouse events.
-- On Windows, added `WindowExtWindows::set_skip_taskbar` and `WindowBuilderExtWindows::with_skip_taskbar`.
-- On Windows, added `EventLoopBuilderExtWindows::with_msg_hook`.
-- On Windows, remove internally unique DC per window.
-- On macOS, remove the need to call `set_ime_position` after moving the window.
-- Added `Window::is_visible`.
-- Added `Window::is_resizable`.
-- Added `Window::is_decorated`.
-- On X11, fix for repeated event loop iteration when `ControlFlow` was `Wait`
-- On X11, fix scale factor calculation when the only monitor is reconnected
-- On Wayland, report unaccelerated mouse deltas in `DeviceEvent::MouseMotion`.
-- On Web, a focused event is manually generated when a click occurs to emulate behaviour of other backends.
-- **Breaking:** Bump `ndk` version to 0.6, ndk-sys to `v0.3`, `ndk-glue` to `0.6`.
-- Remove no longer needed `WINIT_LINK_COLORSYNC` environment variable.
-- **Breaking:** Rename the `Exit` variant of `ControlFlow` to `ExitWithCode`, which holds a value to control the exit code after running. Add an `Exit` constant which aliases to `ExitWithCode(0)` instead to avoid major breakage. This shouldn't affect most existing programs.
-- Add `EventLoopBuilder`, which allows you to create and tweak the settings of an event loop before creating it.
-- Deprecated `EventLoop::with_user_event`; use `EventLoopBuilder::with_user_event` instead.
-- **Breaking:** Replaced `EventLoopExtMacOS` with `EventLoopBuilderExtMacOS` (which also has renamed methods).
-- **Breaking:** Replaced `EventLoopExtWindows` with `EventLoopBuilderExtWindows` (which also has renamed methods).
-- **Breaking:** Replaced `EventLoopExtUnix` with `EventLoopBuilderExtUnix` (which also has renamed methods).
-- **Breaking:** The platform specific extensions for Windows `winit::platform::windows` have changed. All `HANDLE`-like types e.g. `HWND` and `HMENU` were converted from winapi types or `*mut c_void` to `isize`. This was done to be consistent with the type definitions in windows-sys and to not expose internal dependencies.
-- The internal bindings to the [Windows API](https://docs.microsoft.com/en-us/windows/) were changed from the unofficial [winapi](https://github.com/retep998/winapi-rs) bindings to the official Microsoft [windows-sys](https://github.com/microsoft/windows-rs) bindings.
-- On Wayland, fix polling during consecutive `EventLoop::run_return` invocations.
-- On Windows, fix race issue creating fullscreen windows with `WindowBuilder::with_fullscreen`
-- On Android, `virtual_keycode` for `KeyboardInput` events is now filled in where a suitable match is found.
-- Added helper methods on `ControlFlow` to set its value.
-- On Wayland, fix `TouchPhase::Ended` always reporting the location of the first touch down, unless the compositor
-  sent a cancel or frame event.
-- On iOS, send `RedrawEventsCleared` even if there are no redraw events, consistent with other platforms.
-- **Breaking:** Replaced `Window::with_app_id` and `Window::with_class` with `Window::with_name` on `WindowBuilderExtUnix`.
-- On Wayland, fallback CSD was replaced with proper one:
-  - `WindowBuilderExtUnix::with_wayland_csd_theme` to set color theme in builder.
-  - `WindowExtUnix::wayland_set_csd_theme` to set color theme when creating a window.
-  - `WINIT_WAYLAND_CSD_THEME` env variable was added, it can be used to set "dark"/"light" theme in apps that don't expose theme setting.
-  - `wayland-csd-adwaita` feature that enables proper CSD with title rendering using FreeType system library.
-  - `wayland-csd-adwaita-notitle` feature that enables CSD but without title rendering.
-- On Wayland and X11, fix window not resizing with `Window::set_inner_size` after calling `Window:set_resizable(false)`.
-- On Windows, fix wrong fullscreen monitors being recognized when handling WM_WINDOWPOSCHANGING messages
-- **Breaking:** Added new `WindowEvent::Ime` supported on desktop platforms.
-- Added `Window::set_ime_allowed` supported on desktop platforms.
-- **Breaking:** IME input on desktop platforms won't be received unless it's explicitly allowed via `Window::set_ime_allowed` and new `WindowEvent::Ime` events are handled.
-- On macOS, `WindowEvent::Resized` is now emitted in `frameDidChange` instead of `windowDidResize`.
-- **Breaking:** On X11, device events are now ignored for unfocused windows by default, use `EventLoopWindowTarget::set_device_event_filter` to set the filter level.
-- Implemented `Default` on `EventLoop<()>`.
-- Implemented `Eq` for `Fullscreen`, `Theme`, and `UserAttentionType`.
-- **Breaking:** `Window::set_cursor_grab` now accepts `CursorGrabMode` to control grabbing behavior.
-- On Wayland, add support for `Window::set_cursor_position`.
-- Fix on macOS `WindowBuilder::with_disallow_hidpi`, setting true or false by the user no matter the SO default value.
-- `EventLoopBuilder::build` will now panic when the `EventLoop` is being created more than once.
-- Added `From<u64>` for `WindowId` and `From<WindowId>` for `u64`.
-- Added `MonitorHandle::refresh_rate_millihertz` to get monitor's refresh rate.
-- **Breaking**, Replaced `VideoMode::refresh_rate` with `VideoMode::refresh_rate_millihertz` providing better precision.
-- On Web, add `with_prevent_default` and `with_focusable` to `WindowBuilderExtWebSys` to control whether events should be propagated.
-- On Windows, fix focus events being sent to inactive windows.
-- **Breaking**, update `raw-window-handle` to `v0.5` and implement `HasRawDisplayHandle` for `Window` and `EventLoopWindowTarget`.
-- On X11, add function `register_xlib_error_hook` into `winit::platform::unix` to subscribe for errors coming from Xlib.
-- On Android, upgrade `ndk` and `ndk-glue` dependencies to the recently released `0.7.0`.
-- All platforms can now be relied on to emit a `Resumed` event. Applications are recommended to lazily initialize graphics state and windows on first resume for portability.
-- **Breaking:**: Reverse horizontal scrolling sign in `MouseScrollDelta` to match the direction of vertical scrolling. A positive X value now means moving the content to the right. The meaning of vertical scrolling stays the same: a positive Y value means moving the content down.
-- On MacOS, fix deadlock when calling `set_maximized` from event loop.

src/changelog/v0.28.md

@@ -1,100 +0,0 @@
-## 0.28.7
-
-- Fix window size sometimes being invalid when resizing on macOS 14 Sonoma.
-
-## 0.28.6
-
-- On macOS, fixed memory leak when getting monitor handle.
-- On macOS, fix `Backspace` being emitted when clearing preedit with it.
-
-## 0.28.5
-
-- On macOS, fix `key_up` being ignored when `Ime` is disabled.
-
-## 0.28.4
-
-- On macOS, fix empty marked text blocking regular input.
-- On macOS, fix potential panic when getting refresh rate.
-- On macOS, fix crash when calling `Window::set_ime_position` from another thread.
-
-## 0.28.3
-
-- Fix macOS memory leaks.
-
-## 0.28.2
-
-- Implement `HasRawDisplayHandle` for `EventLoop`.
-- On macOS, set resize increments only for live resizes.
-- On Wayland, fix rare crash on DPI change
-- Web: Added support for `Window::theme`.
-- On Wayland, fix rounding issues when doing resize.
-- On macOS, fix wrong focused state on startup.
-- On Windows, fix crash on setting taskbar when using Visual Studio debugger.
-- On macOS, resize simple fullscreen windows on windowDidChangeScreen events.
-
-## 0.28.1
-
-- On Wayland, fix crash when dropping a window in multi-window setup.
-
-## 0.28.0
-
-- On macOS, fixed `Ime::Commit` persisting for all input after interacting with `Ime`.
-- On macOS, added `WindowExtMacOS::option_as_alt` and `WindowExtMacOS::set_option_as_alt`.
-- On Windows, fix window size for maximized, undecorated windows.
-- On Windows and macOS, add `WindowBuilder::with_active`.
-- Add `Window::is_minimized`.
-- On X11, fix errors handled during `register_xlib_error_hook` invocation bleeding into winit.
-- Add `Window::has_focus`.
-- On Windows, fix `Window::set_minimized(false)` not working for windows minimized by `Win + D` hotkey.
-- **Breaking:** On Web, touch input no longer fires `WindowEvent::Cursor*`, `WindowEvent::MouseInput`, or `DeviceEvent::MouseMotion` like other platforms, but instead it fires `WindowEvent::Touch`.
-- **Breaking:** Removed platform specific `WindowBuilder::with_parent` API in favor of `WindowBuilder::with_parent_window`.
-- On Windows, retain `WS_MAXIMIZE` window style when un-minimizing a maximized window.
-- On Windows, fix left mouse button release event not being sent after `Window::drag_window`.
-- On macOS, run most actions on the main thread, which is strictly more correct, but might make multithreaded applications block slightly more.
-- On macOS, fix panic when getting current monitor without any monitor attached.
-- On Windows and MacOS, add API to enable/disable window buttons (close, minimize, ...etc).
-- On Windows, macOS, X11 and Wayland, add `Window::set_theme`.
-- **Breaking:** Remove `WindowExtWayland::wayland_set_csd_theme` and `WindowBuilderExtX11::with_gtk_theme_variant`.
-- On Windows, revert window background to an empty brush to avoid white flashes when changing scaling.
-- **Breaking:** Removed `Window::set_always_on_top` and related APIs in favor of `Window::set_window_level`.
-- On Windows, MacOS and X11, add always on bottom APIs.
-- On Windows, fix the value in `MouseButton::Other`.
-- On macOS, add `WindowExtMacOS::is_document_edited` and `WindowExtMacOS::set_document_edited` APIs.
-- **Breaking:** Removed `WindowBuilderExtIOS::with_root_view_class`; instead, you should use `[[view layer] addSublayer: ...]` to add an instance of the desired layer class (e.g. `CAEAGLLayer` or `CAMetalLayer`). See `vulkano-win` or `wgpu` for examples of this.
-- On MacOS and Windows, add `Window::set_content_protected`.
-- On MacOS, add `EventLoopBuilderExtMacOS::with_activate_ignoring_other_apps`.
-- On Windows, fix icons specified on `WindowBuilder` not taking effect for windows created after the first one.
-- On Windows and macOS, add `Window::title` to query the current window title.
-- On Windows, fix focusing menubar when pressing `Alt`.
-- On MacOS, made `accepts_first_mouse` configurable.
-- Migrated `WindowBuilderExtUnix::with_resize_increments` to `WindowBuilder`.
-- Added `Window::resize_increments`/`Window::set_resize_increments` to update resize increments at runtime for X11/macOS.
-- macOS/iOS: Use `objc2` instead of `objc` internally.
-- **Breaking:** Bump MSRV from `1.57` to `1.60`.
-- **Breaking:** Split the `platform::unix` module into `platform::x11` and `platform::wayland`. The extension types are similarly renamed.
-- **Breaking:**: Removed deprecated method `platform::unix::WindowExtUnix::is_ready`.
-- Removed `parking_lot` dependency.
-- **Breaking:** On macOS, add support for two-finger touchpad magnification and rotation gestures with new events `WindowEvent::TouchpadMagnify` and `WindowEvent::TouchpadRotate`. Also add support for touchpad smart-magnification gesture with a new event `WindowEvent::SmartMagnify`.
-- **Breaking:** On web, the `WindowBuilderExtWebSys::with_prevent_default` setting (enabled by default), now additionally prevents scrolling of the webpage in mobile browsers, previously it only disabled scrolling on desktop.
-- On Wayland, `wayland-csd-adwaita` now uses `ab_glyph` instead of `crossfont` to render the title for decorations.
-- On Wayland, a new `wayland-csd-adwaita-crossfont` feature was added to use `crossfont` instead of `ab_glyph` for decorations.
-- On Wayland, if not otherwise specified use upstream automatic CSD theme selection.
-- On X11, added `WindowExtX11::with_parent` to create child windows.
-- Added support for `WindowBuilder::with_theme` and `Window::theme` to support per-window dark/light/system theme configuration on macos, windows and wayland.
-- On macOS, added support for `WindowEvent::ThemeChanged`.
-- **Breaking:** Removed `WindowBuilderExtWindows::with_theme` and `WindowBuilderExtWayland::with_wayland_csd_theme` in favour of `WindowBuilder::with_theme`.
-- **Breaking:** Removed `WindowExtWindows::theme` in favour of `Window::theme`.
-- Enabled `doc_auto_cfg` when generating docs on docs.rs for feature labels.
-- **Breaking:** On Android, switched to using [`android-activity`](https://github.com/rib/android-activity) crate as a glue layer instead of [`ndk-glue`](https://github.com/rust-windowing/android-ndk-rs/tree/master/ndk-glue). See [README.md#Android](https://github.com/rust-windowing/winit#Android) for more details. ([#2444](https://github.com/rust-windowing/winit/pull/2444))
-- **Breaking:** Removed support for `raw-window-handle` version `0.4`
-- On Wayland, `RedrawRequested` not emitted during resize.
-- Add a `set_wait_timeout` function to `ControlFlow` to allow waiting for a `Duration`.
-- **Breaking:** Remove the unstable `xlib_xconnection()` function from the private interface.
-- Added Orbital support for Redox OS
-- On X11, added `drag_resize_window` method.
-- Added `Window::set_transparent` to provide a hint about transparency of the window on Wayland and macOS.
-- On macOS, fix the mouse buttons other than left/right/middle being reported as middle.
-- On Wayland, support fractional scaling via the wp-fractional-scale protocol.
-- On web, fix removal of mouse event listeners from the global object upon window destruction.
-- Add WindowAttributes getter to WindowBuilder to allow introspection of default values.
-- Added `Window::set_ime_purpose` for setting the IME purpose, currently implemented on Wayland only.

src/changelog/v0.29.md

@@ -1,289 +0,0 @@
-## 0.29.15
-
-- On X11, fix crash due to xsettings query on systems with incomplete xsettings.
-
-## 0.29.14
-
-- On X11/Wayland, fix `text` and `text_with_all_modifiers` not being `None` during compose.
-- On Wayland, don't reapply cursor grab when unchanged.
-- On X11, fix a bug where some mouse events would be unexpectedly filtered out.
-
-## 0.29.13
-
-- On Web, fix possible crash with `ControlFlow::Wait` and `ControlFlow::WaitUntil`.
-
-## 0.29.12
-
-- On X11, fix use after free during xinput2 handling.
-- On X11, filter close to zero values in mouse device events
-
-## 0.29.11
-
-- Fix compatibility with 32-bit platforms without 64-bit atomics.
-- On macOS, fix incorrect IME cursor rect origin.
-- On Windows, fixed a race condition when sending an event through the loop proxy.
-- On X11, fix swapped instance and general class names.
-- On X11, don't require XIM to run.
-- On X11, fix xkb state not being updated correctly sometimes leading to wrong input.
-- On X11, reload dpi on `_XSETTINGS_SETTINGS` update.
-- On X11, fix deadlock when adjusting DPI and resizing at the same time.
-- On Wayland, disable `Occluded` event handling.
-- On Wayland, fix DeviceEvent::Motion not being sent
-- On Wayland, fix `Focused(false)` being send when other seats still have window focused.
-- On Wayland, fix `Window::set_{min,max}_inner_size` not always applied.
-- On Wayland, fix title in CSD not updated from `AboutToWait`.
-- On Windows, fix inconsistent resizing behavior with multi-monitor setups when repositioning outside the event loop.
-- On Wayland, fix `WAYLAND_SOCKET` not used when detecting platform.
-- On Orbital, fix `logical_key` and `text` not reported in `KeyEvent`.
-- On Orbital, implement `KeyEventExtModifierSupplement`.
-- On Orbital, map keys to `NamedKey` when possible.
-- On Orbital, implement `set_cursor_grab`.
-- On Orbital, implement `set_cursor_visible`.
-- On Orbital, implement `drag_window`.
-- On Orbital, implement `drag_resize_window`.
-- On Orbital, implement `set_transparent`.
-- On Orbital, implement `set_visible`.
-- On Orbital, implement `is_visible`.
-- On Orbital, implement `set_resizable`.
-- On Orbital, implement `is_resizable`.
-- On Orbital, implement `set_maximized`.
-- On Orbital, implement `is_maximized`.
-- On Orbital, implement `set_decorations`.
-- On Orbital, implement `is_decorated`.
-- On Orbital, implement `set_window_level`.
-- On Orbital, emit `DeviceEvent::MouseMotion`.
-
-## 0.29.10
-
-- On Web, account for canvas being focused already before event loop starts.
-- On Web, increase cursor position accuracy.
-
-## 0.29.9
-
-- On X11, fix `NotSupported` error not propagated when creating event loop.
-- On Wayland, fix resize not issued when scale changes
-- On X11 and Wayland, fix arrow up on keypad reported as `ArrowLeft`.
-- On macOS, report correct logical key when Ctrl or Cmd is pressed.
-
-## 0.29.8
-
-- On X11, fix IME input lagging behind.
-- On X11, fix `ModifiersChanged` not sent from xdotool-like input
-- On X11, fix keymap not updated from xmodmap.
-- On X11, reduce the amount of time spent fetching screen resources.
-- On Wayland, fix `Window::request_inner_size` being overwritten by resize.
-- On Wayland, fix `Window::inner_size` not using the correct rounding.
-
-## 0.29.7
-
-- On X11, fix `Xft.dpi` reload during runtime.
-- On X11, fix window minimize.
-
-## 0.29.6
-
-- On Web, fix context menu not being disabled by `with_prevent_default(true)`.
-- On Wayland, fix `WindowEvent::Destroyed` not being delivered after destroying window.
-- Fix `EventLoopExtRunOnDemand::run_on_demand` not working for consequent invocation
-
-## 0.29.5
-
-- On macOS, remove spurious error logging when handling `Fn`.
-- On X11, fix an issue where floating point data from the server is
-  misinterpreted during a drag and drop operation.
-- On X11, fix a bug where focusing the window would panic.
-- On macOS, fix `refresh_rate_millihertz`.
-- On Wayland, disable Client Side Decorations when `wl_subcompositor` is not supported.
-- On X11, fix `Xft.dpi` detection from Xresources.
-- On Windows, fix consecutive calls to `window.set_fullscreen(Some(Fullscreen::Borderless(None)))` resulting in losing previous window state when eventually exiting fullscreen using `window.set_fullscreen(None)`.
-- On Wayland, fix resize being sent on focus change.
-- On Windows, fix `set_ime_cursor_area`.
-
-## 0.29.4
-
-- Fix crash when running iOS app on macOS.
-- On X11, check common alternative cursor names when loading cursor.
-- On X11, reload the DPI after a property change event.
-- On Windows, fix so `drag_window` and `drag_resize_window` can be called from another thread.
-- On Windows, fix `set_control_flow` in `AboutToWait` not being taken in account.
-- On macOS, send a `Resized` event after each `ScaleFactorChanged` event.
-- On Wayland, fix `wl_surface` being destroyed before associated objects.
-- On macOS, fix assertion when pressing `Fn` key.
-- On Windows, add `WindowBuilderExtWindows::with_clip_children` to control `WS_CLIPCHILDREN` style.
-
-## 0.29.3
-
-- On Wayland, apply correct scale to `PhysicalSize` passed in `WindowBuilder::with_inner_size` when possible.
-- On Wayland, fix `RedrawRequested` being always sent without decorations and `sctk-adwaita` feature.
-- On Wayland, ignore resize requests when the window is fully tiled.
-- On Wayland, use `configure_bounds` to constrain `with_inner_size` when compositor wants users to pick size.
-- On Windows, fix deadlock when accessing the state during `Cursor{Enter,Leave}`.
-- On Windows, add support for `Window::set_transparent`.
-- On macOS, fix deadlock when entering a nested event loop from an event handler.
-- On macOS, add support for `Window::set_blur`.
-
-## 0.29.2
-
-- **Breaking:** Bump MSRV from `1.60` to `1.65`.
-- **Breaking:** Add `Event::MemoryWarning`; implemented on iOS/Android.
-- **Breaking:** Bump `ndk` version to `0.8.0`, ndk-sys to `0.5.0`, `android-activity` to `0.5.0`.
-- **Breaking:** Change default `ControlFlow` from `Poll` to `Wait`.
-- **Breaking:** Move `Event::RedrawRequested` to `WindowEvent::RedrawRequested`.
-- **Breaking:** Moved `ControlFlow::Exit` to `EventLoopWindowTarget::exit()` and `EventLoopWindowTarget::exiting()` and removed `ControlFlow::ExitWithCode(_)` entirely.
-- **Breaking:** Moved `ControlFlow` to `EventLoopWindowTarget::set_control_flow()` and `EventLoopWindowTarget::control_flow()`.
-- **Breaking:** `EventLoop::new` and `EventLoopBuilder::build` now return `Result<Self, EventLoopError>`
-- **Breaking:** `WINIT_UNIX_BACKEND` was removed in favor of standard `WAYLAND_DISPLAY` and `DISPLAY` variables.
-- **Breaking:** on Wayland, dispatching user created Wayland queue won't wake up the loop unless winit has event to send back.
-- **Breaking:** remove `DeviceEvent::Text`.
-- **Breaking:** Remove lifetime parameter from `Event` and `WindowEvent`.
-- **Breaking:** Rename `Window::set_inner_size` to `Window::request_inner_size` and indicate if the size was applied immediately.
-- **Breaking:** `ActivationTokenDone` event which could be requested with the new `startup_notify` module, see its docs for more.
-- **Breaking:** `ScaleFactorChanged` now contains a writer instead of a reference to update inner size.
-- **Breaking** `run() -> !` has been replaced by `run() -> Result<(), EventLoopError>` for returning errors without calling `std::process::exit()` ([#2767](https://github.com/rust-windowing/winit/pull/2767))
-- **Breaking** Removed `EventLoopExtRunReturn` / `run_return` in favor of `EventLoopExtPumpEvents` / `pump_events` and `EventLoopExtRunOnDemand` / `run_on_demand` ([#2767](https://github.com/rust-windowing/winit/pull/2767))
-- `RedrawRequested` is no longer guaranteed to be emitted after `MainEventsCleared`, it is now platform-specific when the event is emitted after being requested via `redraw_request()`.
-  - On Windows, `RedrawRequested` is now driven by `WM_PAINT` messages which are requested via `redraw_request()`
-- **Breaking** `LoopDestroyed` renamed to `LoopExiting` ([#2900](https://github.com/rust-windowing/winit/issues/2900))
-- **Breaking** `RedrawEventsCleared` removed ([#2900](https://github.com/rust-windowing/winit/issues/2900))
-- **Breaking** `MainEventsCleared` removed ([#2900](https://github.com/rust-windowing/winit/issues/2900))
-- **Breaking:** Remove all deprecated `modifiers` fields.
-- **Breaking:** Rename `DeviceEventFilter` to `DeviceEvents` reversing the behavior of variants.
-- **Breaking** Add `AboutToWait` event which is emitted when the event loop is about to block and wait for new events ([#2900](https://github.com/rust-windowing/winit/issues/2900))
-- **Breaking:** Rename `EventLoopWindowTarget::set_device_event_filter` to `listen_device_events`.
-- **Breaking:** Rename `Window::set_ime_position` to `Window::set_ime_cursor_area` adding a way to set exclusive zone.
-- **Breaking:** `with_x11_visual` now takes the visual ID instead of the bare pointer.
-- **Breaking** `MouseButton` now supports `Back` and `Forward` variants, emitted from mouse events on Wayland, X11, Windows, macOS and Web.
-- **Breaking:** On Web, `instant` is now replaced by `web_time`.
-- **Breaking:** On Web, dropped support for Safari versions below 13.1.
-- **Breaking:** On Web, the canvas output bitmap size is no longer adjusted.
-- **Breaking:** On Web, the canvas size is not controlled by Winit anymore and external changes to the canvas size will be reported through `WindowEvent::Resized`.
-- **Breaking:** Updated `bitflags` crate version to `2`, which changes the API on exposed types.
-- **Breaking:** `CursorIcon::Arrow` was removed.
-- **Breaking:** `CursorIcon::Hand` is now named `CursorIcon::Pointer`.
-- **Breaking:** `CursorIcon` is now used from the `cursor-icon` crate.
-- **Breaking:** `WindowExtWebSys::canvas()` now returns an `Option`.
-- **Breaking:** Overhaul keyboard input handling.
-  - Replace `KeyboardInput` with `KeyEvent` and `RawKeyEvent`.
-    - Change `WindowEvent::KeyboardInput` to contain a `KeyEvent`.
-    - Change `Event::Key` to contain a `RawKeyEvent`.
-  - Remove `Event::ReceivedCharacter`. In its place, you should use
-    `KeyEvent.text` in combination with `WindowEvent::Ime`.
-  - Replace `VirtualKeyCode` with the `Key` enum.
-  - Replace `ScanCode` with the `KeyCode` enum.
-  - Rename `ModifiersState::LOGO` to `SUPER` and `ModifiersState::CTRL` to `CONTROL`.
-  - Add `PhysicalKey` wrapping `KeyCode` and `NativeKeyCode`.
-  - Add `KeyCode` to refer to keys (roughly) by their physical location.
-  - Add `NativeKeyCode` to represent raw `KeyCode`s which Winit doesn't
-    understand.
-  - Add `Key` to represent the keys after they've been interpreted by the
-    active (software) keyboard layout.
-  - Add `NamedKey` to represent the categorized keys.
-  - Add `NativeKey` to represent raw `Key`s which Winit doesn't understand.
-  - Add `KeyLocation` to tell apart `Key`s which usually "mean" the same thing,
-    but can appear simultaneously in different spots on the same keyboard
-    layout.
-  - Add `Window::reset_dead_keys` to enable application-controlled cancellation
-    of dead key sequences.
-  - Add `KeyEventExtModifierSupplement` to expose additional (and less
-    portable) interpretations of a given key-press.
-  - Add `PhysicalKeyExtScancode`, which lets you convert between scancodes and
-    `PhysicalKey`.
-  - `ModifiersChanged` now uses dedicated `Modifiers` struct.
-- Removed platform-specific extensions that should be retrieved through `raw-window-handle` trait implementations instead:
-  - `platform::windows::HINSTANCE`.
-  - `WindowExtWindows::hinstance`.
-  - `WindowExtWindows::hwnd`.
-  - `WindowExtIOS::ui_window`.
-  - `WindowExtIOS::ui_view_controller`.
-  - `WindowExtIOS::ui_view`.
-  - `WindowExtMacOS::ns_window`.
-  - `WindowExtMacOS::ns_view`.
-  - `EventLoopWindowTargetExtWayland::wayland_display`.
-  - `WindowExtWayland::wayland_surface`.
-  - `WindowExtWayland::wayland_display`.
-  - `WindowExtX11::xlib_window`.
-  - `WindowExtX11::xlib_display`.
-  - `WindowExtX11::xlib_screen_id`.
-  - `WindowExtX11::xcb_connection`.
-- Reexport `raw-window-handle` in `window` module.
-- Add `ElementState::is_pressed`.
-- Add `Window::pre_present_notify` to notify winit before presenting to the windowing system.
-- Add `Window::set_blur` to request a blur behind the window; implemented on Wayland for now.
-- Add `Window::show_window_menu` to request a titlebar/system menu; implemented on Wayland/Windows for now.
-- Implement `AsFd`/`AsRawFd` for `EventLoop<T>` on X11 and Wayland.
-- Implement `PartialOrd` and `Ord` for `MouseButton`.
-- Implement `PartialOrd` and `Ord` on types in the `dpi` module.
-- Make `WindowBuilder` `Send + Sync`.
-- Make iOS `MonitorHandle` and `VideoMode` usable from other threads.
-- Make iOS windows usable from other threads.
-- On Android, add force data to touch events.
-- On Android, added `EventLoopBuilderExtAndroid::handle_volume_keys` to indicate that the application will handle the volume keys manually.
-- On Android, fix `DeviceId` to contain device id's.
-- On Orbital, fix `ModifiersChanged` not being sent.
-- On Wayland, `Window::outer_size` now accounts for **client side** decorations.
-- On Wayland, add `Window::drag_resize_window` method.
-- On Wayland, remove `WINIT_WAYLAND_CSD_THEME` variable.
-- On Wayland, fix `TouchPhase::Canceled` being sent for moved events.
-- On Wayland, fix forward compatibility issues.
-- On Wayland, fix initial window size not restored for maximized/fullscreened on startup window.
-- On Wayland, fix maximized startup not taking full size on GNOME.
-- On Wayland, fix maximized window creation and window geometry handling.
-- On Wayland, fix window not checking that it actually got initial configure event.
-- On Wayland, make double clicking and moving the CSD frame more reliable.
-- On Wayland, support `Occluded` event with xdg-shell v6
-- On Wayland, use frame callbacks to throttle `RedrawRequested` events so redraws will align with compositor.
-- On Web, `ControlFlow::WaitUntil` now uses the Prioritized Task Scheduling API. `setTimeout()`, with a trick to circumvent throttling to 4ms, is used as a fallback.
-- On Web, `EventLoopProxy` now implements `Send`.
-- On Web, `Window` now implements `Send` and `Sync`.
-- On Web, account for CSS `padding`, `border`, and `margin` when getting or setting the canvas position.
-- On Web, add Fullscreen API compatibility for Safari.
-- On Web, add `DeviceEvent::Motion`, `DeviceEvent::MouseWheel`, `DeviceEvent::Button` and `DeviceEvent::Key` support.
-- On Web, add `EventLoopWindowTargetExtWebSys` and `PollStrategy`, which allows to set different strategies for `ControlFlow::Poll`. By default the Prioritized Task Scheduling API is used, but an option to use `Window.requestIdleCallback` is available as well. Both use `setTimeout()`, with a trick to circumvent throttling to 4ms, as a fallback.
-- On Web, add `WindowBuilderExtWebSys::with_append()` to append the canvas element to the web page on creation.
-- On Web, allow event loops to be recreated with `spawn`.
-- On Web, enable event propagation.
-- On Web, fix `ControlFlow::WaitUntil` to never wake up **before** the given time.
-- On Web, fix `DeviceEvent::MouseMotion` only being emitted for each canvas instead of the whole window.
-- On Web, fix `Window:::set_fullscreen` doing nothing when called outside the event loop but during transient activation.
-- On Web, fix pen treated as mouse input.
-- On Web, fix pointer button events not being processed when a buttons is already pressed.
-- On Web, fix scale factor resize suggestion always overwriting the canvas size.
-- On Web, fix some `WindowBuilder` methods doing nothing.
-- On Web, fix some `Window` methods using incorrect HTML attributes instead of CSS properties.
-- On Web, fix the bfcache by not using the `beforeunload` event and map bfcache loading/unloading to `Suspended`/`Resumed` events.
-- On Web, fix touch input not gaining or loosing focus.
-- On Web, fix touch location to be as accurate as mouse position.
-- On Web, handle coalesced pointer events, which increases the resolution of pointer inputs.
-- On Web, implement `Window::focus_window()`.
-- On Web, implement `Window::set_(min|max)_inner_size()`.
-- On Web, implement `WindowEvent::Occluded`.
-- On Web, never return a `MonitorHandle`.
-- On Web, prevent clicks on the canvas to select text.
-- On Web, remove any fullscreen requests from the queue when an external fullscreen activation was detected.
-- On Web, remove unnecessary `Window::is_dark_mode()`, which was replaced with `Window::theme()`.
-- On Web, respect `EventLoopWindowTarget::listen_device_events()` settings.
-- On Web, scale factor and dark mode detection are now more robust.
-- On Web, send mouse position on button release as well.
-- On Web, take all transient activations on the canvas and window into account to queue a fullscreen request.
-- On Web, use `Window.requestAnimationFrame()` to throttle `RedrawRequested` events.
-- On Web, use the correct canvas size when calculating the new size during scale factor change, instead of using the output bitmap size.
-- On Web: fix `Window::request_redraw` not waking the event loop when called from outside the loop.
-- On Web: fix position of touch events to be relative to the canvas.
-- On Windows, add `drag_resize_window` method support.
-- On Windows, add horizontal MouseWheel `DeviceEvent`.
-- On Windows, added `WindowBuilderExtWindows::with_class_name` to customize the internal class name.
-- On Windows, fix IME APIs not working when from non event loop thread.
-- On Windows, fix `CursorEnter/Left` not being sent when grabbing the mouse.
-- On Windows, fix `RedrawRequested` not being delivered when calling `Window::request_redraw` from `RedrawRequested`.
-- On Windows, port to `windows-sys` version 0.48.0.
-- On X11, add a `with_embedded_parent_window` function to the window builder to allow embedding a window into another window.
-- On X11, fix event loop not waking up on `ControlFlow::Poll` and `ControlFlow::WaitUntil`.
-- On X11, fix false positive flagging of key repeats when pressing different keys with no release between presses.
-- On X11, set `visual_id` in returned `raw-window-handle`.
-- On iOS, add ability to change the status bar style.
-- On iOS, add force data to touch events when using the Apple Pencil.
-- On iOS, always wake the event loop when transitioning from `ControlFlow::Poll` to `ControlFlow::Poll`.
-- On iOS, send events `WindowEvent::Occluded(false)`, `WindowEvent::Occluded(true)` when application enters/leaves foreground.
-- On macOS, add tabbing APIs on `WindowExtMacOS` and `EventLoopWindowTargetExtMacOS`.
-- On macOS, fix assertion when pressing `Globe` key.
-- On macOS, fix crash in `window.set_minimized(false)`.
-- On macOS, fix crash when dropping `Window`.

src/changelog/v0.8.md

@@ -1,33 +0,0 @@
-## 0.8.3
-
-- Fixed issue of calls to `set_inner_size` blocking on Windows.
-- Mapped `ISO_Left_Tab` to `VirtualKeyCode::Tab` to make the key work with modifiers
-- Fixed the X11 backed on 32bit targets
-
-## 0.8.2
-
-- Uniformize keyboard scancode values across Wayland and X11 (#297).
-- Internal rework of the wayland event loop
-- Added method `os::linux::WindowExt::is_ready`
-
-## 0.8.1
-
-- Added various methods to `os::linux::EventsLoopExt`, plus some hidden items necessary to make
-  glutin work.
-
-## 0.8.0
-
-- Added `Window::set_maximized`, `WindowAttributes::maximized` and `WindowBuilder::with_maximized`.
-- Added `Window::set_fullscreen`.
-- Changed `with_fullscreen` to take a `Option<MonitorId>` instead of a `MonitorId`.
-- Removed `MonitorId::get_native_identifier()` in favor of platform-specific traits in the `os`
-  module.
-- Changed `get_available_monitors()` and `get_primary_monitor()` to be methods of `EventsLoop`
-  instead of stand-alone methods.
-- Changed `EventsLoop` to be tied to a specific X11 or Wayland connection.
-- Added a `os::linux::EventsLoopExt` trait that makes it possible to configure the connection.
-- Fixed the emscripten code, which now compiles.
-- Changed the X11 fullscreen code to use `xrandr` instead of `xxf86vm`.
-- Fixed the Wayland backend to produce `Refresh` event after window creation.
-- Changed the `Suspended` event to be outside of `WindowEvent`.
-- Fixed the X11 backend sometimes reporting the wrong virtual key (#273).

src/changelog/v0.9.md

@@ -1,22 +0,0 @@
-## 0.9.0
-
-- Added event `WindowEvent::HiDPIFactorChanged`.
-- Added method `MonitorId::get_hidpi_factor`.
-- Deprecated `get_inner_size_pixels` and `get_inner_size_points` methods of `Window` in favor of
-`get_inner_size`.
-- **Breaking:** `EventsLoop` is `!Send` and `!Sync` because of platform-dependant constraints,
-  but `Window`, `WindowId`, `DeviceId` and `MonitorId` guaranteed to be `Send`.
-- `MonitorId::get_position` now returns `(i32, i32)` instead of `(u32, u32)`.
-- Rewrite of the wayland backend to use wayland-client-0.11
-- Support for dead keys on wayland for keyboard utf8 input
-- Monitor enumeration on Windows is now implemented using `EnumDisplayMonitors` instead of
-`EnumDisplayDevices`. This changes the value returned by `MonitorId::get_name()`.
-- On Windows added `MonitorIdExt::hmonitor` method
-- Impl `Clone` for `EventsLoopProxy`
-- `EventsLoop::get_primary_monitor()` on X11 will fallback to any available monitor if no primary is found
-- Support for touch event on wayland
-- `WindowEvent`s `MouseMoved`, `MouseEntered`, and `MouseLeft` have been renamed to
-`CursorMoved`, `CursorEntered`, and `CursorLeft`.
-- New `DeviceEvent`s added, `MouseMotion` and `MouseWheel`.
-- Send `CursorMoved` event after `CursorEntered` and `Focused` events.
-- Add support for `ModifiersState`, `MouseMove`, `MouseInput`, `MouseMotion` for emscripten backend.

src/cursor.rs

@@ -12,7 +12,7 @@ pub const MAX_CURSOR_SIZE: u16 = 2048;
 
 const PIXEL_SIZE: usize = 4;
 
-/// See [`Window::set_cursor()`][crate::window::Window::set_cursor] for more details.
+/// See [`Window::set_cursor()`](crate::window::Window::set_cursor) for more details.
 #[derive(Clone, Debug, Eq, Hash, PartialEq)]
 pub enum Cursor {
     Icon(CursorIcon),
@@ -88,15 +88,6 @@ impl CustomCursor {
         hotspot_x: u16,
         hotspot_y: u16,
     ) -> Result<CustomCursorSource, BadImage> {
-        let _span = tracing::debug_span!(
-            "winit::Cursor::from_rgba",
-            width,
-            height,
-            hotspot_x,
-            hotspot_y
-        )
-        .entered();
-
         Ok(CustomCursorSource {
             inner: PlatformCustomCursorSource::from_rgba(
                 rgba.into(),
@@ -195,7 +186,6 @@ impl OnlyCursorImageSource {
 }
 
 /// Platforms export this directly as `PlatformCustomCursor` if they don't implement caching.
-#[allow(dead_code)]
 #[derive(Debug, Clone)]
 pub(crate) struct OnlyCursorImage(pub(crate) Arc<CursorImage>);
 

src/event.rs

@@ -1,37 +1,36 @@
 //! The [`Event`] enum and assorted supporting types.
 //!
-//! These are sent to the closure given to [`EventLoop::run_app(...)`], where they get
+//! These are sent to the closure given to [`EventLoop::run(...)`], where they get
 //! processed and used to modify the program state. For more details, see the root-level documentation.
 //!
 //! Some of these events represent different "parts" of a traditional event-handling loop. You could
-//! approximate the basic ordering loop of [`EventLoop::run_app(...)`] like this:
+//! approximate the basic ordering loop of [`EventLoop::run(...)`] like this:
 //!
 //! ```rust,ignore
 //! let mut start_cause = StartCause::Init;
 //!
 //! while !elwt.exiting() {
-//!     app.new_events(event_loop, start_cause);
+//!     event_handler(NewEvents(start_cause), elwt);
 //!
-//!     for event in (window events, user events, device events) {
+//!     for e in (window events, user events, device events) {
-//!         // This will pick the right method on the application based on the event.
+//!         event_handler(e, elwt);
-//!         app.handle_event(event_loop, event);
 //!     }
 //!
-//!     for window_id in (redraw windows) {
+//!     for w in (redraw windows) {
-//!         app.window_event(event_loop, window_id, RedrawRequested);
+//!         event_handler(RedrawRequested(w), elwt);
 //!     }
 //!
-//!     app.about_to_wait(event_loop);
+//!     event_handler(AboutToWait, elwt);
 //!     start_cause = wait_if_necessary();
 //! }
 //!
-//! app.exiting(event_loop);
+//! event_handler(LoopExiting, elwt);
 //! ```
 //!
 //! This leaves out timing details like [`ControlFlow::WaitUntil`] but hopefully
 //! describes what happens in what order.
 //!
-//! [`EventLoop::run_app(...)`]: crate::event_loop::EventLoop::run_app
+//! [`EventLoop::run(...)`]: crate::event_loop::EventLoop::run
 //! [`ControlFlow::WaitUntil`]: crate::event_loop::ControlFlow::WaitUntil
 use std::path::PathBuf;
 use std::sync::{Mutex, Weak};
@@ -60,55 +59,199 @@ use crate::{
 /// See the module-level docs for more information on the event loop manages each event.
 #[derive(Debug, Clone, PartialEq)]
 pub enum Event<T: 'static> {
-    /// See [`ApplicationHandler::new_events`] for details.
+    /// Emitted when new events arrive from the OS to be processed.
     ///
-    /// [`ApplicationHandler::new_events`]: crate::application::ApplicationHandler::new_events
+    /// This event type is useful as a place to put code that should be done before you start
+    /// processing events, such as updating frame timing information for benchmarking or checking
+    /// the [`StartCause`] to see if a timer set by
+    /// [`ControlFlow::WaitUntil`](crate::event_loop::ControlFlow::WaitUntil) has elapsed.
     NewEvents(StartCause),
 
-    /// See [`ApplicationHandler::window_event`] for details.
+    /// Emitted when the OS sends an event to a winit window.
-    ///
-    /// [`ApplicationHandler::window_event`]: crate::application::ApplicationHandler::window_event
     WindowEvent {
         window_id: WindowId,
         event: WindowEvent,
     },
 
-    /// See [`ApplicationHandler::device_event`] for details.
+    /// Emitted when the OS sends an event to a device.
-    ///
-    /// [`ApplicationHandler::device_event`]: crate::application::ApplicationHandler::device_event
     DeviceEvent {
         device_id: DeviceId,
         event: DeviceEvent,
     },
 
-    /// See [`ApplicationHandler::user_event`] for details.
+    /// Emitted when an event is sent from [`EventLoopProxy::send_event`](crate::event_loop::EventLoopProxy::send_event)
-    ///
-    /// [`ApplicationHandler::user_event`]: crate::application::ApplicationHandler::user_event
     UserEvent(T),
 
-    /// See [`ApplicationHandler::suspended`] for details.
+    /// Emitted when the application has been suspended.
     ///
-    /// [`ApplicationHandler::suspended`]: crate::application::ApplicationHandler::suspended
+    /// # Portability
+    ///
+    /// Not all platforms support the notion of suspending applications, and there may be no
+    /// technical way to guarantee being able to emit a `Suspended` event if the OS has
+    /// no formal application lifecycle (currently only Android, iOS, and Web do). For this reason,
+    /// Winit does not currently try to emit pseudo `Suspended` events before the application
+    /// quits on platforms without an application lifecycle.
+    ///
+    /// Considering that the implementation of `Suspended` and [`Resumed`] events may be internally
+    /// driven by multiple platform-specific events, and that there may be subtle differences across
+    /// platforms with how these internal events are delivered, it's recommended that applications
+    /// be able to gracefully handle redundant (i.e. back-to-back) `Suspended` or [`Resumed`] events.
+    ///
+    /// Also see [`Resumed`] notes.
+    ///
+    /// ## Android
+    ///
+    /// On Android, the `Suspended` event is only sent when the application's associated
+    /// [`SurfaceView`] is destroyed. This is expected to closely correlate with the [`onPause`]
+    /// lifecycle event but there may technically be a discrepancy.
+    ///
+    /// [`onPause`]: https://developer.android.com/reference/android/app/Activity#onPause()
+    ///
+    /// Applications that need to run on Android should assume their [`SurfaceView`] has been
+    /// destroyed, which indirectly invalidates any existing render surfaces that may have been
+    /// created outside of Winit (such as an `EGLSurface`, [`VkSurfaceKHR`] or [`wgpu::Surface`]).
+    ///
+    /// After being `Suspended` on Android applications must drop all render surfaces before
+    /// the event callback completes, which may be re-created when the application is next [`Resumed`].
+    ///
+    /// [`SurfaceView`]: https://developer.android.com/reference/android/view/SurfaceView
+    /// [Activity lifecycle]: https://developer.android.com/guide/components/activities/activity-lifecycle
+    /// [`VkSurfaceKHR`]: https://www.khronos.org/registry/vulkan/specs/1.3-extensions/man/html/VkSurfaceKHR.html
+    /// [`wgpu::Surface`]: https://docs.rs/wgpu/latest/wgpu/struct.Surface.html
+    ///
+    /// ## iOS
+    ///
+    /// On iOS, the `Suspended` event is currently emitted in response to an
+    /// [`applicationWillResignActive`] callback which means that the application is
+    /// about to transition from the active to inactive state (according to the
+    /// [iOS application lifecycle]).
+    ///
+    /// [`applicationWillResignActive`]: https://developer.apple.com/documentation/uikit/uiapplicationdelegate/1622950-applicationwillresignactive
+    /// [iOS application lifecycle]: https://developer.apple.com/documentation/uikit/app_and_environment/managing_your_app_s_life_cycle
+    ///
+    /// ## Web
+    ///
+    /// On Web, the `Suspended` event is emitted in response to a [`pagehide`] event
+    /// with the property [`persisted`] being true, which means that the page is being
+    /// put in the [`bfcache`] (back/forward cache) - an in-memory cache that stores a
+    /// complete snapshot of a page (including the JavaScript heap) as the user is
+    /// navigating away.
+    ///
+    /// [`pagehide`]: https://developer.mozilla.org/en-US/docs/Web/API/Window/pagehide_event
+    /// [`persisted`]: https://developer.mozilla.org/en-US/docs/Web/API/PageTransitionEvent/persisted
+    /// [`bfcache`]: https://web.dev/bfcache/
+    ///
+    /// [`Resumed`]: Self::Resumed
     Suspended,
 
-    /// See [`ApplicationHandler::resumed`] for details.
+    /// Emitted when the application has been resumed.
     ///
-    /// [`ApplicationHandler::resumed`]: crate::application::ApplicationHandler::resumed
+    /// For consistency, all platforms emit a `Resumed` event even if they don't themselves have a
+    /// formal suspend/resume lifecycle. For systems without a standard suspend/resume lifecycle
+    /// the `Resumed` event is always emitted after the [`NewEvents(StartCause::Init)`][StartCause::Init]
+    /// event.
+    ///
+    /// # Portability
+    ///
+    /// It's recommended that applications should only initialize their graphics context and create
+    /// a window after they have received their first `Resumed` event. Some systems
+    /// (specifically Android) won't allow applications to create a render surface until they are
+    /// resumed.
+    ///
+    /// Considering that the implementation of [`Suspended`] and `Resumed` events may be internally
+    /// driven by multiple platform-specific events, and that there may be subtle differences across
+    /// platforms with how these internal events are delivered, it's recommended that applications
+    /// be able to gracefully handle redundant (i.e. back-to-back) [`Suspended`] or `Resumed` events.
+    ///
+    /// Also see [`Suspended`] notes.
+    ///
+    /// ## Android
+    ///
+    /// On Android, the `Resumed` event is sent when a new [`SurfaceView`] has been created. This is
+    /// expected to closely correlate with the [`onResume`] lifecycle event but there may technically
+    /// be a discrepancy.
+    ///
+    /// [`onResume`]: https://developer.android.com/reference/android/app/Activity#onResume()
+    ///
+    /// Applications that need to run on Android must wait until they have been `Resumed`
+    /// before they will be able to create a render surface (such as an `EGLSurface`,
+    /// [`VkSurfaceKHR`] or [`wgpu::Surface`]) which depend on having a
+    /// [`SurfaceView`]. Applications must also assume that if they are [`Suspended`], then their
+    /// render surfaces are invalid and should be dropped.
+    ///
+    /// Also see [`Suspended`] notes.
+    ///
+    /// [`SurfaceView`]: https://developer.android.com/reference/android/view/SurfaceView
+    /// [Activity lifecycle]: https://developer.android.com/guide/components/activities/activity-lifecycle
+    /// [`VkSurfaceKHR`]: https://www.khronos.org/registry/vulkan/specs/1.3-extensions/man/html/VkSurfaceKHR.html
+    /// [`wgpu::Surface`]: https://docs.rs/wgpu/latest/wgpu/struct.Surface.html
+    ///
+    /// ## iOS
+    ///
+    /// On iOS, the `Resumed` event is emitted in response to an [`applicationDidBecomeActive`]
+    /// callback which means the application is "active" (according to the
+    /// [iOS application lifecycle]).
+    ///
+    /// [`applicationDidBecomeActive`]: https://developer.apple.com/documentation/uikit/uiapplicationdelegate/1622956-applicationdidbecomeactive
+    /// [iOS application lifecycle]: https://developer.apple.com/documentation/uikit/app_and_environment/managing_your_app_s_life_cycle
+    ///
+    /// ## Web
+    ///
+    /// On Web, the `Resumed` event is emitted in response to a [`pageshow`] event
+    /// with the property [`persisted`] being true, which means that the page is being
+    /// restored from the [`bfcache`] (back/forward cache) - an in-memory cache that
+    /// stores a complete snapshot of a page (including the JavaScript heap) as the
+    /// user is navigating away.
+    ///
+    /// [`pageshow`]: https://developer.mozilla.org/en-US/docs/Web/API/Window/pageshow_event
+    /// [`persisted`]: https://developer.mozilla.org/en-US/docs/Web/API/PageTransitionEvent/persisted
+    /// [`bfcache`]: https://web.dev/bfcache/
+    ///
+    /// [`Suspended`]: Self::Suspended
     Resumed,
 
-    /// See [`ApplicationHandler::about_to_wait`] for details.
+    /// Emitted when the event loop is about to block and wait for new events.
     ///
-    /// [`ApplicationHandler::about_to_wait`]: crate::application::ApplicationHandler::about_to_wait
+    /// Most applications shouldn't need to hook into this event since there is no real relationship
+    /// between how often the event loop needs to wake up and the dispatching of any specific events.
+    ///
+    /// High frequency event sources, such as input devices could potentially lead to lots of wake
+    /// ups and also lots of corresponding `AboutToWait` events.
+    ///
+    /// This is not an ideal event to drive application rendering from and instead applications
+    /// should render in response to [`WindowEvent::RedrawRequested`] events.
     AboutToWait,
 
-    /// See [`ApplicationHandler::exiting`] for details.
+    /// Emitted when the event loop is being shut down.
     ///
-    /// [`ApplicationHandler::exiting`]: crate::application::ApplicationHandler::exiting
+    /// This is irreversible - if this event is emitted, it is guaranteed to be the last event that
+    /// gets emitted. You generally want to treat this as a "do on quit" event.
     LoopExiting,
 
-    /// See [`ApplicationHandler::memory_warning`] for details.
+    /// Emitted when the application has received a memory warning.
     ///
-    /// [`ApplicationHandler::memory_warning`]: crate::application::ApplicationHandler::memory_warning
+    /// ## Platform-specific
+    ///
+    /// ### Android
+    ///
+    /// On Android, the `MemoryWarning` event is sent when [`onLowMemory`] was called. The application
+    /// must [release memory] or risk being killed.
+    ///
+    /// [`onLowMemory`]: https://developer.android.com/reference/android/app/Application.html#onLowMemory()
+    /// [release memory]: https://developer.android.com/topic/performance/memory#release
+    ///
+    /// ### iOS
+    ///
+    /// On iOS, the `MemoryWarning` event is emitted in response to an [`applicationDidReceiveMemoryWarning`]
+    /// callback. The application must free as much memory as possible or risk being terminated, see
+    /// [how to respond to memory warnings].
+    ///
+    /// [`applicationDidReceiveMemoryWarning`]: https://developer.apple.com/documentation/uikit/uiapplicationdelegate/1623063-applicationdidreceivememorywarni
+    /// [how to respond to memory warnings]: https://developer.apple.com/documentation/uikit/app_and_environment/managing_your_app_s_life_cycle/responding_to_memory_warnings
+    ///
+    /// ### Others
+    ///
+    /// - **macOS / Wayland / Windows / Orbital:** Unsupported.
     MemoryWarning,
 }
 
@@ -638,31 +781,6 @@ pub struct KeyEvent {
     /// On some systems, holding down a key for some period of time causes that key to be repeated
     /// as though it were being pressed and released repeatedly. This field is `true` if and only if
     /// this event is the result of one of those repeats.
-    ///
-    /// # Example
-    ///
-    /// In games, you often want to ignore repated key events - this can be
-    /// done by ignoring events where this property is set.
-    ///
-    /// ```
-    /// use winit::event::{WindowEvent, KeyEvent, ElementState};
-    /// use winit::keyboard::{KeyCode, PhysicalKey};
-    /// # let window_event = WindowEvent::RedrawRequested; // To make the example compile
-    /// match window_event {
-    ///     WindowEvent::KeyboardInput {
-    ///         event: KeyEvent {
-    ///             physical_key: PhysicalKey::Code(KeyCode::KeyW),
-    ///             state: ElementState::Pressed,
-    ///             repeat: false,
-    ///             ..
-    ///         },
-    ///         ..
-    ///     } => {
-    ///          // The physical key `W` was pressed, and it was not a repeat
-    ///     }
-    ///     _ => {} // Handle other events
-    /// }
-    /// ```
     pub repeat: bool,
 
     /// Platform-specific key event information.
@@ -790,8 +908,8 @@ impl From<ModifiersState> for Modifiers {
 pub enum Ime {
     /// Notifies when the IME was enabled.
     ///
-    /// After getting this event you could receive [`Preedit`][Self::Preedit] and
+    /// After getting this event you could receive [`Preedit`](Self::Preedit) and
-    /// [`Commit`][Self::Commit] events. You should also start performing IME related requests
+    /// [`Commit`](Self::Commit) events. You should also start performing IME related requests
     /// like [`Window::set_ime_cursor_area`].
     Enabled,
 
@@ -811,8 +929,8 @@ pub enum Ime {
 
     /// Notifies when the IME was disabled.
     ///
-    /// After receiving this event you won't get any more [`Preedit`][Self::Preedit] or
+    /// After receiving this event you won't get any more [`Preedit`](Self::Preedit) or
-    /// [`Commit`][Self::Commit] events until the next [`Enabled`][Self::Enabled] event. You should
+    /// [`Commit`](Self::Commit) events until the next [`Enabled`](Self::Enabled) event. You should
     /// also stop issuing IME related requests like [`Window::set_ime_cursor_area`] and clear pending
     /// preedit text.
     Disabled,

src/event_loop.rs

@@ -3,7 +3,7 @@
 //!
 //! If you want to send custom events to the event loop, use
 //! [`EventLoop::create_proxy`] to acquire an [`EventLoopProxy`] and call its
-//! [`send_event`][EventLoopProxy::send_event] method.
+//! [`send_event`](`EventLoopProxy::send_event`) method.
 //!
 //! See the root-level documentation for information on how to create and use an event loop to
 //! handle events.
@@ -18,7 +18,6 @@ use std::time::{Duration, Instant};
 #[cfg(web_platform)]
 use web_time::{Duration, Instant};
 
-use crate::application::ApplicationHandler;
 use crate::error::{EventLoopError, OsError};
 use crate::window::{CustomCursor, CustomCursorSource, Window, WindowAttributes};
 use crate::{event::Event, monitor::MonitorHandle, platform_impl};
@@ -110,8 +109,6 @@ impl<T> EventLoopBuilder<T> {
     )]
     #[inline]
     pub fn build(&mut self) -> Result<EventLoop<T>, EventLoopError> {
-        let _span = tracing::debug_span!("winit::EventLoopBuilder::build").entered();
-
         if EVENT_LOOP_CREATED.swap(true, Ordering::Relaxed) {
             return Err(EventLoopError::RecreationAttempt);
         }
@@ -216,22 +213,8 @@ impl<T> EventLoop<T> {
         }
     }
 
-    /// See [`run_app`].
+    /// Runs the event loop in the calling thread and calls the given `event_handler` closure
-    ///
+    /// to dispatch any pending events.
-    /// [`run_app`]: Self::run_app
-    #[inline]
-    #[deprecated = "use `EventLoop::run_app` instead"]
-    #[cfg(not(all(web_platform, target_feature = "exception-handling")))]
-    pub fn run<F>(self, event_handler: F) -> Result<(), EventLoopError>
-    where
-        F: FnMut(Event<T>, &ActiveEventLoop),
-    {
-        let _span = tracing::debug_span!("winit::EventLoop::run").entered();
-
-        self.event_loop.run(event_handler)
-    }
-
-    /// Run the application with the event loop on the calling thread.
     ///
     /// See the [`set_control_flow()`] docs on how to change the event loop's behavior.
     ///
@@ -246,10 +229,10 @@ impl<T> EventLoop<T> {
     ///   Web applications are recommended to use
     #[cfg_attr(
         web_platform,
-        doc = "[`EventLoopExtWebSys::spawn_app()`][crate::platform::web::EventLoopExtWebSys::spawn_app()]"
+        doc = "[`EventLoopExtWebSys::spawn()`][crate::platform::web::EventLoopExtWebSys::spawn()]"
     )]
     #[cfg_attr(not(web_platform), doc = "`EventLoopExtWebSys::spawn()`")]
-    ///   [^1] instead of [`run_app()`] to avoid the need
+    ///   [^1] instead of [`run()`] to avoid the need
     ///   for the Javascript exception trick, and to make it clearer that the event loop runs
     ///   asynchronously (via the browser's own, internal, event loop) and doesn't block the
     ///   current thread of execution like it does on other platforms.
@@ -257,13 +240,15 @@ impl<T> EventLoop<T> {
     ///   This function won't be available with `target_feature = "exception-handling"`.
     ///
     /// [`set_control_flow()`]: ActiveEventLoop::set_control_flow()
-    /// [`run_app()`]: Self::run_app()
+    /// [`run()`]: Self::run()
-    /// [^1]: `EventLoopExtWebSys::spawn_app()` is only available on Web.
+    /// [^1]: `EventLoopExtWebSys::spawn()` is only available on Web.
     #[inline]
     #[cfg(not(all(web_platform, target_feature = "exception-handling")))]
-    pub fn run_app<A: ApplicationHandler<T>>(self, app: &mut A) -> Result<(), EventLoopError> {
+    pub fn run<F>(self, event_handler: F) -> Result<(), EventLoopError>
-        self.event_loop
+    where
-            .run(|event, event_loop| dispatch_event_for_app(app, event_loop, event))
+        F: FnMut(Event<T>, &ActiveEventLoop),
+    {
+        self.event_loop.run(event_handler)
     }
 
     /// Creates an [`EventLoopProxy`] that can be used to dispatch user events
@@ -289,12 +274,6 @@ impl<T> EventLoop<T> {
     ///
     /// [`DeviceEvent`]: crate::event::DeviceEvent
     pub fn listen_device_events(&self, allowed: DeviceEvents) {
-        let _span = tracing::debug_span!(
-            "winit::EventLoop::listen_device_events",
-            allowed = ?allowed
-        )
-        .entered();
-
         self.event_loop
             .window_target()
             .p
@@ -316,12 +295,6 @@ impl<T> EventLoop<T> {
     #[deprecated = "use `ActiveEventLoop::create_window` instead"]
     #[inline]
     pub fn create_window(&self, window_attributes: WindowAttributes) -> Result<Window, OsError> {
-        let _span = tracing::debug_span!(
-            "winit::EventLoop::create_window",
-            window_attributes = ?window_attributes
-        )
-        .entered();
-
         let window =
             platform_impl::Window::new(&self.event_loop.window_target().p, window_attributes)?;
         Ok(Window { window })
@@ -355,11 +328,11 @@ unsafe impl<T> rwh_05::HasRawDisplayHandle for EventLoop<T> {
 impl<T> AsFd for EventLoop<T> {
     /// Get the underlying [EventLoop]'s `fd` which you can register
     /// into other event loop, like [`calloop`] or [`mio`]. When doing so, the
-    /// loop must be polled with the [`pump_app_events`] API.
+    /// loop must be polled with the [`pump_events`] API.
     ///
     /// [`calloop`]: https://crates.io/crates/calloop
     /// [`mio`]: https://crates.io/crates/mio
-    /// [`pump_app_events`]: crate::platform::pump_events::EventLoopExtPumpEvents::pump_app_events
+    /// [`pump_events`]: crate::platform::pump_events::EventLoopExtPumpEvents::pump_events
     fn as_fd(&self) -> BorrowedFd<'_> {
         self.event_loop.as_fd()
     }
@@ -369,11 +342,11 @@ impl<T> AsFd for EventLoop<T> {
 impl<T> AsRawFd for EventLoop<T> {
     /// Get the underlying [EventLoop]'s raw `fd` which you can register
     /// into other event loop, like [`calloop`] or [`mio`]. When doing so, the
-    /// loop must be polled with the [`pump_app_events`] API.
+    /// loop must be polled with the [`pump_events`] API.
     ///
     /// [`calloop`]: https://crates.io/crates/calloop
     /// [`mio`]: https://crates.io/crates/mio
-    /// [`pump_app_events`]: crate::platform::pump_events::EventLoopExtPumpEvents::pump_app_events
+    /// [`pump_events`]: crate::platform::pump_events::EventLoopExtPumpEvents::pump_events
     fn as_raw_fd(&self) -> RawFd {
         self.event_loop.as_raw_fd()
     }
@@ -390,28 +363,18 @@ impl ActiveEventLoop {
     ///   see the web platform module for more information.
     #[inline]
     pub fn create_window(&self, window_attributes: WindowAttributes) -> Result<Window, OsError> {
-        let _span = tracing::debug_span!(
-            "winit::ActiveEventLoop::create_window",
-            window_attributes = ?window_attributes
-        )
-        .entered();
-
         let window = platform_impl::Window::new(&self.p, window_attributes)?;
         Ok(Window { window })
     }
 
     /// Create custom cursor.
     pub fn create_custom_cursor(&self, custom_cursor: CustomCursorSource) -> CustomCursor {
-        let _span = tracing::debug_span!("winit::ActiveEventLoop::create_custom_cursor",).entered();
-
         self.p.create_custom_cursor(custom_cursor)
     }
 
     /// Returns the list of all the monitors available on the system.
     #[inline]
     pub fn available_monitors(&self) -> impl Iterator<Item = MonitorHandle> {
-        let _span = tracing::debug_span!("winit::ActiveEventLoop::available_monitors",).entered();
-
         #[allow(clippy::useless_conversion)] // false positive on some platforms
         self.p
             .available_monitors()
@@ -428,8 +391,6 @@ impl ActiveEventLoop {
     /// **Wayland / Web:** Always returns `None`.
     #[inline]
     pub fn primary_monitor(&self) -> Option<MonitorHandle> {
-        let _span = tracing::debug_span!("winit::ActiveEventLoop::primary_monitor",).entered();
-
         self.p
             .primary_monitor()
             .map(|inner| MonitorHandle { inner })
@@ -447,12 +408,6 @@ impl ActiveEventLoop {
     ///
     /// [`DeviceEvent`]: crate::event::DeviceEvent
     pub fn listen_device_events(&self, allowed: DeviceEvents) {
-        let _span = tracing::debug_span!(
-            "winit::ActiveEventLoop::listen_device_events",
-            allowed = ?allowed
-        )
-        .entered();
-
         self.p.listen_device_events(allowed);
     }
 
@@ -468,16 +423,14 @@ impl ActiveEventLoop {
 
     /// This exits the event loop.
     ///
-    /// See [`LoopExiting`][Event::LoopExiting].
+    /// See [`LoopExiting`](Event::LoopExiting).
     pub fn exit(&self) {
-        let _span = tracing::debug_span!("winit::ActiveEventLoop::exit",).entered();
-
         self.p.exit()
     }
 
     /// Returns if the [`EventLoop`] is about to stop.
     ///
-    /// See [`exit()`][Self::exit].
+    /// See [`exit()`](Self::exit).
     pub fn exiting(&self) -> bool {
         self.p.exiting()
     }
@@ -577,8 +530,6 @@ impl<T: 'static> EventLoopProxy<T> {
     ///
     /// [`UserEvent(event)`]: Event::UserEvent
     pub fn send_event(&self, event: T) -> Result<(), EventLoopClosed<T>> {
-        let _span = tracing::debug_span!("winit::EventLoopProxy::send_event",).entered();
-
         self.event_loop_proxy.send_event(event)
     }
 }
@@ -641,23 +592,3 @@ impl AsyncRequestSerial {
         Self { serial }
     }
 }
-
-/// Shim for various run APIs.
-#[inline(always)]
-pub(crate) fn dispatch_event_for_app<T: 'static, A: ApplicationHandler<T>>(
-    app: &mut A,
-    event_loop: &ActiveEventLoop,
-    event: Event<T>,
-) {
-    match event {
-        Event::NewEvents(cause) => app.new_events(event_loop, cause),
-        Event::WindowEvent { window_id, event } => app.window_event(event_loop, window_id, event),
-        Event::DeviceEvent { device_id, event } => app.device_event(event_loop, device_id, event),
-        Event::UserEvent(event) => app.user_event(event_loop, event),
-        Event::Suspended => app.suspended(event_loop),
-        Event::Resumed => app.resumed(event_loop),
-        Event::AboutToWait => app.about_to_wait(event_loop),
-        Event::LoopExiting => app.exiting(event_loop),
-        Event::MemoryWarning => app.memory_warning(event_loop),
-    }
-}

src/icon.rs

@@ -118,8 +118,6 @@ impl Icon {
     /// The length of `rgba` must be divisible by 4, and `width * height` must equal
     /// `rgba.len() / 4`. Otherwise, this will return a `BadIcon` error.
     pub fn from_rgba(rgba: Vec<u8>, width: u32, height: u32) -> Result<Self, BadIcon> {
-        let _span = tracing::debug_span!("winit::Icon::from_rgba", width, height).entered();
-
         Ok(Icon {
             inner: PlatformIcon::from_rgba(rgba, width, height)?,
         })

src/keyboard.rs

@@ -218,7 +218,7 @@ impl PartialEq<NativeKeyCode> for NativeKey {
 
 /// Represents the location of a physical key.
 ///
-/// This type is a superset of [`KeyCode`], including an [`Unidentified`][Self::Unidentified]
+/// This type is a superset of [`KeyCode`], including an [`Unidentified`](Self::Unidentified)
 /// variant.
 #[derive(Debug, Clone, Copy, PartialEq, Eq, PartialOrd, Ord, Hash)]
 #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]

src/lib.rs

@@ -21,7 +21,7 @@
 //! Some user activity, like mouse movement, can generate both a [`WindowEvent`] *and* a
 //! [`DeviceEvent`]. You can also create and handle your own custom [`Event::UserEvent`]s, if desired.
 //!
-//! You can retrieve events by calling [`EventLoop::run_app()`]. This function will
+//! You can retrieve events by calling [`EventLoop::run()`]. This function will
 //! dispatch events for every [`Window`] that was created with that particular [`EventLoop`], and
 //! will run until [`exit()`] is used, at which point [`Event::LoopExiting`].
 //!
@@ -36,7 +36,7 @@
         x11_platform,
         wayland_platform
     ),
-    doc = "[`EventLoopExtPumpEvents::pump_app_events()`][platform::pump_events::EventLoopExtPumpEvents::pump_app_events()]"
+    doc = "[`EventLoopExtPumpEvents::pump_events()`][platform::pump_events::EventLoopExtPumpEvents::pump_events()]"
 )]
 #![cfg_attr(
     not(any(
@@ -46,54 +46,18 @@
         x11_platform,
         wayland_platform
     )),
-    doc = "`EventLoopExtPumpEvents::pump_app_events()`"
+    doc = "`EventLoopExtPumpEvents::pump_events()`"
 )]
 //! [^1]. See that method's documentation for more reasons about why
 //! it's discouraged beyond compatibility reasons.
 //!
 //!
 //! ```no_run
-//! use winit::application::ApplicationHandler;
+//! use winit::{
-//! use winit::event::WindowEvent;
+//!     event::{Event, WindowEvent},
-//! use winit::event_loop::{ActiveEventLoop, ControlFlow, EventLoop};
+//!     event_loop::{ControlFlow, EventLoop},
-//! use winit::window::{Window, WindowId};
+//!     window::Window,
-//!
+//! };
-//! #[derive(Default)]
-//! struct App {
-//!     window: Option<Window>,
-//! }
-//!
-//! impl ApplicationHandler for App {
-//!     fn resumed(&mut self, event_loop: &ActiveEventLoop) {
-//!         self.window = Some(event_loop.create_window(Window::default_attributes()).unwrap());
-//!     }
-//!
-//!     fn window_event(&mut self, event_loop: &ActiveEventLoop, id: WindowId, event: WindowEvent) {
-//!         match event {
-//!             WindowEvent::CloseRequested => {
-//!                 println!("The close button was pressed; stopping");
-//!                 event_loop.exit();
-//!             },
-//!             WindowEvent::RedrawRequested => {
-//!                 // Redraw the application.
-//!                 //
-//!                 // It's preferable for applications that do not render continuously to render in
-//!                 // this event rather than in AboutToWait, since rendering in here allows
-//!                 // the program to gracefully handle redraws requested by the OS.
-//!
-//!                 // Draw.
-//!
-//!                 // Queue a RedrawRequested event.
-//!                 //
-//!                 // You only need to call this if you've determined that you need to redraw in
-//!                 // applications which do not always need to. Applications that redraw continuously
-//!                 // can render here instead.
-//!                 self.window.as_ref().unwrap().request_redraw();
-//!             }
-//!             _ => (),
-//!         }
-//!     }
-//! }
 //!
 //! let event_loop = EventLoop::new().unwrap();
 //!
@@ -106,8 +70,43 @@
 //! // input, and uses significantly less power/CPU time than ControlFlow::Poll.
 //! event_loop.set_control_flow(ControlFlow::Wait);
 //!
-//! let mut app = App::default();
+//! let mut window = None;
-//! event_loop.run_app(&mut app);
+//!
+//! event_loop.run(move |event, event_loop| {
+//!     match event {
+//!         Event::Resumed => {
+//!             window = Some(event_loop.create_window(Window::default_attributes()).unwrap());
+//!         }
+//!         Event::WindowEvent {
+//!             event: WindowEvent::CloseRequested,
+//!             ..
+//!         } => {
+//!             println!("The close button was pressed; stopping");
+//!             event_loop.exit();
+//!         },
+//!         Event::AboutToWait => {
+//!             // Application update code.
+//!
+//!             // Queue a RedrawRequested event.
+//!             //
+//!             // You only need to call this if you've determined that you need to redraw in
+//!             // applications which do not always need to. Applications that redraw continuously
+//!             // can render here instead.
+//!             window.as_ref().unwrap().request_redraw();
+//!         },
+//!         Event::WindowEvent {
+//!             event: WindowEvent::RedrawRequested,
+//!             ..
+//!         } => {
+//!             // Redraw the application.
+//!             //
+//!             // It's preferable for applications that do not render continuously to render in
+//!             // this event rather than in AboutToWait, since rendering in here allows
+//!             // the program to gracefully handle redraws requested by the OS.
+//!         },
+//!         _ => ()
+//!     }
+//! });
 //! ```
 //!
 //! [`WindowEvent`] has a [`WindowId`] member. In multi-window environments, it should be
@@ -124,7 +123,7 @@
 //! Note that many platforms will display garbage data in the window's client area if the
 //! application doesn't render anything to the window by the time the desktop compositor is ready to
 //! display the window to the user. If you notice this happening, you should create the window with
-//! [`visible` set to `false`][crate::window::WindowAttributes::with_visible] and explicitly make the
+//! [`visible` set to `false`](crate::window::WindowAttributes::with_visible) and explicitly make the
 //! window visible only once you're ready to render into it.
 //!
 //! # UI scaling
@@ -165,7 +164,7 @@
 //!
 //! [`EventLoop`]: event_loop::EventLoop
 //! [`EventLoop::new()`]: event_loop::EventLoop::new
-//! [`EventLoop::run_app()`]: event_loop::EventLoop::run_app
+//! [`EventLoop::run()`]: event_loop::EventLoop::run
 //! [`exit()`]: event_loop::ActiveEventLoop::exit
 //! [`Window`]: window::Window
 //! [`WindowId`]: window::WindowId
@@ -179,7 +178,7 @@
 //! [`Event::LoopExiting`]: event::Event::LoopExiting
 //! [`raw_window_handle`]: ./window/struct.Window.html#method.raw_window_handle
 //! [`raw_display_handle`]: ./window/struct.Window.html#method.raw_display_handle
-//! [^1]: `EventLoopExtPumpEvents::pump_app_events()` is only available on Windows, macOS, Android, X11 and Wayland.
+//! [^1]: `EventLoopExtPumpEvents::pump_events()` is only available on Windows, macOS, Android, X11 and Wayland.
 
 #![deny(rust_2018_idioms)]
 #![deny(rustdoc::broken_intra_doc_links)]
@@ -201,9 +200,6 @@ pub use rwh_06 as raw_window_handle;
 #[doc(inline)]
 pub use dpi;
 
-pub mod application;
-#[cfg(any(doc, doctest, test))]
-pub mod changelog;
 #[macro_use]
 pub mod error;
 mod cursor;

src/monitor.rs

@@ -3,8 +3,8 @@
 //! If you want to get basic information about a monitor, you can use the
 //! [`MonitorHandle`] type. This is retrieved from one of the following
 //! methods, which return an iterator of [`MonitorHandle`]:
-//! - [`ActiveEventLoop::available_monitors`][crate::event_loop::ActiveEventLoop::available_monitors].
+//! - [`ActiveEventLoop::available_monitors`](crate::event_loop::ActiveEventLoop::available_monitors).
-//! - [`Window::available_monitors`][crate::window::Window::available_monitors].
+//! - [`Window::available_monitors`](crate::window::Window::available_monitors).
 use crate::{
     dpi::{PhysicalPosition, PhysicalSize},
     platform_impl,

src/platform/android.rs

@@ -60,7 +60,7 @@
 //!
 //! If your application is currently based on `NativeActivity` via the `ndk-glue` crate and building with `cargo apk`, then the minimal changes would be:
 //! 1. Remove `ndk-glue` from your `Cargo.toml`
-//! 2. Enable the `"android-native-activity"` feature for Winit: `winit = { version = "0.29.15", features = [ "android-native-activity" ] }`
+//! 2. Enable the `"android-native-activity"` feature for Winit: `winit = { version = "0.29.11", features = [ "android-native-activity" ] }`
 //! 3. Add an `android_main` entrypoint (as above), instead of using the '`[ndk_glue::main]` proc macro from `ndk-macros` (optionally add a dependency on `android_logger` and initialize logging as above).
 //! 4. Pass a clone of the `AndroidApp` that your application receives to Winit when building your event loop (as shown above).
 

src/platform/pump_events.rs

@@ -1,13 +1,22 @@
 use std::time::Duration;
 
-use crate::application::ApplicationHandler;
+use crate::{
-use crate::event::Event;
+    event::Event,
-use crate::event_loop::{self, ActiveEventLoop, EventLoop};
+    event_loop::{ActiveEventLoop, EventLoop},
+};
+
+/// The return status for `pump_events`
+pub enum PumpStatus {
+    /// Continue running external loop.
+    Continue,
+    /// Exit external loop.
+    Exit(i32),
+}
 
 /// Additional methods on [`EventLoop`] for pumping events within an external event loop
 pub trait EventLoopExtPumpEvents {
     /// A type provided by the user that can be passed through [`Event::UserEvent`].
-    type UserEvent: 'static;
+    type UserEvent;
 
     /// Pump the `EventLoop` to check for and dispatch pending events.
     ///
@@ -104,21 +113,6 @@ pub trait EventLoopExtPumpEvents {
     ///   If you render outside of Winit you are likely to see window resizing artifacts
     ///   since MacOS expects applications to render synchronously during any `drawRect`
     ///   callback.
-    fn pump_app_events<A: ApplicationHandler<Self::UserEvent>>(
-        &mut self,
-        timeout: Option<Duration>,
-        app: &mut A,
-    ) -> PumpStatus {
-        #[allow(deprecated)]
-        self.pump_events(timeout, |event, event_loop| {
-            event_loop::dispatch_event_for_app(app, event_loop, event)
-        })
-    }
-
-    /// See [`pump_app_events`].
-    ///
-    /// [`pump_app_events`]: Self::pump_app_events
-    #[deprecated = "use EventLoopExtPumpEvents::pump_app_events"]
     fn pump_events<F>(&mut self, timeout: Option<Duration>, event_handler: F) -> PumpStatus
     where
         F: FnMut(Event<Self::UserEvent>, &ActiveEventLoop);
@@ -134,11 +128,3 @@ impl<T> EventLoopExtPumpEvents for EventLoop<T> {
         self.event_loop.pump_events(timeout, event_handler)
     }
 }
-
-/// The return status for `pump_events`
-pub enum PumpStatus {
-    /// Continue running external loop.
-    Continue,
-    /// Exit external loop.
-    Exit(i32),
-}

src/platform/run_on_demand.rs

@@ -1,7 +1,8 @@
-use crate::application::ApplicationHandler;
+use crate::{
-use crate::error::EventLoopError;
+    error::EventLoopError,
-use crate::event::Event;
+    event::Event,
-use crate::event_loop::{self, ActiveEventLoop, EventLoop};
+    event_loop::{ActiveEventLoop, EventLoop},
+};
 
 #[cfg(doc)]
 use crate::{platform::pump_events::EventLoopExtPumpEvents, window::Window};
@@ -9,19 +10,12 @@ use crate::{platform::pump_events::EventLoopExtPumpEvents, window::Window};
 /// Additional methods on [`EventLoop`] to return control flow to the caller.
 pub trait EventLoopExtRunOnDemand {
     /// A type provided by the user that can be passed through [`Event::UserEvent`].
-    type UserEvent: 'static;
+    type UserEvent;
 
-    /// See [`run_app_on_demand`].
+    /// Runs the event loop in the calling thread and calls the given `event_handler` closure
+    /// to dispatch any window system events.
     ///
-    /// [`run_app_on_demand`]: Self::run_app_on_demand
+    /// Unlike [`EventLoop::run`], this function accepts non-`'static` (i.e. non-`move`) closures
-    #[deprecated = "use EventLoopExtRunOnDemand::run_app_on_demand"]
-    fn run_on_demand<F>(&mut self, event_handler: F) -> Result<(), EventLoopError>
-    where
-        F: FnMut(Event<Self::UserEvent>, &ActiveEventLoop);
-
-    /// Run the application with the event loop on the calling thread.
-    ///
-    /// Unlike [`EventLoop::run_app`], this function accepts non-`'static` (i.e. non-`move`) closures
     /// and it is possible to return control back to the caller without
     /// consuming the `EventLoop` (by using [`exit()`]) and
     /// so the event loop can be re-run after it has exit.
@@ -32,10 +26,11 @@ pub trait EventLoopExtRunOnDemand {
     ///
     /// This API is not designed to run an event loop in bursts that you can exit from and return
     /// to while maintaining the full state of your application. (If you need something like this
-    /// you can look at the [`EventLoopExtPumpEvents::pump_app_events()`] API)
+    /// you can look at the [`EventLoopExtPumpEvents::pump_events()`] API)
     ///
-    /// Each time `run_app_on_demand` is called the startup sequence of `init`, followed by
+    /// Each time `run_on_demand` is called the `event_handler` can expect to receive a
-    /// `resume` is being preserved.
+    /// `NewEvents(Init)` and `Resumed` event (even on platforms that have no suspend/resume
+    /// lifecycle) - which can be used to consistently initialize application state.
     ///
     /// See the [`set_control_flow()`] docs on how to change the event loop's behavior.
     ///
@@ -45,8 +40,8 @@ pub trait EventLoopExtRunOnDemand {
     ///   backend it is possible to use `EventLoopExtWebSys::spawn()`[^1] more than once instead).
     /// - No [`Window`] state can be carried between separate runs of the event loop.
     ///
-    /// You are strongly encouraged to use [`EventLoop::run_app()`] for portability, unless you
+    /// You are strongly encouraged to use [`EventLoop::run()`] for portability, unless you specifically need
-    /// specifically need the ability to re-run a single event loop more than once
+    /// the ability to re-run a single event loop more than once
     ///
     /// # Supported Platforms
     /// - Windows
@@ -69,15 +64,9 @@ pub trait EventLoopExtRunOnDemand {
     ///
     /// [`exit()`]: ActiveEventLoop::exit()
     /// [`set_control_flow()`]: ActiveEventLoop::set_control_flow()
-    fn run_app_on_demand<A: ApplicationHandler<Self::UserEvent>>(
+    fn run_on_demand<F>(&mut self, event_handler: F) -> Result<(), EventLoopError>
-        &mut self,
+    where
-        app: &mut A,
+        F: FnMut(Event<Self::UserEvent>, &ActiveEventLoop);
-    ) -> Result<(), EventLoopError> {
-        #[allow(deprecated)]
-        self.run_on_demand(|event, event_loop| {
-            event_loop::dispatch_event_for_app(app, event_loop, event)
-        })
-    }
 }
 
 impl<T> EventLoopExtRunOnDemand for EventLoop<T> {

src/platform/web.rs

@@ -53,10 +53,9 @@ use std::time::Duration;
 #[cfg(web_platform)]
 use web_sys::HtmlCanvasElement;
 
-use crate::application::ApplicationHandler;
 use crate::cursor::CustomCursorSource;
 use crate::event::Event;
-use crate::event_loop::{self, ActiveEventLoop, EventLoop};
+use crate::event_loop::{ActiveEventLoop, EventLoop};
 #[cfg(web_platform)]
 use crate::platform_impl::CustomCursorFuture as PlatformCustomCursorFuture;
 use crate::platform_impl::PlatformCustomCursorSource;
@@ -161,18 +160,18 @@ impl WindowAttributesExtWebSys for WindowAttributes {
 /// Additional methods on `EventLoop` that are specific to the web.
 pub trait EventLoopExtWebSys {
     /// A type provided by the user that can be passed through `Event::UserEvent`.
-    type UserEvent: 'static;
+    type UserEvent;
 
     /// Initializes the winit event loop.
     ///
     /// Unlike
     #[cfg_attr(
         all(web_platform, target_feature = "exception-handling"),
-        doc = "`run_app()`"
+        doc = "`run()`"
     )]
     #[cfg_attr(
         not(all(web_platform, target_feature = "exception-handling")),
-        doc = "[`run_app()`]"
+        doc = "[`run()`]"
     )]
     /// [^1], this returns immediately, and doesn't throw an exception in order to
     /// satisfy its [`!`] return type.
@@ -184,15 +183,9 @@ pub trait EventLoopExtWebSys {
     ///
     #[cfg_attr(
         not(all(web_platform, target_feature = "exception-handling")),
-        doc = "[`run_app()`]: EventLoop::run_app()"
+        doc = "[`run()`]: EventLoop::run()"
     )]
-    /// [^1]: `run_app()` is _not_ available on WASM when the target supports `exception-handling`.
+    /// [^1]: `run()` is _not_ available on WASM when the target supports `exception-handling`.
-    fn spawn_app<A: ApplicationHandler<Self::UserEvent> + 'static>(self, app: A);
-
-    /// See [`spawn_app`].
-    ///
-    /// [`spawn_app`]: Self::spawn_app
-    #[deprecated = "use EventLoopExtWebSys::spawn_app"]
     fn spawn<F>(self, event_handler: F)
     where
         F: 'static + FnMut(Event<Self::UserEvent>, &ActiveEventLoop);
@@ -201,12 +194,6 @@ pub trait EventLoopExtWebSys {
 impl<T> EventLoopExtWebSys for EventLoop<T> {
     type UserEvent = T;
 
-    fn spawn_app<A: ApplicationHandler<Self::UserEvent> + 'static>(self, mut app: A) {
-        self.event_loop.spawn(move |event, event_loop| {
-            event_loop::dispatch_event_for_app(&mut app, event_loop, event)
-        });
-    }
-
     fn spawn<F>(self, event_handler: F)
     where
         F: 'static + FnMut(Event<Self::UserEvent>, &ActiveEventLoop),
@@ -252,7 +239,7 @@ impl ActiveEventLoopExtWebSys for ActiveEventLoop {
     }
 }
 
-/// Strategy used for [`ControlFlow::Poll`][crate::event_loop::ControlFlow::Poll].
+/// Strategy used for [`ControlFlow::Poll`](crate::event_loop::ControlFlow::Poll).
 #[derive(Clone, Copy, Debug, Default, PartialEq, Eq)]
 pub enum PollStrategy {
     /// Uses [`Window.requestIdleCallback()`] to queue the next event loop. If not available

src/platform/windows.rs

@@ -305,7 +305,7 @@ impl WindowExtWindows for Window {
 pub trait WindowAttributesExtWindows {
     /// Set an owner to the window to be created. Can be used to create a dialog box, for example.
     /// This only works when [`WindowAttributes::with_parent_window`] isn't called or set to `None`.
-    /// Can be used in combination with [`WindowExtWindows::set_enable(false)`][WindowExtWindows::set_enable]
+    /// Can be used in combination with [`WindowExtWindows::set_enable(false)`](WindowExtWindows::set_enable)
     /// on the owner window to create a modal dialog box.
     ///
     /// From MSDN:

src/platform_impl/android/keycodes.rs

@@ -174,7 +174,7 @@ pub fn character_map_and_combine_key(
     let key_map = match app.device_key_character_map(device_id) {
         Ok(key_map) => key_map,
         Err(err) => {
-            tracing::warn!("Failed to look up `KeyCharacterMap` for device {device_id}: {err:?}");
+            log::warn!("Failed to look up `KeyCharacterMap` for device {device_id}: {err:?}");
             return None;
         }
     };
@@ -188,7 +188,7 @@ pub fn character_map_and_combine_key(
                         Ok(Some(key)) => Some(key),
                         Ok(None) => None,
                         Err(err) => {
-                            tracing::warn!("KeyEvent: Failed to combine 'dead key' accent '{accent}' with '{unicode}': {err:?}");
+                            log::warn!("KeyEvent: Failed to combine 'dead key' accent '{accent}' with '{unicode}': {err:?}");
                             None
                         }
                     }
@@ -213,7 +213,7 @@ pub fn character_map_and_combine_key(
             None
         }
         Err(err) => {
-            tracing::warn!("KeyEvent: Failed to get key map character: {err:?}");
+            log::warn!("KeyEvent: Failed to get key map character: {err:?}");
             *combining_accent = None;
             None
         }

src/platform_impl/android/mod.rs

@@ -16,7 +16,7 @@ use android_activity::input::{InputEvent, KeyAction, Keycode, MotionAction};
 use android_activity::{
     AndroidApp, AndroidAppWaker, ConfigurationRef, InputStatus, MainEvent, Rect,
 };
-use tracing::{debug, trace, warn};
+use log::{debug, trace, warn};
 
 use crate::{
     cursor::Cursor,
@@ -330,7 +330,7 @@ impl<T: 'static> EventLoop<T> {
                 }
             },
             Err(err) => {
-                tracing::warn!("Failed to get input events iterator: {err:?}");
+                log::warn!("Failed to get input events iterator: {err:?}");
             }
         }
 
@@ -1014,7 +1014,7 @@ impl Window {
         if let Some(native_window) = self.app.native_window().as_ref() {
             native_window.raw_window_handle()
         } else {
-            tracing::error!("Cannot get the native window, it's null and will always be null before Event::Resumed and after Event::Suspended. Make sure you only call this function between those events.");
+            log::error!("Cannot get the native window, it's null and will always be null before Event::Resumed and after Event::Suspended. Make sure you only call this function between those events.");
             Err(rwh_06::HandleError::Unavailable)
         }
     }

src/platform_impl/ios/app_state.rs

@@ -622,9 +622,9 @@ pub(crate) fn handle_nonuser_events<I: IntoIterator<Item = EventWrapper>>(
         match wrapper {
             EventWrapper::StaticEvent(event) => {
                 if !processing_redraws && event.is_redraw() {
-                    tracing::info!("processing `RedrawRequested` during the main event loop");
+                    log::info!("processing `RedrawRequested` during the main event loop");
                 } else if processing_redraws && !event.is_redraw() {
-                    tracing::warn!(
+                    log::warn!(
                         "processing non `RedrawRequested` event after the main event loop: {:#?}",
                         event
                     );
@@ -676,9 +676,9 @@ pub(crate) fn handle_nonuser_events<I: IntoIterator<Item = EventWrapper>>(
             match wrapper {
                 EventWrapper::StaticEvent(event) => {
                     if !processing_redraws && event.is_redraw() {
-                        tracing::info!("processing `RedrawRequested` during the main event loop");
+                        log::info!("processing `RedrawRequested` during the main event loop");
                     } else if processing_redraws && !event.is_redraw() {
-                        tracing::warn!(
+                        log::warn!(
                             "processing non-`RedrawRequested` event after the main event loop: {:#?}",
                             event
                         );
@@ -911,7 +911,7 @@ macro_rules! os_capabilities {
         impl OSCapabilities {$(
             $(#[$attr])*
             pub fn $error_name(&self, extra_msg: &str) {
-                tracing::warn!(
+                log::warn!(
                     concat!("`", $objc_call, "` requires iOS {}.{}+. This device is running iOS {}.{}.{}. {}"),
                     $major, $minor, self.os_version.majorVersion, self.os_version.minorVersion, self.os_version.patchVersion,
                     extra_msg

src/platform_impl/ios/event_loop.rs

@@ -85,7 +85,7 @@ impl ActiveEventLoop {
     pub(crate) fn exit(&self) {
         // https://developer.apple.com/library/archive/qa/qa1561/_index.html
         // it is not possible to quit an iOS app gracefully and programmatically
-        tracing::warn!("`ControlFlow::Exit` ignored on iOS");
+        log::warn!("`ControlFlow::Exit` ignored on iOS");
     }
 
     pub(crate) fn exiting(&self) -> bool {
@@ -182,7 +182,7 @@ impl<T: 'static> EventLoop<T> {
             application.is_none(),
             "\
                 `EventLoop` cannot be `run` after a call to `UIApplicationMain` on iOS\n\
-                 Note: `EventLoop::run_app` calls `UIApplicationMain` on iOS",
+                 Note: `EventLoop::run` calls `UIApplicationMain` on iOS",
         );
 
         let handler = map_user_event(handler, self.receiver);

src/platform_impl/ios/window.rs

@@ -3,10 +3,10 @@
 use std::collections::VecDeque;
 
 use icrate::Foundation::{CGFloat, CGPoint, CGRect, CGSize, MainThreadBound, MainThreadMarker};
+use log::{debug, warn};
 use objc2::rc::Id;
 use objc2::runtime::{AnyObject, NSObject};
 use objc2::{class, declare_class, msg_send, msg_send_id, mutability, ClassType, DeclaredClass};
-use tracing::{debug, warn};
 
 use super::app_state::EventWrapper;
 use super::uikit::{
@@ -689,7 +689,7 @@ impl Inner {
             let screen_frame = self.rect_to_screen_space(bounds);
             let status_bar_frame = {
                 let app = UIApplication::shared(MainThreadMarker::new().unwrap()).expect(
-                    "`Window::get_inner_position` cannot be called before `EventLoop::run_app` on iOS",
+                    "`Window::get_inner_position` cannot be called before `EventLoop::run` on iOS",
                 );
                 app.statusBarFrame()
             };

src/platform_impl/linux/common/xkb/mod.rs

@@ -4,10 +4,10 @@ use std::ptr::{self, NonNull};
 use std::sync::atomic::{AtomicBool, Ordering};
 
 use crate::utils::Lazy;
+use log::warn;
 use smol_str::SmolStr;
 #[cfg(wayland_platform)]
 use std::os::unix::io::OwnedFd;
-use tracing::warn;
 use xkbcommon_dl::{
     self as xkb, xkb_compose_status, xkb_context, xkb_context_flags, xkbcommon_compose_handle,
     xkbcommon_handle, XkbCommon, XkbCommonCompose,
@@ -373,15 +373,10 @@ impl<'a, 'b> KeyEventResults<'a, 'b> {
 
     fn composed_text(&mut self) -> Result<Option<SmolStr>, ()> {
         match self.compose {
-            ComposeStatus::Accepted(status) => match status {
+            ComposeStatus::Accepted(xkb_compose_status::XKB_COMPOSE_COMPOSED) => {
-                xkb_compose_status::XKB_COMPOSE_COMPOSED => {
+                let state = self.context.compose_state1.as_mut().unwrap();
-                    let state = self.context.compose_state1.as_mut().unwrap();
+                Ok(state.get_string(self.context.scratch_buffer))
-                    Ok(state.get_string(self.context.scratch_buffer))
+            }
-                }
-                xkb_compose_status::XKB_COMPOSE_COMPOSING
-                | xkb_compose_status::XKB_COMPOSE_CANCELLED => Ok(None),
-                xkb_compose_status::XKB_COMPOSE_NOTHING => Err(()),
-            },
             _ => Err(()),
         }
     }
@@ -456,7 +451,7 @@ fn byte_slice_to_smol_str(bytes: &[u8]) -> Option<SmolStr> {
     std::str::from_utf8(bytes)
         .map(SmolStr::new)
         .map_err(|e| {
-            tracing::warn!(
+            log::warn!(
                 "UTF-8 received from libxkbcommon ({:?}) was invalid: {e}",
                 bytes
             )

src/platform_impl/linux/mod.rs

@@ -687,7 +687,7 @@ unsafe extern "C" fn x_error_callback(
 
         // Don't log error.
         if !error_handled {
-            tracing::error!("X11 error: {:#?}", error);
+            log::error!("X11 error: {:#?}", error);
             // XXX only update the error, if it wasn't handled by any of the hooks.
             *xconn.latest_error.lock().unwrap() = Some(error);
         }

src/platform_impl/linux/wayland/event_loop/mod.rs

@@ -584,7 +584,7 @@ impl<T: 'static> EventLoop<T> {
         };
 
         self.event_loop.dispatch(timeout, state).map_err(|error| {
-            tracing::error!("Error dispatching event loop: {}", error);
+            log::error!("Error dispatching event loop: {}", error);
             error.into()
         })
     }

src/platform_impl/linux/wayland/seat/keyboard/mod.rs

@@ -5,7 +5,7 @@ use std::time::Duration;
 
 use calloop::timer::{TimeoutAction, Timer};
 use calloop::{LoopHandle, RegistrationToken};
-use tracing::warn;
+use log::warn;
 
 use sctk::reexports::client::protocol::wl_keyboard::WlKeyboard;
 use sctk::reexports::client::protocol::wl_keyboard::{

src/platform_impl/linux/wayland/state.rs

@@ -133,7 +133,7 @@ impl WinitState {
         ) {
             Ok(c) => Some(c),
             Err(e) => {
-                tracing::warn!("Subcompositor protocol not available, ignoring CSD: {e:?}");
+                log::warn!("Subcompositor protocol not available, ignoring CSD: {e:?}");
                 None
             }
         };

src/platform_impl/linux/wayland/window/mod.rs

@@ -14,7 +14,7 @@ use sctk::shell::xdg::window::Window as SctkWindow;
 use sctk::shell::xdg::window::WindowDecorations;
 use sctk::shell::WaylandSurface;
 
-use tracing::warn;
+use log::warn;
 
 use crate::dpi::{LogicalSize, PhysicalPosition, PhysicalSize, Position, Size};
 use crate::error::{ExternalError, NotSupportedError, OsError as RootOsError};

src/platform_impl/linux/wayland/window/state.rs

@@ -5,7 +5,7 @@ use std::sync::{Arc, Mutex, Weak};
 use std::time::Duration;
 
 use ahash::HashSet;
-use tracing::{info, warn};
+use log::{info, warn};
 
 use sctk::reexports::client::backend::ObjectId;
 use sctk::reexports::client::protocol::wl_seat::WlSeat;
@@ -727,7 +727,7 @@ impl WindowState {
             RootCustomCursor {
                 inner: PlatformCustomCursor::X(_),
             } => {
-                tracing::error!("passed a X11 cursor to Wayland backend");
+                log::error!("passed a X11 cursor to Wayland backend");
                 return;
             }
         };
@@ -826,14 +826,9 @@ impl WindowState {
 
     /// Set the cursor grabbing state on the top-level.
     pub fn set_cursor_grab(&mut self, mode: CursorGrabMode) -> Result<(), ExternalError> {
-        if self.cursor_grab_mode.user_grab_mode == mode {
+        // Replace the user grabbing mode.
-            return Ok(());
-        }
-
-        self.set_cursor_grab_inner(mode)?;
-        // Update user grab on success.
         self.cursor_grab_mode.user_grab_mode = mode;
-        Ok(())
+        self.set_cursor_grab_inner(mode)
     }
 
     /// Reload the hints for minimum and maximum sizes.

src/platform_impl/linux/x11/event_processor.rs

@@ -33,10 +33,9 @@ use crate::platform_impl::platform::common::xkb::Context;
 use crate::platform_impl::platform::x11::ime::{ImeEvent, ImeEventReceiver, ImeRequest};
 use crate::platform_impl::platform::x11::ActiveEventLoop;
 use crate::platform_impl::platform::ActiveEventLoop as PlatformActiveEventLoop;
-use crate::platform_impl::x11::util::cookie::GenericEventCookie;
 use crate::platform_impl::x11::{
     atoms::*, mkdid, mkwid, util, CookieResultExt, Device, DeviceId, DeviceInfo, Dnd, DndState,
-    ImeReceiver, ScrollOrientation, UnownedWindow, WindowId,
+    GenericEventCookie, ImeReceiver, ScrollOrientation, UnownedWindow, WindowId,
 };
 
 /// The maximum amount of X modifiers to replay.
@@ -185,15 +184,14 @@ impl EventProcessor {
             }
             xlib::GenericEvent => {
                 let wt = Self::window_target(&self.target);
-                let xev: GenericEventCookie =
+                let xev = match GenericEventCookie::from_event(&wt.xconn, *xev) {
-                    match GenericEventCookie::from_event(wt.xconn.clone(), *xev) {
+                    Some(xev) if xev.cookie.extension as u8 == self.xi2ext.major_opcode => {
-                        Some(xev) if xev.extension() == self.xi2ext.major_opcode => xev,
+                        xev.cookie
-                        _ => return,
+                    }
-                    };
+                    _ => return,
+                };
 
-                let evtype = xev.evtype();
+                match xev.evtype {
-
-                match evtype {
                     ty @ xinput2::XI_ButtonPress | ty @ xinput2::XI_ButtonRelease => {
                         let state = if ty == xinput2::XI_ButtonPress {
                             ElementState::Pressed
@@ -201,7 +199,7 @@ impl EventProcessor {
                             ElementState::Released
                         };
 
-                        let xev: &XIDeviceEvent = unsafe { xev.as_event() };
+                        let xev: &XIDeviceEvent = unsafe { &*(xev.data as *const _) };
                         self.update_mods_from_xinput2_event(
                             &xev.mods,
                             &xev.group,
@@ -211,7 +209,7 @@ impl EventProcessor {
                         self.xinput2_button_input(xev, state, &mut callback);
                     }
                     xinput2::XI_Motion => {
-                        let xev: &XIDeviceEvent = unsafe { xev.as_event() };
+                        let xev: &XIDeviceEvent = unsafe { &*(xev.data as *const _) };
                         self.update_mods_from_xinput2_event(
                             &xev.mods,
                             &xev.group,
@@ -221,11 +219,11 @@ impl EventProcessor {
                         self.xinput2_mouse_motion(xev, &mut callback);
                     }
                     xinput2::XI_Enter => {
-                        let xev: &XIEnterEvent = unsafe { xev.as_event() };
+                        let xev: &XIEnterEvent = unsafe { &*(xev.data as *const _) };
                         self.xinput2_mouse_enter(xev, &mut callback);
                     }
                     xinput2::XI_Leave => {
-                        let xev: &XILeaveEvent = unsafe { xev.as_event() };
+                        let xev: &XILeaveEvent = unsafe { &*(xev.data as *const _) };
                         self.update_mods_from_xinput2_event(
                             &xev.mods,
                             &xev.group,
@@ -235,51 +233,51 @@ impl EventProcessor {
                         self.xinput2_mouse_left(xev, &mut callback);
                     }
                     xinput2::XI_FocusIn => {
-                        let xev: &XIFocusInEvent = unsafe { xev.as_event() };
+                        let xev: &XIFocusInEvent = unsafe { &*(xev.data as *const _) };
                         self.xinput2_focused(xev, &mut callback);
                     }
                     xinput2::XI_FocusOut => {
-                        let xev: &XIFocusOutEvent = unsafe { xev.as_event() };
+                        let xev: &XIFocusOutEvent = unsafe { &*(xev.data as *const _) };
                         self.xinput2_unfocused(xev, &mut callback);
                     }
                     xinput2::XI_TouchBegin | xinput2::XI_TouchUpdate | xinput2::XI_TouchEnd => {
-                        let phase = match evtype {
+                        let phase = match xev.evtype {
                             xinput2::XI_TouchBegin => TouchPhase::Started,
                             xinput2::XI_TouchUpdate => TouchPhase::Moved,
                             xinput2::XI_TouchEnd => TouchPhase::Ended,
                             _ => unreachable!(),
                         };
 
-                        let xev: &XIDeviceEvent = unsafe { xev.as_event() };
+                        let xev: &XIDeviceEvent = unsafe { &*(xev.data as *const _) };
                         self.xinput2_touch(xev, phase, &mut callback);
                     }
                     xinput2::XI_RawButtonPress | xinput2::XI_RawButtonRelease => {
-                        let state = match evtype {
+                        let state = match xev.evtype {
                             xinput2::XI_RawButtonPress => ElementState::Pressed,
                             xinput2::XI_RawButtonRelease => ElementState::Released,
                             _ => unreachable!(),
                         };
 
-                        let xev: &XIRawEvent = unsafe { xev.as_event() };
+                        let xev: &XIRawEvent = unsafe { &*(xev.data as *const _) };
                         self.xinput2_raw_button_input(xev, state, &mut callback);
                     }
                     xinput2::XI_RawMotion => {
-                        let xev: &XIRawEvent = unsafe { xev.as_event() };
+                        let xev: &XIRawEvent = unsafe { &*(xev.data as *const _) };
                         self.xinput2_raw_mouse_motion(xev, &mut callback);
                     }
                     xinput2::XI_RawKeyPress | xinput2::XI_RawKeyRelease => {
-                        let state = match evtype {
+                        let state = match xev.evtype {
                             xinput2::XI_RawKeyPress => ElementState::Pressed,
                             xinput2::XI_RawKeyRelease => ElementState::Released,
                             _ => unreachable!(),
                         };
 
-                        let xev: &xinput2::XIRawEvent = unsafe { xev.as_event() };
+                        let xev: &xinput2::XIRawEvent = unsafe { &*(xev.data as *const _) };
                         self.xinput2_raw_key_input(xev, state, &mut callback);
                     }
 
                     xinput2::XI_HierarchyChanged => {
-                        let xev: &XIHierarchyEvent = unsafe { xev.as_event() };
+                        let xev: &XIHierarchyEvent = unsafe { &*(xev.data as *const _) };
                         self.xinput2_hierarchy_changed(xev, &mut callback);
                     }
                     _ => {}
@@ -981,7 +979,7 @@ impl EventProcessor {
 
         // Always update the modifiers when we're not replaying.
         if !replay {
-            self.update_mods_from_core_event(window_id, xev.state as u16, &mut callback);
+            self.udpate_mods_from_core_event(window_id, xev.state as u16, &mut callback);
         }
 
         if keycode != 0 && !self.is_composing {
@@ -1520,8 +1518,8 @@ impl EventProcessor {
         let mask =
             unsafe { slice::from_raw_parts(xev.valuators.mask, xev.valuators.mask_len as usize) };
         let mut value = xev.raw_values;
-        let mut mouse_delta = util::Delta::default();
+        let mut mouse_delta = (0.0, 0.0);
-        let mut scroll_delta = util::Delta::default();
+        let mut scroll_delta = (0.0, 0.0);
         for i in 0..xev.valuators.mask_len * 8 {
             if !xinput2::XIMaskIsSet(mask, i) {
                 continue;
@@ -1531,10 +1529,10 @@ impl EventProcessor {
             // We assume that every XInput2 device with analog axes is a pointing device emitting
             // relative coordinates.
             match i {
-                0 => mouse_delta.set_x(x),
+                0 => mouse_delta.0 = x,
-                1 => mouse_delta.set_y(x),
+                1 => mouse_delta.1 = x,
-                2 => scroll_delta.set_x(x as f32),
+                2 => scroll_delta.0 = x as f32,
-                3 => scroll_delta.set_y(x as f32),
+                3 => scroll_delta.1 = x as f32,
                 _ => {}
             }
 
@@ -1550,7 +1548,7 @@ impl EventProcessor {
             value = unsafe { value.offset(1) };
         }
 
-        if let Some(mouse_delta) = mouse_delta.consume() {
+        if mouse_delta != (0.0, 0.0) {
             let event = Event::DeviceEvent {
                 device_id: did,
                 event: DeviceEvent::MouseMotion { delta: mouse_delta },
@@ -1558,7 +1556,7 @@ impl EventProcessor {
             callback(&self.target, event);
         }
 
-        if let Some(scroll_delta) = scroll_delta.consume() {
+        if scroll_delta != (0.0, 0.0) {
             let event = Event::DeviceEvent {
                 device_id: did,
                 event: DeviceEvent::MouseWheel {
@@ -1778,7 +1776,7 @@ impl EventProcessor {
         self.send_modifiers(window_id, mods.into(), true, &mut callback)
     }
 
-    pub fn update_mods_from_core_event<T: 'static, F>(
+    pub fn udpate_mods_from_core_event<T: 'static, F>(
         &mut self,
         window_id: crate::window::WindowId,
         state: u16,

src/platform_impl/linux/x11/ime/context.rs

@@ -86,7 +86,7 @@ extern "C" fn preedit_draw_callback(
     let chg_range =
         call_data.chg_first as usize..(call_data.chg_first + call_data.chg_length) as usize;
     if chg_range.start > client_data.text.len() || chg_range.end > client_data.text.len() {
-        tracing::warn!(
+        log::warn!(
             "invalid chg range: buffer length={}, but chg_first={} chg_lengthg={}",
             client_data.text.len(),
             call_data.chg_first,

src/platform_impl/linux/x11/ime/mod.rs

@@ -10,9 +10,9 @@ use std::sync::{
     Arc,
 };
 
+use log::debug;
 #[cfg(feature = "serde")]
 use serde::{Deserialize, Serialize};
-use tracing::debug;
 
 use super::{ffi, util, XConnection, XError};
 

src/platform_impl/linux/x11/mod.rs

@@ -18,7 +18,7 @@ use calloop::generic::Generic;
 use calloop::EventLoop as Loop;
 use calloop::{ping::Ping, Readiness};
 use libc::{setlocale, LC_CTYPE};
-use tracing::warn;
+use log::warn;
 
 use x11rb::connection::RequestConnection;
 use x11rb::errors::{ConnectError, ConnectionError, IdsExhausted, ReplyError};
@@ -66,9 +66,6 @@ const ALL_DEVICES: u16 = 0;
 const ALL_MASTER_DEVICES: u16 = 1;
 const ICONIC_STATE: u32 = 3;
 
-/// The underlying x11rb connection that we are using.
-type X11rbConnection = x11rb::xcb_ffi::XCBConnection;
-
 type X11Source = Generic<BorrowedFd<'static>>;
 
 struct WakeSender<T> {
@@ -483,7 +480,7 @@ impl<T: 'static> EventLoop<T> {
             .dispatch(timeout, &mut self.state)
             .map_err(std::io::Error::from)
         {
-            tracing::error!("Failed to poll for events: {error:?}");
+            log::error!("Failed to poll for events: {error:?}");
             let exit_code = error.raw_os_error().unwrap_or(1);
             self.set_exit_code(exit_code);
             return;
@@ -567,7 +564,7 @@ impl<T: 'static> EventLoop<T> {
                     callback(event, &self.event_processor.target)
                 }
                 Some(Err(e)) => {
-                    tracing::error!("Failed to get activation token: {}", e);
+                    log::error!("Failed to get activation token: {}", e);
                 }
                 None => {}
             }
@@ -887,9 +884,6 @@ pub enum X11Error {
 
     /// Unable to parse xsettings.
     XsettingsParse(xsettings::ParserError),
-
-    /// Failed to get property.
-    GetProperty(util::GetPropertyError),
 }
 
 impl fmt::Display for X11Error {
@@ -899,7 +893,6 @@ impl fmt::Display for X11Error {
             X11Error::Connect(e) => write!(f, "X11 connection error: {}", e),
             X11Error::Connection(e) => write!(f, "X11 connection error: {}", e),
             X11Error::XidsExhausted(e) => write!(f, "XID range exhausted: {}", e),
-            X11Error::GetProperty(e) => write!(f, "Failed to get X property {}", e),
             X11Error::X11(e) => write!(f, "X11 error: {:?}", e),
             X11Error::UnexpectedNull(s) => write!(f, "Xlib function returned null: {}", s),
             X11Error::InvalidActivationToken(s) => write!(
@@ -992,11 +985,8 @@ impl From<xsettings::ParserError> for X11Error {
     }
 }
 
-impl From<util::GetPropertyError> for X11Error {
+/// The underlying x11rb connection that we are using.
-    fn from(value: util::GetPropertyError) -> Self {
+type X11rbConnection = x11rb::xcb_ffi::XCBConnection;
-        Self::GetProperty(value)
-    }
-}
 
 /// Type alias for a void cookie.
 type VoidCookie<'a> = x11rb::cookie::VoidCookie<'a, X11rbConnection>;
@@ -1013,6 +1003,34 @@ impl<'a, E: fmt::Debug> CookieResultExt for Result<VoidCookie<'a>, E> {
     }
 }
 
+/// XEvents of type GenericEvent store their actual data in an XGenericEventCookie data structure. This is a wrapper to
+/// extract the cookie from a GenericEvent XEvent and release the cookie data once it has been processed
+struct GenericEventCookie<'a> {
+    xconn: &'a XConnection,
+    cookie: ffi::XGenericEventCookie,
+}
+
+impl<'a> GenericEventCookie<'a> {
+    fn from_event(xconn: &XConnection, event: ffi::XEvent) -> Option<GenericEventCookie<'_>> {
+        unsafe {
+            let mut cookie: ffi::XGenericEventCookie = From::from(event);
+            if (xconn.xlib.XGetEventData)(xconn.display, &mut cookie) == ffi::True {
+                Some(GenericEventCookie { xconn, cookie })
+            } else {
+                None
+            }
+        }
+    }
+}
+
+impl<'a> Drop for GenericEventCookie<'a> {
+    fn drop(&mut self) {
+        unsafe {
+            (self.xconn.xlib.XFreeEventData)(self.xconn.display, &mut self.cookie);
+        }
+    }
+}
+
 fn mkwid(w: xproto::Window) -> crate::window::WindowId {
     crate::window::WindowId(crate::platform_impl::platform::WindowId(w as _))
 }

src/platform_impl/linux/x11/util/cookie.rs

@@ -1,55 +0,0 @@
-use std::ffi::c_int;
-use std::sync::Arc;
-
-use x11_dl::xlib::{self, XEvent, XGenericEventCookie};
-
-use crate::platform_impl::x11::XConnection;
-
-/// XEvents of type GenericEvent store their actual data in an XGenericEventCookie data structure.
-/// This is a wrapper to extract the cookie from a GenericEvent XEvent and release the cookie data
-/// once it has been processed
-pub struct GenericEventCookie {
-    cookie: XGenericEventCookie,
-    xconn: Arc<XConnection>,
-}
-
-impl GenericEventCookie {
-    pub fn from_event(xconn: Arc<XConnection>, event: XEvent) -> Option<GenericEventCookie> {
-        unsafe {
-            let mut cookie: XGenericEventCookie = From::from(event);
-            if (xconn.xlib.XGetEventData)(xconn.display, &mut cookie) == xlib::True {
-                Some(GenericEventCookie { cookie, xconn })
-            } else {
-                None
-            }
-        }
-    }
-
-    #[inline]
-    pub fn extension(&self) -> u8 {
-        self.cookie.extension as u8
-    }
-
-    #[inline]
-    pub fn evtype(&self) -> c_int {
-        self.cookie.evtype
-    }
-
-    /// Borrow inner event data as `&T`.
-    ///
-    /// ## SAFETY
-    ///
-    /// The caller must ensure that the event has the `T` inside of it.
-    #[inline]
-    pub unsafe fn as_event<T>(&self) -> &T {
-        unsafe { &*(self.cookie.data as *const _) }
-    }
-}
-
-impl Drop for GenericEventCookie {
-    fn drop(&mut self) {
-        unsafe {
-            (self.xconn.xlib.XFreeEventData)(self.xconn.display, &mut self.cookie);
-        }
-    }
-}

src/platform_impl/linux/x11/util/input.rs

@@ -45,7 +45,7 @@ impl XConnection {
             self.flush_requests()?;
             Ok(true)
         } else {
-            tracing::error!("Could not select XKB events: The XKB extension is not initialized!");
+            log::error!("Could not select XKB events: The XKB extension is not initialized!");
             Ok(false)
         }
     }